Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036439Retail ModulesStoreServerpublic2017-07-06 16:472017-09-02 23:46
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036439: Allow export of data in client 0
DescriptionThis issue [1] enabled the synchronization of records defined in the client 0, but this feature is still missing from the export.store.data process.

The export.store.data process should follow the same logic as the synchronization, that is, a record defined in client 0 will be exported if:
- It does not have an ad_module_id column
- It has an ad_module_id column but it is null

It is important to take all the measures needed to prevent exporting store data in client 0 that is also imported by other means, e.g. as part of the ADRD dataset.

[1] https://issues.openbravo.com/view.php?id=35917 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0035917RR17Q3 closed mtaal Retail Modules Allow replication of data in client 0/org 0 
related to feature request 0036440 closed AugustoMauch Openbravo ERP Allow subclasses of DataSetTableQueryGenerator to customize generated query where clause 
related to defect 0036388 closed AugustoMauch Retail Modules ad_treenodes that reference the '10' and '50' ad_trees should not be exported 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-06 16:47AugustoMauchNew Issue
2017-07-06 16:47AugustoMauchAssigned To => AugustoMauch
2017-07-06 16:47AugustoMauchOBNetwork customer => No
2017-07-06 16:47AugustoMauchTriggers an Emergency Pack => No
2017-07-06 16:48AugustoMauchRelationship addedrelated to 0035917
2017-07-10 13:04AugustoMauchRelationship addedrelated to 0036388
2017-07-14 13:28AugustoMauchRelationship addedrelated to 0036440
2017-08-01 10:02AugustoMauchStatusnew => scheduled
2017-08-01 10:04AugustoMauchNote Added: 0098290
2017-08-01 10:04AugustoMauchNote Edited: 0098290bug_revision_view_page.php?bugnote_id=0098290#r15561
2017-08-30 11:15hgbotCheckin
2017-08-30 11:15hgbotNote Added: 0098729
2017-08-30 11:15hgbotStatusscheduled => resolved
2017-08-30 11:15hgbotResolutionopen => fixed
2017-08-30 11:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/b5f5a6fb2ff4d9b6f5dd2a8f5525f0096311b0a4 [^]
2017-08-30 11:22hgbotCheckin
2017-08-30 11:22hgbotNote Added: 0098730
2017-08-30 11:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/b5f5a6fb2ff4d9b6f5dd2a8f5525f0096311b0a4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/2610520ee2e3dc6d298df58b2c6527b170dcec94 [^]
2017-08-30 11:38AugustoMauchReview Assigned To => mtaal
2017-09-02 23:46mtaalNote Added: 0098782
2017-09-02 23:46mtaalStatusresolved => closed
2017-09-02 23:46mtaalFixed in Version => RR17Q4

Notes
(0098290)
AugustoMauch   
2017-08-01 10:04   
The development is pending to be reviewed, it has been pushed to these two repos [1], [2]

[1] https://code.openbravo.com/erp/pmods-branches/org.openbravo.replication.symmetricds-client-0 [^]
[2] https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.storeserver.synchronization-client-0 [^]
(0098729)
hgbot   
2017-08-30 11:15   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: b5f5a6fb2ff4d9b6f5dd2a8f5525f0096311b0a4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 30 11:05:31 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/b5f5a6fb2ff4d9b6f5dd2a8f5525f0096311b0a4 [^]

Fixes issue 36439: Allows export of data in client 0

Now the data defined in client 0 (System) can also be exported to a store, as long as:
- It belong to a table that does not have an ad_module_id column, or that column is null
- The data is not part of ADRD or a standard dataset.

---
M src/org/openbravo/replication/symmetricds/export/StoreDataSetTableQueryGenerator.java
M src/org/openbravo/replication/symmetricds/validation/ExportedTableValidator.java
---
(0098730)
hgbot   
2017-08-30 11:22   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 2610520ee2e3dc6d298df58b2c6527b170dcec94
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 30 11:10:20 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/2610520ee2e3dc6d298df58b2c6527b170dcec94 [^]

Fixes issue 36439: Allows export of data in client 0

Now the data defined in client 0 (System) can also be exported to a store, as long as:
- It belong to a table that does not have an ad_module_id column, or that column is null
- The data is not part of ADRD or a standard dataset.

---
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData.java
M src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreData_data.xsql
A src/org/openbravo/retail/storeserver/synchronization/task/ExportStoreDataSetTableQueryGenerator.java
---
(0098782)
mtaal   
2017-09-02 23:46   
Reviewed