Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036438Openbravo ERP09. Financial managementpublic2017-07-06 16:352017-07-07 09:55
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
3.0PR17Q4 
alostale
Core
No
0036438: get pi clean of plpgsql_check warnigns to enable check in ci (unused declared variables removal)
Using plpgsql_check tool we found a few pl-functions & triggers we accumulated some unused declared variables again after doing cleanup many month ago.

This issue will clean all those up to be able to add check in ci to avoid introducing new ones.

 38 | c_invoiceline_before_trg() | unused variable "v_priceline" | warning | | | | |
 36 | c_invoiceline_trg2() | unused variable "v_totallines" | warning | | | | |
 37 | c_invoiceline_trg2() | unused variable "v_grandtotal" | warning | | | | |
 56 | c_invoiceline_trg2() | unused variable "v_priceline" | warning | | | | |
 46 | c_orderline_trg() | unused variable "v_priceline" | warning | | | | |
 58 | c_orderline_trg2() | unused variable "v_priceline" | warning | | | | |
 45 | m_explodebomnotstock(character varying,character varying) | unused variable "v_count" | warning | | | | |
 29 | m_get_default_aum_for_document(character varying,character varying) | unused variable "cur_m_product_aum" | warning | | | | |
 418 | m_inout_create(character varying,character varying,character varying,character,character varying) | unused variable "v_locator_id" | warning | | | | |
 32 | m_inoutexplodebomnotstock(character varying,character varying) | unused variable "v_count" | warning | | | | |
 54 | m_production_run(character varying) | unused variable "v_locator_id" | warning | | | | |
 63 | m_requisition_createpo(character varying) | unused variable "v_count" | warning | | | | |
run plpgsql_check and find the 'unused declared variables' warnings
No tags attached.
Issue History
2017-07-06 16:35shuehnerNew Issue
2017-07-06 16:35shuehnerAssigned To => shuehner
2017-07-06 16:35shuehnerModules => Core
2017-07-06 16:35shuehnerTriggers an Emergency Pack => No
2017-07-06 16:37hgbotCheckin
2017-07-06 16:37hgbotNote Added: 0097920
2017-07-06 16:37hgbotStatusnew => resolved
2017-07-06 16:37hgbotResolutionopen => fixed
2017-07-06 16:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c4977d54716692d894b988dd840ee17b5f224908 [^]
2017-07-06 16:39shuehnerNote Added: 0097921
2017-07-07 09:55alostaleReview Assigned To => alostale
2017-07-07 09:55alostaleNote Added: 0097930
2017-07-07 09:55alostaleStatusresolved => closed
2017-07-07 09:55alostaleFixed in Version => 3.0PR17Q4

Notes
(0097920)
hgbot   
2017-07-06 16:37   
Repository: erp/devel/pi
Changeset: c4977d54716692d894b988dd840ee17b5f224908
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 06 16:36:53 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c4977d54716692d894b988dd840ee17b5f224908 [^]

Fixed 36438. Removed unused variables from pl-functions & -triggers.

That removes all unused variables in pl-code as found by plpgsql_check
warnings.

---
M src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
M src-db/database/model/functions/M_GET_DEFAULT_AUM_FOR_DOCUMENT.xml
M src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml
M src-db/database/model/functions/M_INOUT_CREATE.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
---
(0097921)
shuehner   
2017-07-06 16:39   
Note to reviewer: pl is searching for variables case-insensitive so when double checking for really being unused take that into account
(0097930)
alostale   
2017-07-07 09:55   
reviewed none of the removed variables is actually used