Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036433Openbravo ERPA. Platformpublic2017-07-06 13:232018-01-30 13:07
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036433: DataSourceJavaScriptCreator class is deprecated and not used so candidate for removal
DescriptionThis class is deprecated an unused since this commit from 2011 so so candidate for removal.
Quick check is all modules did not find any usage.

Note: when removing there is a also deprecated getter in the BaseDataSourceService class (for which also no user exists)

changeset: 13735:72b0ca062988
user: Martin Taal <martin.taal@openbravo.com>
date: Thu Sep 08 14:09:20 2011 +0200
description:
Related to issue 18470: Performance: generate smaller javascript for a window, improve view generation performance

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0037770 closed alostale API change: some removals in very old and obsolete code 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-06 13:23shuehnerNew Issue
2017-07-06 13:23shuehnerAssigned To => platform
2017-07-06 13:23shuehnerModules => Core
2017-07-06 13:23shuehnerTriggers an Emergency Pack => No
2017-12-16 16:53shuehnerRelationship addedblocks 0032688
2018-01-30 12:42alostaleAssigned Toplatform => shuehner
2018-01-30 12:59alostaleRelationship addeddepends on 0037770
2018-01-30 13:03hgbotCheckin
2018-01-30 13:03hgbotNote Added: 0102046
2018-01-30 13:03hgbotStatusnew => resolved
2018-01-30 13:03hgbotResolutionopen => fixed
2018-01-30 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c9bc9a003c2c3218b224413b8146a1592d047c28 [^]
2018-01-30 13:07alostaleReview Assigned To => alostale
2018-01-30 13:07alostaleStatusresolved => closed
2018-01-30 13:07alostaleFixed in Version => 3.0PR18Q2

Notes
(0102046)
hgbot   
2018-01-30 13:03   
Repository: erp/devel/pi
Changeset: c9bc9a003c2c3218b224413b8146a1592d047c28
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 17:33:27 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c9bc9a003c2c3218b224413b8146a1592d047c28 [^]

Fixed 36433. Delete long time deprecated and unused DataSourceJaaScriptCreator

This class has been deprecated long time ago and is also not used anywhere in pi.
Checking getAllModules also does not show any user.
Same applies for the deprecated getter method in the BaseDataSourceService.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
R modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceJavaScriptCreator.java
---