Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036431Openbravo ERPA. Platformpublic2017-07-06 13:082017-07-07 12:38
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036431: Cleanup logging (modules/platform part) using or mentioned printStackTrace or System.*.print*
DescriptionAs part of getting better logging all uses of i.e. printStackTrace or System.*.print* should be avoided whenever possible.

This issue tracks such bad usage in ERP platform code.
Steps To Reproducecd modules
grep -IrE '(System.(err|out)|printStackTrace)' . | grep -v src-test | less
Proposed SolutionConvert them to use proper log4j
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036162 acknowledged Triage Platform Base clean up openbravo.log 
related to defect 0036432 closed alostale api-change: Remove debugging code 'main method' to run CryptoUtility.java from commandline outside of erp 
Attached Files? 32143.hgexport (4,071) 2017-07-06 13:19
https://issues.openbravo.com/file_download.php?file_id=10895&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-06 13:08shuehnerNew Issue
2017-07-06 13:08shuehnerAssigned To => shuehner
2017-07-06 13:08shuehnerOBNetwork customer => No
2017-07-06 13:08shuehnerModules => Core
2017-07-06 13:08shuehnerTriggers an Emergency Pack => No
2017-07-06 13:08shuehnerRelationship addedrelated to 0036162
2017-07-06 13:16shuehnerRelationship addedrelated to 0036432
2017-07-06 13:19shuehnerFile Added: 32143.hgexport
2017-07-07 12:33hgbotCheckin
2017-07-07 12:33hgbotNote Added: 0097943
2017-07-07 12:33hgbotStatusnew => resolved
2017-07-07 12:33hgbotResolutionopen => fixed
2017-07-07 12:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0a461eef07c36ded143a2203bdbf51a32c54d8b0 [^]
2017-07-07 12:33alostaleReview Assigned To => alostale
2017-07-07 12:38alostaleNote Added: 0097945
2017-07-07 12:38alostaleStatusresolved => closed
2017-07-07 12:38alostaleFixed in Version => 3.0PR17Q4

Notes
(0097943)
hgbot   
2017-07-07 12:33   
Repository: erp/devel/pi
Changeset: 0a461eef07c36ded143a2203bdbf51a32c54d8b0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 06 13:18:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0a461eef07c36ded143a2203bdbf51a32c54d8b0 [^]

Fixed 36431. Cleanup logging: Removes uses of printStackTrace + System.*.print*

Cleanup some uses of bad logging + mention of same in comments.
In case of CryptoUtiliy, delete main method having bad usages (api-change).

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/StandardWindowComponent.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
M src-core/src/org/openbravo/utils/CryptoUtility.java
M src/org/openbravo/dal/security/EntityAccessChecker.java
---
(0097945)
alostale   
2017-07-07 12:38   
reviewed