Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036426Retail ModulesWeb POSpublic2017-06-05 11:302017-09-15 13:33
Reporteregoitz 
Assigned Toebecerra 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q3Fixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket47012
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036426: Perforamnce problems loading the master data for discounts.
DescriptionOn environment with a lot of product characteristics, the load of the
DiscountFiltercharactaritic model takes long.
Steps To Reproduce-Login on webpos on an environment with a big amount of characteristics
*The query of the DiscountFiltercharactaritic model takes long.
Proposed SolutionON modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
replace
hql += " left join c.characteristic.productCharacteristicValueList cvl ";
with
hql += " left join c.characteristic.characteristicValueList cvl ";

and
hql += " and m_isparent_ch_value(cvl.characteristicValue.id, c.chValue.id, c.characteristic.id) != -1 ";
with
 hql += " and m_isparent_ch_value(cvl.id, c.chValue.id, c.characteristic.id) != -1 ";


Also edit the file
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristicProperties.java
by replacing
add(new HQLProperty("distinct(coalesce(c.id,cvl.characteristicValue.id))", "id"));
with
add(new HQLProperty("distinct(coalesce(c.id,cvl.id))", "id"));

and
add(new HQLProperty("cvl.characteristicValue.id", "chValue"));
with
add(new HQLProperty("cvl.id", "chValue"));
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036175 closed ebecerra Perforamnce problems loading the master data for discounts. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-06 08:47marvintmTypedefect => backport
2017-07-06 08:47marvintmTarget Version => RR17Q3
2017-09-04 11:43hgbotCheckin
2017-09-04 11:43hgbotNote Added: 0098798
2017-09-04 11:43hgbotStatusscheduled => resolved
2017-09-04 11:43hgbotResolutionopen => fixed
2017-09-04 11:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31e4ae9b1728a4afcccb7c391392124513dcdb2f [^] => http://code.openbravo.com/retail/backports/3.0RR17Q3/org.openbravo.retail.posterminal/rev/8f39a4bef406b12a7e370bc8f2bfb21438d0c66e [^]
2017-09-15 13:33marvintmReview Assigned To => marvintm
2017-09-15 13:33marvintmStatusresolved => closed
2017-09-15 13:33marvintmFixed in Version => RR17Q3

Notes
(0098798)
hgbot   
2017-09-04 11:43   
Repository: retail/backports/3.0RR17Q3/org.openbravo.retail.posterminal
Changeset: 8f39a4bef406b12a7e370bc8f2bfb21438d0c66e
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Thu Jun 29 12:32:14 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3/org.openbravo.retail.posterminal/rev/8f39a4bef406b12a7e370bc8f2bfb21438d0c66e [^]

Fixed issue 36426: Optimize loading the master data for discounts

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristicProperties.java
---