0036426: Perforamnce problems loading the master data for discounts.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036426

Retail Modules

Web POS

public

2017-06-05 11:30

2017-09-15 13:33

Reporter

egoitz

Assigned To

ebecerra

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR17Q3

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036426: Perforamnce problems loading the master data for discounts.

Description

On environment with a lot of product characteristics, the load of the
DiscountFiltercharactaritic model takes long.

Steps To Reproduce

-Login on webpos on an environment with a big amount of characteristics
*The query of the DiscountFiltercharactaritic model takes long.

Proposed Solution

ON modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
replace
hql += " left join c.characteristic.productCharacteristicValueList cvl ";
with
hql += " left join c.characteristic.characteristicValueList cvl ";

and
hql += " and m_isparent_ch_value(cvl.characteristicValue.id, c.chValue.id, c.characteristic.id) != -1 ";
with
hql += " and m_isparent_ch_value(cvl.id, c.chValue.id, c.characteristic.id) != -1 ";

Also edit the file
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristicProperties.java
by replacing
add(new HQLProperty("distinct(coalesce(c.id,cvl.characteristicValue.id))", "id"));
with
add(new HQLProperty("distinct(coalesce(c.id,cvl.id))", "id"));

and
add(new HQLProperty("cvl.characteristicValue.id", "chValue"));
with
add(new HQLProperty("cvl.id", "chValue"));

Additional Information