Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036421Openbravo ERPA. Platformpublic2017-07-05 17:422019-03-28 14:55
Reporterngarcia 
Assigned Toalostale 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036421: Financial Account records are not filtered by name if the filter contains "-"
DescriptionFinancial Account records are not filtered by name if the filter contains "-"
Steps To ReproduceAs group admin role:
   Go to Financial Account window
   Check the following records exist on it:
      Bank - Account 1
      Bank - Account 2
   Select Bank - Account 2, right click on it and Use as filter
   Check both accounts are shown
   If the problem is not reproducible, clean the filters with the funnel icon, refresh the grid and repeat the process in order to force the call to the server

   Remove the "-" from the filter and check the filter is correctly applied in that case
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020643 closed guilleaer fillters columns does not work when there are records with the character "-" 
related to defect 0025361 closed alostale Unneeded queries when filtering 
related to design defect 0025211 closed AugustoMauch Filter by selected value in FK uses identifier instead of ID 
related to defect 00235303.0MP23 closed mtaal Filtering with a multiple value is not working properly 
has duplicate defect 0039873 closed platform Filter not working after 'Fund Transfer' Process 
related to defect 0040057 closed markmm82 qa-pi-aum and qa-pi-returnto suites fail 
Attached Files? qa-pi-aum-pgsql-AUMRTVd010-build311-text.ParseException __ 29-01-2019 13_05_27.avi (2,823,788) 2019-01-29 17:56
https://issues.openbravo.com/file_download.php?file_id=12564&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-05 17:42ngarciaNew Issue
2017-07-05 17:42ngarciaAssigned To => platform
2017-07-05 17:42ngarciaModules => Core
2017-07-05 17:42ngarciaTriggers an Emergency Pack => No
2017-07-05 17:42ngarciaIssue Monitored: networkb
2017-07-05 17:44ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15467#r15467
2017-07-05 17:55RenateNieuwkoopIssue Monitored: RenateNieuwkoop
2017-07-05 18:00ngarciaRelationship addedrelated to 0020643
2017-07-05 18:02caristuRelationship addedrelated to 0025361
2017-07-05 18:06caristuNote Added: 0097880
2017-07-05 18:07caristuRelationship addedrelated to 0025211
2017-07-06 09:13alostaleStatusnew => acknowledged
2019-01-23 13:36alostaleRelationship addedhas duplicate 0039873
2019-01-23 13:49hgbotCheckin
2019-01-23 13:49hgbotNote Added: 0109113
2019-01-23 13:49hgbotStatusacknowledged => resolved
2019-01-23 13:49hgbotResolutionopen => fixed
2019-01-23 13:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/674d467c1b3b3f30fc083bd34795d5fa84792fe3 [^]
2019-01-23 13:49hgbotCheckin
2019-01-23 13:49hgbotNote Added: 0109114
2019-01-25 09:08caristuReview Assigned To => caristu
2019-01-25 09:08caristuAssigned Toplatform => alostale
2019-01-29 17:56inaki_garciaNote Added: 0109313
2019-01-29 17:56inaki_garciaStatusresolved => new
2019-01-29 17:56inaki_garciaResolutionfixed => open
2019-01-29 17:57inaki_garciaFile Added: qa-pi-aum-pgsql-AUMRTVd010-build311-text.ParseException __ 29-01-2019 13_05_27.avi
2019-01-30 09:18alostaleStatusnew => acknowledged
2019-01-30 09:18alostaleStatusacknowledged => scheduled
2019-01-30 09:38alostaleNote Added: 0109319
2019-01-30 09:38alostaleStatusscheduled => resolved
2019-01-30 09:38alostaleResolutionopen => fixed
2019-01-30 09:38alostaleRelationship addedrelated to 0040057
2019-02-01 14:05caristuRelationship addedrelated to 0023530
2019-02-01 15:11caristuNote Added: 0109441
2019-02-01 15:11caristuStatusresolved => closed
2019-02-01 15:11caristuFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110756
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110757

Notes
(0097880)
caristu   
2017-07-05 18:06   
The problem is on the following line[1]. Following the steps to reproduce when this line is reached the condition is true and the filter value is being split by the "-".

Thus, the query is filtering just by "%Bank%", and the two records matching this are returned.

[1] https://code.openbravo.com/erp/devel/pi/file/b06cf6616ecc/modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java#l795 [^]
(0109113)
hgbot   
2019-01-23 13:49   
Repository: erp/devel/pi
Changeset: 674d467c1b3b3f30fc083bd34795d5fa84792fe3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 23 13:40:27 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/674d467c1b3b3f30fc083bd34795d5fa84792fe3 [^]

fixed bug 36421: can't filter compound identifiers using "-" in filter

  When filterin a compound identifier or any property being part of a compound
  identifier using an expression including "-" character, everything after it got
  removed.

  This is no longer necessary as it was includeded at the very beginning when AQB
  didn't include proper joins to the identifiers, now they are included so it is
  not necessary to remove anything from the filter expression.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0109114)
hgbot   
2019-01-23 13:49   
Repository: erp/devel/pi
Changeset: 31cca65027c8177f32e8164388a50a1dbdcfbe1b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 23 13:48:18 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/31cca65027c8177f32e8164388a50a1dbdcfbe1b [^]

related to bug 36421: minor code cleanup

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0109313)
inaki_garcia   
2019-01-29 17:56   
Same issue has arised in the "Return to Vendor Shipment"'s "Pick/Edit Lines" popup since this fix has been applied, which requires
of a more general solution. The jobs failing are qa-pi-aum and qa-pi-returnto, with the AUMRTVd010 and RTVd010 tests respectively,
and both with Postgres and Oracle DBs.

A video has been attached with the execution of build #311 of qa-pi-aum-pgsql. The value '13 - 29-01-2019 - -125.40' is inputted in
the timestamp 05:11, moment at which the value '13' is expected to be filtered.
(0109319)
alostale   
2019-01-30 09:38   
It is working as expected, those test cases should be fixed, it is reported as a separate issue 0040057.
(0109441)
caristu   
2019-02-01 15:11   
Code reviewed + tested OK.
(0110756)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110757)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test