0036419: no request processed while killing abandoned sessions

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036419

Openbravo ERP

A. Platform

public

2017-07-05 14:05

2017-09-21 16:49

Reporter

alostale

Assigned To

alostale

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR17Q4

Merge Request Status

Review Assigned To

AugustoMauch

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036419: no request processed while killing abandoned sessions

Description

In a professional instance with limited concurrent users, having abandoned sessions it is possible to reach a situation where no request is processed.

This can occur if there is a DB lock in the ad_session rows that detected as abandoned. The thread trying to kill them, waits this lock to be released in a synchronized method so no other thread can be processed as they are also waiting this lock to be released.

Steps To Reproduce

Couldn't reproduce following standard flows, but it is possible to emulate it:

1. Activate instance with a license limited to 1 concurrent user
2. Create an abandoned session in DB:

insert into ad_session (
    ad_session_id , ad_client_id , ad_org_id , isactive ,
    created , createdby , updated , updatedby ,
    processed , session_active , last_session_ping, login_status ,
    username)
values
  (get_uuid(), '0', '0', 'Y',
   now(), '0', now(), '0',
   'N', 'Y', now() - 1, 'S',
   'test' ) ;

3. Create a lock for that session in DB:

begin; select * from ad_session order by created desc limit 1 for update;

4. Try to open login window in several tabs

  -> None of them is completed

Proposed Solution

Additional Information

Tags

Performance

Relationships

related to	defect	0036425		closed	alostale	mobile sessions can be kicked out in cluster
blocks	feature request	0036477		closed	alostale	autorefresh professional subscription license