Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036412Openbravo ERP04. Warehouse managementpublic2017-07-05 12:242017-09-21 16:49
ngarcia 
collazoandy4 
urgentmajoralways
closedfixed 
5
 
3.0PR17Q4 
aferraz
Core
No
0036412: Orphan Line is removed from Return To Vendor if Pick/Edit Lines is launched then
Orphan Line is removed from Return To Vendor if Pick/Edit Lines is launched then
As group admin role:
   Set RM Allow Orphan Line preference to Y
   Log out and log in
   Create a Return To Vendor Header
   Insert Orphan Line
   Pick/Edit Lines and click in Done without making any change
   Check the orphan line has been removed
No tags attached.
related to defect 0036448 closed collazoandy4 The Line number in RTV is increase in 10 
Issue History
2017-07-05 12:24ngarciaNew Issue
2017-07-05 12:24ngarciaAssigned To => Triage Finance
2017-07-05 12:24ngarciaModules => Core
2017-07-05 12:24ngarciaResolution time => 1501020000
2017-07-05 12:24ngarciaTriggers an Emergency Pack => No
2017-07-05 12:24ngarciaIssue Monitored: networkb
2017-07-05 12:27PracticsIssue Monitored: Practics
2017-07-05 13:10aferrazAssigned ToTriage Finance => collazoandy4
2017-07-07 02:13collazoandy4Statusnew => scheduled
2017-07-07 16:15collazoandy4Note Added: 0097959
2017-07-10 16:21aferrazRelationship addedrelated to 0036448
2017-07-10 16:22hgbotCheckin
2017-07-10 16:22hgbotNote Added: 0097982
2017-07-10 16:22hgbotStatusscheduled => resolved
2017-07-10 16:22hgbotResolutionopen => fixed
2017-07-10 16:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d7c03ca57c9732540f85dc87b213e60055ea6dc1 [^]
2017-07-10 16:22hgbotCheckin
2017-07-10 16:22hgbotNote Added: 0097983
2017-07-10 16:22aferrazReview Assigned To => aferraz
2017-07-10 16:22aferrazNote Added: 0097984
2017-07-10 16:22aferrazStatusresolved => closed
2017-07-10 16:22aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099261
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099262

Notes
(0097959)
collazoandy4   
2017-07-07 16:15   
Test Plan
  As group admin role:
   Go to Preference window and create a new record and Property Set RM Allow Orphan Line to Y
   Log out and log in
   Go to Return to Vendor and create a new record:
     Insert Orphan Line:
       Product: Agua sin Gas 1L
       Returned: 3
       Unit Price: 2
       Returned reason: Damaged on arrival
     Pick/Edit Lines and click in Done without making any change
     Check the orphan line has not been remove and without any change
     Pick/Edit Lines select any record set returnedqty = 4 and click in Done
     Check the Lines tab now contains two lines, the orphan line and the selected line
     Pick/Edit Lines deselect the orphan line and clic in Done
     Check the orphan line was removed from the Lines tab
     Pick/Edit Lines deselect the selected line and clic in Done
     Check the Lines tab is now empty
     Pick/Edit Lines select any record set returnedqty = 5 and clic in Done
     Check the selected line was added to the Lines tab
     Book the RTV and check the process ends sucessfull
     Reactivate the RTV
     Insert another Orphan Line:
       Product: Agua sin Gas 1L
       Returned: 3
       Unit Price: 2
       Returned reason: Damaged on arrival
     Book the RTV and check the process ends sucessfull
     Reactivate the RTV
     Pick/Edit Lines and deselect the selected line and clic in Done
     Check the orphan line is the only record in Lines tab
     Book the RTV and check the process ends sucessfull
(0097982)
hgbot   
2017-07-10 16:22   
Repository: erp/devel/pi
Changeset: d7c03ca57c9732540f85dc87b213e60055ea6dc1
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Jul 07 10:37:42 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d7c03ca57c9732540f85dc87b213e60055ea6dc1 [^]

Fixes issue 36412: Orphan Line removed from Return To Vendor

The orphan lines was removed when a Pick/Edit is open because if the selected Lines
from the Pick/Edit is 0 all lines are removed and the methods ends.

A refactor was made to take into account the selected orphan lines in the
selected lines process, also a null save validation was done with the goods shipment
line because an orphan lines doesn't have a goods shipment line.

---
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
---
(0097983)
hgbot   
2017-07-10 16:22   
Repository: erp/devel/pi
Changeset: 2b129041a63e03fdeb2f5a09ad578374216b4685
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jul 10 16:16:48 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2b129041a63e03fdeb2f5a09ad578374216b4685 [^]

Related to issue 36412: Code review improvements

---
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
---
(0097984)
aferraz   
2017-07-10 16:22   
Code review + Testing OK
(0099261)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099262)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test