Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036406Openbravo ERPB. User interfacepublic2017-07-04 18:272018-01-03 12:39
Reporterngarcia 
Assigned Toinigosanchez 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036406: Summary functions do not work in tabs based on tables with Datasource Data Origin
DescriptionSummary functions do not work in tabs based on tables with Datasource Data Origin
Steps To ReproduceAs system admin role:
   Install Not Posted Transactions module

As group admin role:
   Open Report Not Posted window
   Select a column and Add Count summary function to it
   Check the value is not shown
Proposed SolutionPossible solutions:

1. In getAllowSummaryFunctions of OBViewGridComponent class, return false if the table is based on a Datasource

2. Add a Grid Configuration to the 'Not Posted documents - Report Not Posted' tab setting the Allow Summary Functions to 'N'
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034324 closed inigosanchez Summary function does not function for WIndow's created using hql tables. 
related to design defect 0037381 new Triage Platform Base Add ability to use Summary Functions in tabs based on Datasources. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-04 18:27ngarciaNew Issue
2017-07-04 18:27ngarciaAssigned To => platform
2017-07-04 18:27ngarciaModules => Core
2017-07-04 18:27ngarciaTriggers an Emergency Pack => No
2017-07-04 18:29ngarciaProposed Solution updated
2017-07-04 18:29ngarciaIssue Monitored: networkb
2017-07-14 11:03alostaleStatusnew => acknowledged
2017-07-17 08:57caristuRelationship addedrelated to 0034324
2017-11-21 17:49inigosanchezStatusacknowledged => scheduled
2017-11-21 17:49inigosanchezAssigned Toplatform => inigosanchez
2017-11-22 10:16hgbotCheckin
2017-11-22 10:16hgbotNote Added: 0100660
2017-11-22 10:16hgbotStatusscheduled => resolved
2017-11-22 10:16hgbotResolutionopen => fixed
2017-11-22 10:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/747998ff0bb63b62639764d196f28311ab1ea77b [^]
2017-11-22 10:23inigosanchezNote Added: 0100661
2017-11-22 10:23inigosanchezReview Assigned To => caristu
2017-11-24 10:20inigosanchezRelationship addedrelated to 0037381
2017-11-24 14:04caristuNote Added: 0100703
2017-11-24 14:04caristuStatusresolved => new
2017-11-24 14:04caristuResolutionfixed => open
2017-11-24 14:10hgbotCheckin
2017-11-24 14:10hgbotNote Added: 0100704
2017-11-24 14:10inigosanchezStatusnew => scheduled
2017-11-24 14:10inigosanchezStatusscheduled => resolved
2017-11-24 14:10inigosanchezResolutionopen => fixed
2017-11-24 14:29caristuNote Added: 0100705
2017-11-24 14:29caristuStatusresolved => closed
2017-11-24 14:29caristuFixed in Version => 3.0PR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101450
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101457

Notes
(0100660)
hgbot   
2017-11-22 10:16   
Repository: erp/devel/pi
Changeset: 747998ff0bb63b62639764d196f28311ab1ea77b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 21 17:58:52 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/747998ff0bb63b62639764d196f28311ab1ea77b [^]

Fixed issue 36406: Summary functions do not work in tabs based on Datasources.

The summary functions didn't work in tabs based on Datasources because this
functionality was not developed. The reported datasource hadn't the code to
managed summary functions properly.

To avoid this problem, it has been resolved by blocking the use of the summary
functions in the tabs based on Datasources.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewGridComponent.java
---
(0100661)
inigosanchez   
2017-11-22 10:23   
Added limitations of Summary Functions properly in the Openbravo wiki[1].


[1]. http://wiki.openbravo.com/wiki/User_Interface_Introduction#Grid_Summaries [^]
(0100703)
caristu   
2017-11-24 14:04   
Reopened: disabling summary functions for all non datasource based tables:

!ApplicationConstants.DATASOURCEBASEDTABLE.equals(table.getDataOriginType());
(0100704)
hgbot   
2017-11-24 14:10   
Repository: erp/devel/pi
Changeset: f4da2f78f98da5277314c8dcba9125c45cfbaf59
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Nov 24 14:09:22 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4da2f78f98da5277314c8dcba9125c45cfbaf59 [^]

Related with issue 36406: Fixed error in the condition

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewGridComponent.java
---
(0100705)
caristu   
2017-11-24 14:29   
Code reviewed + tested OK.
(0101450)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101457)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test