0036385: Connection leak in ServerStateBackground is there are no servers to ping

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036385

Retail Modules

StoreServer

public

2017-07-03 11:00

2017-07-31 09:24

Reporter

AugustoMauch

Assigned To

mtaal

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR17Q3

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

AugustoMauch

OBNetwork customer

Support ticket

Regression level

Packaging and release

Regression date

2017-06-08

Regression introduced in release

RR17Q2

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5b9d05b616c97890bac563e72fcc415931f75f89 [^]

Triggers an Emergency Pack

Summary

0036385: Connection leak in ServerStateBackground is there are no servers to ping

Description

This changeset [1] fixed a connection leak in ServerStateBackground, but only if there was at least one store server to be pinged from the central server. If there are none, connections are still being leaked:

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7edfb4a12cd4eec4d8a87c3a394b4c6ebd92ceae [^]

Steps To Reproduce

In a central server with no store server registered:
- Start tomcat
- Wait until the ServerStateBackground process is invoked. Each time it is invoked a connection will be leaked:

jul 03, 2017 10:56:07 AM org.apache.tomcat.jdbc.pool.ConnectionPool suspect
ADVERTENCIA: Connection has been marked suspect, possibly abandoned PooledConnection[org.postgresql.jdbc.PgConnection@5667c6bd][33259 ms.]:java.lang.Exception
    at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:1096)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:799)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:648)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:200)
    at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:128)
    at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnectionFromDS(JdbcExternalConnectionPool.java:130)
    at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnection(JdbcExternalConnectionPool.java:110)
    at org.openbravo.dal.core.SessionHandler.getNewConnection(SessionHandler.java:300)
    at org.openbravo.dal.core.SessionHandler.createSession(SessionHandler.java:235)
    at org.openbravo.dal.core.SessionHandler.begin(SessionHandler.java:561)
    at org.openbravo.dal.core.SessionHandler.getSession(SessionHandler.java:183)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:534)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:500)
    at org.openbravo.dal.service.OBDal.get(OBDal.java:353)
    at org.openbravo.mobile.core.authenticate.MobileAuthenticationKeyUtils.getKey(MobileAuthenticationKeyUtils.java:133)
    at org.openbravo.mobile.core.authenticate.MobileAuthenticationKeyUtils.encrypt(MobileAuthenticationKeyUtils.java:88)
    at org.openbravo.mobile.core.authenticate.MobileAuthenticationKeyUtils.getEncryptedAuthenticationToken(MobileAuthenticationKeyUtils.java:77)
    at org.openbravo.mobile.core.servercontroller.MobileServerUtils.getAuthenticationQueryParams(MobileServerUtils.java:198)
    at org.openbravo.mobile.core.servercontroller.ServerStateBackground$PingRunnable.run(ServerStateBackground.java:414)

Proposed Solution

Additional Information