Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036380Retail ModulesCash uppublic2017-06-30 14:132017-07-14 11:06
Reporteraaroncalero 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036380: Enyo errors navigating to the cashup after doing several cash management movements
DescriptionAfter creating several cash management movements with the same type, amount and payment method (i.e. 2 different Cash drops of 100€) if the user navigates to the Cash Up window, several enyo errors will be generated on the browser console.
Steps To ReproduceLogin in web pos
Go to the Cash Management window.
Select Cash Deposit, write a 100, click on Enter and finally select Backoffice transfer to VBS.
Repeat the step to deposit another 100€
Click on Done to synchronize the cash movements and click Ok on the confirmation popup.
Click on the Menu > Cash Up to navigate to the Cash Up window.
Verify on the browser console that several enyo errors are shown:

enyo] Duplicated DOM id 'terminal_containerWindow_cashUp_cashupMultiColumn_leftPanel_postPrintClose_depositsTable_deposits_cashMgmtDepositOBPOSpayment.cash20_control3' Object {_componentNameMap: Object, $: Object, owner: Object, allowHtml: true, tag: "span"…} will overwrite to Object {_componentNameMap: Object, $: Object, owner: Object, allowHtml: true, tag: "span"…}
...
Proposed SolutionWhen the cashup window is opened, the generated cash management movements are retrieved and stored on the cashUpReport object to build the final cashup report.
The "searchKey" of each cash management is generated from the type of the movement, the searchKey of the payment method and the amount, which can generate duplicates.
This code[1] should be changed to generate unique search keys for each cash management movement.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/00aead81c650/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js#l203 [^]
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-30 14:13aaroncaleroNew Issue
2017-06-30 14:13aaroncaleroAssigned To => Retail
2017-06-30 14:13aaroncaleroOBNetwork customer => Yes
2017-06-30 14:13aaroncaleroResolution time => 1499983200
2017-06-30 14:13aaroncaleroTriggers an Emergency Pack => No
2017-06-30 14:19aaroncaleroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15448#r15448
2017-07-03 14:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-07-03 14:39ranjith_qualiantech_comStatusnew => scheduled
2017-07-04 08:22prakashmurugesan88Assigned Toranjith_qualiantech_com => prakashmurugesan88
2017-07-11 07:28hgbotCheckin
2017-07-11 07:28hgbotNote Added: 0097995
2017-07-11 07:28hgbotStatusscheduled => resolved
2017-07-11 07:28hgbotResolutionopen => fixed
2017-07-11 07:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3c6535387113021e6483ee3bd61757ab19e22e7 [^]
2017-07-11 07:29hgbotCheckin
2017-07-11 07:29hgbotNote Added: 0097996
2017-07-14 11:06migueldejuanaReview Assigned To => migueldejuana
2017-07-14 11:06migueldejuanaNote Added: 0098077
2017-07-14 11:06migueldejuanaStatusresolved => closed

Notes
(0097995)
hgbot   
2017-07-11 07:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d3c6535387113021e6483ee3bd61757ab19e22e7
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Jul 11 10:57:42 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3c6535387113021e6483ee3bd61757ab19e22e7 [^]

Fixed Issue 36380: While opening cash up, added unique index for each "searchKey" of cash mgmt to avoid duplicates

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0097996)
hgbot   
2017-07-11 07:29   
Repository: tools/automation/pi-mobile
Changeset: 2191a8aae06127dd77c4e1883ac6f882e33e1ab1
Author: Prakash M <prakash <at> qualiantech.com>
Date: Tue Jul 11 10:57:23 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2191a8aae06127dd77c4e1883ac6f882e33e1ab1 [^]

Verifies issue 36380: Added automated test

I36380_CashupWithMultipleSimilarCashManagementMvmt

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36380_CashupWithMultipleSimilarCashManagementMvmt.java
---
(0098077)
migueldejuana   
2017-07-14 11:06   
Tested and reviewed