Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036377Openbravo ERP04. Warehouse managementpublic2017-06-30 09:132017-09-21 16:49
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036377: Cannot launch Valued Stock Report if the role does not have access to M_COSTING_RULE and M_TRANSACTION tables
DescriptionCannot launch Valued Stock Report if the role does not have access to M_COSTING_RULE and M_TRANSACTION tables
Steps To ReproduceAs group admin role:
   Create a new role
   Set it as Manual
   Add all organizations to it
   Add Valued Stock Report in Report and Process Access tab
   Assign it to Openbravo user

Log in with that role
   Try to launch the Valued Stock Report and check the following error is shown:
      Entity CostingRule is not readable by the user 100

As group admin role:
   Go to Role Access window and include M_COSTING_RULE table to the previously created role (Exclude = 'N')

Log in with that role again:
   Try to launch the Valued Stock Report and check the following error is shown:
      Entity MaterialMgmtMaterialTransaction is not readable by the user 100

As group admin role:
   Go to Role Access window and include M_TRANSACTION table to the previously created role (Exclude = 'N')

Log in with that role again:
   Check you could launch the Valued Stock Report
    
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-30 09:13ngarciaNew Issue
2017-06-30 09:13ngarciaAssigned To => Triage Finance
2017-06-30 09:13ngarciaModules => Core
2017-06-30 09:13ngarciaResolution time => 1500588000
2017-06-30 09:13ngarciaTriggers an Emergency Pack => No
2017-06-30 13:21vmromanosStatusnew => scheduled
2017-06-30 13:21vmromanosAssigned ToTriage Finance => collazoandy4
2017-06-30 19:09collazoandy4Note Added: 0097786
2017-07-04 10:09hgbotCheckin
2017-07-04 10:09hgbotNote Added: 0097825
2017-07-04 10:09hgbotStatusscheduled => resolved
2017-07-04 10:09hgbotResolutionopen => fixed
2017-07-04 10:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d951787ffbd6a62c83a504a08fd082b5aa52713a [^]
2017-07-04 10:09hgbotCheckin
2017-07-04 10:09hgbotNote Added: 0097826
2017-07-04 10:10aferrazReview Assigned To => aferraz
2017-07-04 10:10aferrazNote Added: 0097827
2017-07-04 10:10aferrazStatusresolved => closed
2017-07-04 10:10aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099229
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099230

Notes
(0097786)
collazoandy4   
2017-06-30 19:09   
Test Plan
  As group admin role:
   Go to Role window and create a new record:
     Name: Issue36377
     Manual: Y
     In Org Access tab add all organizations to it
     In Report and Process Access tab create a new record:
       Process: Valued Stock Report
     In User Assignment tab create a new record:
       User/Contact: Openbravo
   Log out and Log in with role Issue36377
   Try to launch the Valued Stock Report and check no error is shown
(0097825)
hgbot   
2017-07-04 10:09   
Repository: erp/devel/pi
Changeset: d951787ffbd6a62c83a504a08fd082b5aa52713a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Jun 30 17:07:40 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d951787ffbd6a62c83a504a08fd082b5aa52713a [^]

Fixes issue 36377: Cannot launch Valued Stock Report

Cannot launch Valued Stock Report if the role does not have
access to M_COSTING_RULE and M_TRANSACTION tables.

The Report access to M_COSTING_RULE and M_TRANSACTION tables and if the user role
does not have access an exception is raise.

Now the context set the admin mode when the report try to access the tables and
restoring the previous mode when finish the access

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0097826)
hgbot   
2017-07-04 10:09   
Repository: erp/devel/pi
Changeset: d960f963e0ff08d38f4d2813e7e79b1af7561758
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Jul 04 10:08:49 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d960f963e0ff08d38f4d2813e7e79b1af7561758 [^]

Related to issue 36377: Code review improvements

Set admin mode at the beginning of getLEsCostingAlgortithm() and hasTrxWithNoCost() methods.

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0097827)
aferraz   
2017-07-04 10:10   
Code review + Testing OK
(0099229)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099230)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test