Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036370Retail ModulesWeb POSpublic2017-06-29 06:072017-11-03 11:19
Reporteregoitz 
Assigned Toprakashmurugesan88 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036370: The queries for generic products should not be executed during the incremental/master refresh if they are not used
DescriptionIf the generic products are not used the queries to get generic products during the incremental/master refresh should not be executed in order to make the process faster.

Steps To Reproducen/a
Proposed SolutionDefine a preference to prevent the execution of that queries.
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-29 06:07egoitzNew Issue
2017-06-29 06:07egoitzAssigned To => Retail
2017-06-29 06:07egoitzResolution time => 1500069600
2017-06-29 06:07egoitzTriggers an Emergency Pack => No
2017-07-03 09:52prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2017-07-04 08:22prakashmurugesan88Statusnew => scheduled
2017-07-06 10:44hgbotCheckin
2017-07-06 10:44hgbotNote Added: 0097903
2017-07-06 10:44hgbotStatusscheduled => resolved
2017-07-06 10:44hgbotResolutionopen => fixed
2017-07-06 10:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181ea055994f8aeb0a424baf8e76402a3c528c5b [^]
2017-07-06 10:45hgbotCheckin
2017-07-06 10:45hgbotNote Added: 0097904
2017-07-14 11:06migueldejuanaReview Assigned To => migueldejuana
2017-07-14 11:06migueldejuanaNote Added: 0098076
2017-07-14 11:06migueldejuanaStatusresolved => closed
2017-07-14 11:19migueldejuanaStatusclosed => new
2017-07-14 11:19migueldejuanaResolutionfixed => open
2017-07-14 11:19migueldejuanaStatusnew => scheduled
2017-07-14 11:19migueldejuanaStatusscheduled => resolved
2017-07-14 11:19migueldejuanaResolutionopen => fixed
2017-07-17 09:54migueldejuanaNote Added: 0098096
2017-07-17 09:54migueldejuanaStatusresolved => new
2017-07-17 09:54migueldejuanaResolutionfixed => open
2017-07-17 12:48hgbotCheckin
2017-07-17 12:48hgbotNote Added: 0098097
2017-07-17 12:48hgbotStatusnew => resolved
2017-07-17 12:48hgbotResolutionopen => fixed
2017-07-17 12:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181ea055994f8aeb0a424baf8e76402a3c528c5b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/619a94daceffcbc222f5dc8741cd735221750cdb [^]
2017-07-17 12:49hgbotCheckin
2017-07-17 12:49hgbotNote Added: 0098098
2017-07-17 13:48migueldejuanaNote Added: 0098103
2017-07-17 13:48migueldejuanaStatusresolved => closed
2017-11-03 11:19malsasuaTag Attached: Performance

Notes
(0097903)
hgbot   
2017-07-06 10:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 181ea055994f8aeb0a424baf8e76402a3c528c5b
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu Jul 06 12:31:28 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181ea055994f8aeb0a424baf8e76402a3c528c5b [^]

Fixed Issue 36370: Added preference to show or hide generic products

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/Product.java
---
(0097904)
hgbot   
2017-07-06 10:45   
Repository: tools/automation/pi-mobile
Changeset: d89887781251678ebbb1bec17206d7aebd78d034
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu Jul 06 12:31:19 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d89887781251678ebbb1bec17206d7aebd78d034 [^]

Verifies issue 36370: Added automated test

I36370_VerifyShowGenericProductsPerfShowProd
I36370_VerifyShowGenericProductsPrefHideProd

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I36370_VerifyShowGenericProductsPerfShowProd.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I36370_VerifyShowGenericProductsPrefHideProd.java
---
(0098076)
migueldejuana   
2017-07-14 11:06   
Tested and reviewed
(0098096)
migueldejuana   
2017-07-17 09:54   
Issue just asks to do not execute the generic products query if it is not needed.

Created preference "Web POS Show Generic Products" is to show hide products. We just want to execute or not execute the query.

In the test we do " MobileCoreAPI.localStorageClear();" we shouldn't do that in tests.
(0098097)
hgbot   
2017-07-17 12:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 619a94daceffcbc222f5dc8741cd735221750cdb
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Jul 17 16:06:40 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/619a94daceffcbc222f5dc8741cd735221750cdb [^]

Fixed Issue 36370: Changed preference name to execute generic products query

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/Product.java
---
(0098098)
hgbot   
2017-07-17 12:49   
Repository: tools/automation/pi-mobile
Changeset: 9b1e343509903a941419a013d9c685d81d0a0dcc
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Jul 17 16:03:35 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9b1e343509903a941419a013d9c685d81d0a0dcc [^]

Related to issue 36370: Removed automated test as the scenario cannot be tested

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I36370_VerifyShowGenericProductsPerfShowProd.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I36370_VerifyShowGenericProductsPrefHideProd.java
---
(0098103)
migueldejuana   
2017-07-17 13:48   
Tested and reviewed