Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036368 | Openbravo ERP | 07. Sales management | public | 2017-06-28 12:55 | 2017-06-29 13:03 |
|
| Reporter | eduardo_Argal | |
| Assigned To | Triage Omni OMS | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR17Q3 | |
| Merge Request Status | |
| Review Assigned To | vmromanos |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036368: Performance problem in C_Invoice_Post |
| Description | C_Incoice_Post procedure has poor performance requiring more than a second to process an invoice |
| Steps To Reproduce | Using a big database (in this case the big machine used to improve performance) the processing of an invoice takes more than a second. |
| Proposed Solution | The problem is when using get_calendarowner function inside a query. Find attached the pacth with the proposed solution. This turns performance to 0.29 sec |
| Additional Information | |
| Tags | Performance |
| Relationships | |
| Attached Files |  performance_C_INVOICE_POST.diff (1,927) 2017-06-28 12:55
https://issues.openbravo.com/file_download.php?file_id=10877&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-06-28 12:55 | eduardo_Argal | New Issue | |
| 2017-06-28 12:55 | eduardo_Argal | Assigned To | => Triage Finance |
| 2017-06-28 12:55 | eduardo_Argal | File Added: performance_C_INVOICE_POST.diff | |
| 2017-06-28 12:55 | eduardo_Argal | OBNetwork customer | => Yes |
| 2017-06-28 12:55 | eduardo_Argal | Modules | => Core |
| 2017-06-28 12:55 | eduardo_Argal | Resolution time | => 1499810400 |
| 2017-06-28 12:55 | eduardo_Argal | Triggers an Emergency Pack | => No |
| 2017-06-28 14:49 | vmromanos | Status | new => scheduled |
| 2017-06-28 17:29 | vmromanos | Note Added: 0097741 | |
| 2017-06-29 07:37 | hgbot | Checkin | |
| 2017-06-29 07:37 | hgbot | Note Added: 0097748 | |
| 2017-06-29 07:37 | hgbot | Status | scheduled => resolved |
| 2017-06-29 07:37 | hgbot | Resolution | open => fixed |
| 2017-06-29 07:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1a7aad006212c5ca48944ddb74f47e184b29b8bb [^] |
| 2017-06-29 07:37 | vmromanos | Review Assigned To | => vmromanos |
| 2017-06-29 07:37 | vmromanos | Note Added: 0097749 | |
| 2017-06-29 07:37 | vmromanos | Status | resolved => closed |
| 2017-06-29 07:37 | vmromanos | Fixed in Version | => 3.0PR17Q3 |
| 2017-06-29 09:42 | Sandrahuguet | Tag Attached: Performance | |
| 2017-06-29 13:03 | hudsonbot | Checkin | |
| 2017-06-29 13:03 | hudsonbot | Note Added: 0097763 | |
|
Notes |
|
|
|
Test plan I:
As Openbravo admin
Go to purchase invoice window
Create a new record for organization España Norte.
Select any business partner and enter any line.
Complete the invoice. Verify the process is completed successfully.
Reactivate the invoice. Verify the process is completed successfully.
Complete the invoice again and void it. Verify the process is completed successfully.
Test plan II:
As Openbravo admin
Go to purchase invoice window
Create a new record for organization España.
Select any business partner and enter any line.
Complete the invoice. Verify the process is completed successfully.
Reactivate the invoice. Verify the process is completed successfully.
Complete the invoice again and void it. Verify the process is completed successfully.
Test plan III:
As Openbravo admin
Go to sales invoice window
Create a new record for organization España Norte.
Select any business partner and enter any line.
Complete the invoice. Verify the process is completed successfully.
Reactivate the invoice. Verify the process is completed successfully.
Complete the invoice again and void it. Verify the process is completed successfully.
Test plan IV:
As Openbravo admin
Go to sales invoice window
Create a new record for organization España.
Select any business partner and enter any line.
Complete the invoice. Verify the process is completed successfully.
Reactivate the invoice. Verify the process is completed successfully.
Complete the invoice again and void it. Verify the process is completed successfully. |
|
|
|
(0097748)
|
|
hgbot
|
|
2017-06-29 07:37
|
|
Repository: erp/devel/pi
Changeset: 1a7aad006212c5ca48944ddb74f47e184b29b8bb
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jun 28 14:57:06 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1a7aad006212c5ca48944ddb74f47e184b29b8bb [^]
Fixed issue 36368: Performance problem in C_Invoice_Post
Changeset pushed on behalf of EAR
AD_ORG_GETCALENDAROWNER function was creating performance problems in queries related to high volume tables, as it was evaluated per each record.
Solution extracts the function call in a separate query that is executed just one time.
The result is passed to the where clause using a variable thus improving performance.
---
M src-db/database/model/functions/C_INVOICE_POST.xml
---
|
|
|
|
|
|
|
|
|
|