Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036356Openbravo ERP07. Sales managementpublic2017-06-27 10:172017-09-21 16:49
ReporterVictorVillar 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket47400
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036356: In Sales quotation window, it does not populate well the basic discount after changing the Business Partner.
DescriptionIn Sales quotation window, it does not populate well the basic discount after changing the Business Partner.
Steps To ReproduceGo to Sales Quotation
Create a new register for Alimentos y Supermercados which has a 10% basic discount defined for them
Save the register and check in the Basic Discount tab that the Discount 10% appears
Change the Business Partner and select Restaurantes luna llena which has a 5% basic discount defined for them.
Check that the basic discount tab still is showing Discount 10%
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-27 10:17VictorVillarNew Issue
2017-06-27 10:17VictorVillarAssigned To => Triage Finance
2017-06-27 10:17VictorVillarOBNetwork customer => Yes
2017-06-27 10:17VictorVillarModules => Core
2017-06-27 10:17VictorVillarTriggers an Emergency Pack => No
2017-06-27 10:32ngarciaSupport ticket => 47400
2017-06-27 10:32ngarciaResolution time => 1500328800
2017-06-27 10:32ngarciaIssue Monitored: ngarcia
2017-06-27 11:10vmromanosStatusnew => scheduled
2017-06-27 11:10vmromanosAssigned ToTriage Finance => collazoandy4
2017-06-27 23:11collazoandy4Note Added: 0097726
2017-07-04 16:07collazoandy4Note Edited: 0097726bug_revision_view_page.php?bugnote_id=0097726#r15459
2017-07-10 12:27hgbotCheckin
2017-07-10 12:27hgbotNote Added: 0097969
2017-07-10 12:27hgbotStatusscheduled => resolved
2017-07-10 12:27hgbotResolutionopen => fixed
2017-07-10 12:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d9d3b766dc79ab2bec04a0f0cfbfbfd9f83f450f [^]
2017-07-10 12:28hgbotCheckin
2017-07-10 12:28hgbotNote Added: 0097970
2017-07-10 12:30aferrazNote Added: 0097971
2017-07-10 12:30aferrazReview Assigned To => aferraz
2017-07-10 12:30aferrazNote Added: 0097972
2017-07-10 12:30aferrazStatusresolved => closed
2017-07-10 12:30aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099258
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099259

Notes
(0097726)
collazoandy4   
2017-06-27 23:11   
(edited on: 2017-07-04 16:07)
Test Plan
  As F&B International Group admin role
    Go to Sales Quotation window and create a new record for Alimentos y Supermercados business partner
      Save the record and check in Basic Discount tab that the Discount 10% appears
      Change the Business Partner and select Restaurantes luna llena
      Save the record and check in Basic Discount tab that the Discount 5% replace the 10% Discount line

   Repeat the test case above for Sales Order

   Test Case 2
     Go to Business Partner window and select Alimentos y Supermercados, S.A record and create a new record in Basic discount tab:
         Basic discount: Descuento 5%
       Select Restaurantes luna llena record and create a new record in Basic discount tab:
         Basic discount: Descuento 10%
     Go to Sales Invoice window and create a new record for Alimentos y Supermercados business partner
      Save the record and check in Basic Discount tab that the Discount 5% appears
      Change the Business Partner and select Restaurantes luna llena
      Save the record and check in Basic Discount tab that the Discount 10% replace the 5% Discount line
(0097969)
hgbot   
2017-07-10 12:27   
Repository: erp/devel/pi
Changeset: d9d3b766dc79ab2bec04a0f0cfbfbfd9f83f450f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jul 10 11:25:45 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d9d3b766dc79ab2bec04a0f0cfbfbfd9f83f450f [^]

Fixes issue 36356: Basic Discount not updated when changing Business Partner

Basic discount information was only taking into account when inserting a new order
or a new invoice.

Now the basic discount information are updated with the business partner
change in the order or invoice header.

---
M src-db/database/model/triggers/C_INVOICE_TRG2.xml
M src-db/database/model/triggers/C_ORDER_TRG2.xml
M src/org/openbravo/event/OrderEventHandler.java
A src/org/openbravo/event/InvoiceEventHandler.java
---
(0097970)
hgbot   
2017-07-10 12:28   
Repository: erp/devel/pi
Changeset: 278f3a69030df5b3dbe24bda5e0a3e964c7770bf
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jul 10 12:26:51 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/278f3a69030df5b3dbe24bda5e0a3e964c7770bf [^]

Related to issue 36356: Code review improvements

---
M src-db/database/model/triggers/C_INVOICE_TRG2.xml
M src-db/database/model/triggers/C_ORDER_TRG2.xml
M src/org/openbravo/event/InvoiceEventHandler.java
M src/org/openbravo/event/OrderEventHandler.java
---
(0097971)
aferraz   
2017-07-10 12:30   
Fix done by collazoandy4.
(0097972)
aferraz   
2017-07-10 12:30   
Code review + Testing OK
(0099258)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099259)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test