Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036345Openbravo ERP04. Warehouse managementpublic2017-06-26 17:352017-09-21 16:49
ngarcia 
markmm82 
urgentmajoralways
closedfixed 
5
 
3.0PR17Q4 
aferraz
Core
No
0036345: Wrong quantity in inventory lines if "," is used as decimal separator and "." as grouping separator
Wrong quantity in inventory lines if "," is used as decimal separator and "." as grouping separator
Change in Format.xml the decimal separator to "," and the grouping separator to "."
Compile

As group admin role:
   Create a physical inventory
   Add a line to it, selecting a stocked product
   Check the quantity from the m_storage_detail table is wrongly shown in Quantity count and Book Quantity fields

   Put the Quantity count field to 0 and try to process the inventory and check 'Insuffient stock' error is shown as the book quantity is higher than the available quantity
No tags attached.
related to defect 0036346 closed collazoandy4 'insuffient_stock' message has wrong text: it should be Insufficient instead of Insuffient 
has duplicate defect 0036590 closed markmm82 Callouts retrieve wrong quantity when Format.xml file is set with too many decimals 
Issue History
2017-06-26 17:35ngarciaNew Issue
2017-06-26 17:35ngarciaAssigned To => Triage Finance
2017-06-26 17:35ngarciaModules => Core
2017-06-26 17:35ngarciaResolution time => 1500242400
2017-06-26 17:35ngarciaTriggers an Emergency Pack => No
2017-06-26 17:37ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15418#r15418
2017-06-26 17:37ngarciaIssue Monitored: networkb
2017-06-26 17:41ngarciaRelationship addedrelated to 0036346
2017-06-26 18:59aferrazAssigned ToTriage Finance => markmm82
2017-06-26 22:16markmm82Statusnew => scheduled
2017-06-28 14:46markmm82Note Added: 0097739
2017-07-03 13:06hgbotCheckin
2017-07-03 13:06hgbotNote Added: 0097797
2017-07-03 13:06hgbotStatusscheduled => resolved
2017-07-03 13:06hgbotResolutionopen => fixed
2017-07-03 13:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f9c0d1127795281dbb10c350a83f329746673559 [^]
2017-07-03 13:06hgbotCheckin
2017-07-03 13:06hgbotNote Added: 0097798
2017-07-03 13:08aferrazReview Assigned To => aferraz
2017-07-03 13:08aferrazNote Added: 0097799
2017-07-03 13:08aferrazStatusresolved => closed
2017-07-03 13:08aferrazFixed in Version => 3.0PR17Q4
2017-08-22 14:48aferrazRelationship addedhas duplicate 0036590
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099226
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099227

Notes
(0097739)
markmm82   
2017-06-28 14:46   
Test Plan:
Change in Format.xml the decimal separator to "," and the grouping separator to "."
Compile

As group admin role:
   Create a physical inventory
   Add a line to it, selecting a stocked product
   Check the quantity from the m_storage_detail table is correctly shown in Quantity count and Book Quantity fields

   Put the Quantity count field to 0 and try to process the inventory and check process ends successfully
(0097797)
hgbot   
2017-07-03 13:06   
Repository: erp/devel/pi
Changeset: f9c0d1127795281dbb10c350a83f329746673559
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Jun 28 12:09:31 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/f9c0d1127795281dbb10c350a83f329746673559 [^]

Fixes issue 36345: Wrong quantity in inventory lines if "," is used as decimal
separator and "." as grouping separator

Fixed number format for Quantity count and Book Quantity fields of Physical
Inventory lines, taking it value from a BigDecimal variable.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Locator.java
---
(0097798)
hgbot   
2017-07-03 13:06   
Repository: erp/devel/pi
Changeset: 710409d5baad224e8a5a74fb3f3323f73d7f6f6a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jul 03 12:33:57 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/710409d5baad224e8a5a74fb3f3323f73d7f6f6a [^]

Related to issue 36345: Code review improvements

Send qtyOrder also as BigDecimal.
Do not check if qtyOrder or qty are empty as they will never be empty.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Locator.java
---
(0097799)
aferraz   
2017-07-03 13:08   
Code review + Testing OK
(0099226)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099227)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test