Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036320Openbravo ERP03. Procurement managementpublic2017-06-23 10:402017-06-28 10:30
ReporterAtulOpenbravo 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-01-31
Regression introduced in release3.0PR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c22eb99a6d5c155eec980d7ff3b08990ff849032 [^]
Triggers an Emergency PackNo
Summary0036320: Create Lines P&E window in Purchase Order does not respond to select other record after selecting any of the record
DescriptionWhen using Create Lines P&E window for selecting products, after selecting any of the record and entering Quantity, window does not respond to select other record. After closing the window and trying to re-open it does not open. Then after it is not possible to even add lines using form or grid view in Lines Tab.
Steps To Reproduce- Login as F&B International Group Admin
- Navigate to Purchase Order window and create record for any business partner.
- Using Create Lines button try to select records from P&E window.
- Enter Quantity.
- Try to select other record.
- Realize that any other record could not selected. Window does not respond.
- Close P&E window.
- Again click on Create Lines.
- Realize that window does not open.
- Try to create line record using Grid or Form view.
- Record cannot be created any more.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036102 closed inigosanchez Some mandatory fields can be left empty 
depends on backport 00363223.0PR17Q2.1 closed caristu Create Lines P&E window in Purchase Order does not respond to select other record after selecting any of the record 
caused by defect 0034824 closed NaroaIriarte Mandatory columns are not taken into account in pick & edit grids in which records can be added. 
related to defect 0040969 closed caristu Maximum call stack size exceeded can be thrown in P&E grids that allow record addition 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-23 10:40AtulOpenbravoNew Issue
2017-06-23 10:40AtulOpenbravoAssigned To => platform
2017-06-23 10:40AtulOpenbravoModules => Core
2017-06-23 10:40AtulOpenbravoTriggers an Emergency Pack => No
2017-06-23 10:41AtulOpenbravoSummaryCreate Lines P&E window does not respond to select other record after selecting any of the record => Create Lines P&E window in Purchase Order does not respond to select other record after selecting any of the record
2017-06-23 11:03aferrazRegression level => Production - QA Approved
2017-06-23 11:03aferrazRegression introduced in release => 3.0PR17Q2
2017-06-23 11:30caristuRegression date => 2017-01-31
2017-06-23 11:30caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c22eb99a6d5c155eec980d7ff3b08990ff849032 [^]
2017-06-23 11:30caristuRelationship addedcaused by 0034824
2017-06-23 11:31caristuStatusnew => scheduled
2017-06-23 15:07caristuRelationship addedrelated to 0036102
2017-06-23 15:07caristuAssigned Toplatform => caristu
2017-06-23 15:20hgbotCheckin
2017-06-23 15:20hgbotNote Added: 0097618
2017-06-23 15:20hgbotStatusscheduled => resolved
2017-06-23 15:20hgbotResolutionopen => fixed
2017-06-23 15:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e0985a0110819df3b701e2855ef2f7324e719f36 [^]
2017-06-23 15:20caristuReview Assigned To => inigosanchez
2017-06-26 09:57AugustoMauchReview Assigned Toinigosanchez => AugustoMauch
2017-06-26 10:25AugustoMauchNote Added: 0097641
2017-06-26 10:25AugustoMauchStatusresolved => closed
2017-06-26 10:25AugustoMauchFixed in Version => 3.0PR17Q3
2017-06-27 00:09hudsonbotCheckin
2017-06-27 00:09hudsonbotNote Added: 0097689
2017-06-28 10:30caristuNote Added: 0097735
2017-06-28 10:31caristuNote Edited: 0097735bug_revision_view_page.php?bugnote_id=0097735#r15436
2019-05-29 16:27caristuRelationship addedrelated to 0040969

Notes
(0097618)
hgbot   
2017-06-23 15:20   
Repository: erp/devel/pi
Changeset: e0985a0110819df3b701e2855ef2f7324e719f36
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jun 23 15:17:16 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e0985a0110819df3b701e2855ef2f7324e719f36 [^]

fixes bug 36320: Create Lines P&E grid gets freezed under some circumstances

  When moving to a record in a P&E leaving the current record without filling all the mandatory fields, the P&E got freezed due to an infinite loop.

  This was caused due to the changes introduced with the fix for the issue 0034824, which prevents to leave the current record if not all the mandatory fields are filled. Being in a P&E grid which does not allow inserts, that change causes an infinite loop in Smartclient. Thi is because the hideInlineEditor flow is never completed, which makes the cellEditMethod being called continuolsy.

  As the change for issue 0034824 was intended for P&E grids in which records can be added, this change ensures that the default action executed in hideInlineEditor are cancelled just for that kind of grids. This allows to keep the behavior fixed on issue 0034824 and fixes the problem for the rest of the P&E grids.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0097641)
AugustoMauch   
2017-06-26 10:25   
Code reviewed and verified in pi@e0985a011081
(0097689)
hudsonbot   
2017-06-27 00:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/aea25579db24 [^]
Maturity status: Test
(0097735)
caristu   
2017-06-28 10:30   
(edited on: 2017-06-28 10:31)
Added two new test cases into TestLink:

Test for issue 0036320: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10694 [^]

Test for issue 0034824: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10695 [^]