Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036316ModulesInitial data loadpublic2017-06-22 17:522017-06-26 18:49
Reportermarkmm82 
Assigned Tomarkmm82 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0036316: Fix IDL module to avoid warnings in Modules Automation.
DescriptionRight now there are some Eclipse warnings inside the src-test folder of IDL module that are causing warnings in Module Automation jobs.

Is needed to fix these warnings:
https://ci.openbravo.com/job/mod-simple/13954/consoleText [^]
Steps To Reproducehttps://ci.openbravo.com/view/modules/job/mod-functional-basic/ [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-22 17:52markmm82New Issue
2017-06-22 17:52markmm82Assigned To => Triage Finance
2017-06-22 17:54markmm82Description Updatedbug_revision_view_page.php?rev_id=15395#r15395
2017-06-22 17:54markmm82Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=15397#r15397
2017-06-22 17:55markmm82Assigned ToTriage Finance => markmm82
2017-06-26 09:20hgbotCheckin
2017-06-26 09:20hgbotNote Added: 0097632
2017-06-26 09:20hgbotStatusnew => resolved
2017-06-26 09:20hgbotResolutionopen => fixed
2017-06-26 09:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.idl/rev/ffbaeaf896a786a1b5fe9a613dd88bfbc4707922 [^]
2017-06-26 18:49aferrazReview Assigned To => aferraz
2017-06-26 18:49aferrazNote Added: 0097681
2017-06-26 18:49aferrazStatusresolved => closed

Notes
(0097632)
hgbot   
2017-06-26 09:20   
Repository: erp/pmods/org.openbravo.idl
Changeset: ffbaeaf896a786a1b5fe9a613dd88bfbc4707922
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Jun 23 14:14:52 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.idl/rev/ffbaeaf896a786a1b5fe9a613dd88bfbc4707922 [^]

Fixes issue 36316: Fix IDL tests to avoid warnings in Modules Automation jobs

There were some Eclipse warnings inside some java files in IDL module that were
causing warnings when running the Module Automation jobs.

To fix that:
- Affected classes are extending from OBBaseTest instead of BaseTest because it is
  deprecated.
- Updated copyright in all affected java class files.
- Removed the use of setUp() and tearDown() methods because execution is managed with
  existing methods of the OBBaseTest class.
- Removed the main() method because text execution is grnated by the @Test annotation.

Additionally, in TestCosting.java:
- Removed declaration of variable costing because it is unused after its assignment.

---
M src-test/org/openbravo/idl/test/TestAssets.java
M src-test/org/openbravo/idl/test/TestBusinessPartners.java
M src-test/org/openbravo/idl/test/TestCosting.java
M src-test/org/openbravo/idl/test/TestJournalEntries.java
M src-test/org/openbravo/idl/test/TestPriceLists.java
M src-test/org/openbravo/idl/test/TestProducts.java
M src-test/org/openbravo/idl/test/TestReferenceLists.java
M src-test/org/openbravo/idl/test/TestStocks.java
---
(0097681)
aferraz   
2017-06-26 18:49   
Code review OK