0036290: WebPOS login borrows 2 connections from DB pool

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036290

Retail Modules

Web POS

public

2017-06-20 09:39

2017-06-27 19:12

Reporter

alostale

Assigned To

alostale

Priority

high

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036290: WebPOS login borrows 2 connections from DB pool

Description

Whenever a login is done in WebPOS 2 connections are borrowed from DB pool.

Steps To Reproduce

1. Install DB Pool log module [1]
2. Configure Openbravo.properties to log threads borrowing more than one connection:
     db.pool.logger.enabled=true
     db.pool.logger.logMultipleConnectionsPerThread=true
3. Login WebPOS
  -> Check log:
595dbc4c 2017-06-20 09:36:40,353 [http-bio-8181-exec-4] WARN org.openbravo.util.db.DBPoolLogger - ***** Trying to get a connection in a thread that already has an active connection.
  org.openbravo.database.ConnectionProviderImpl.getNewConnection(ConnectionProviderImpl.java:260)
  org.openbravo.database.ConnectionProviderImpl.getConnection(ConnectionProviderImpl.java:236)
  org.openbravo.database.ConnectionProviderImpl.getPreparedStatement(ConnectionProviderImpl.java:369)
  org.openbravo.database.ConnectionProviderImpl.getPreparedStatement(ConnectionProviderImpl.java:361)
  org.openbravo.base.HttpBaseServlet.getPreparedStatement(HttpBaseServlet.java:386)
  org.openbravo.base.secureApp.SeguridadData.isUserRole(SeguridadData.java:232)
  org.openbravo.base.secureApp.LoginUtils.validUserRole(LoginUtils.java:116)
  org.openbravo.base.secureApp.LoginUtils.fillSessionArguments(LoginUtils.java:203)

595dbc4c 2017-06-20 09:36:40,354 [http-bio-8181-exec-4] WARN org.openbravo.util.db.DBPoolLogger - ** Listing other 1 active connections for this thread in addition to new PooledConnection[org.postgresql.jdbc.PgConnection@4c7ec0bb] **
595dbc4c 2017-06-20 09:36:40,354 [http-bio-8181-exec-4] WARN org.openbravo.util.db.DBPoolLogger - ===================== ACTIVE - Tue Jun 20 09:36:40 CEST 2017 - 1497944200327 - PooledConnection[org.postgresql.jdbc.PgConnection@65792d8b]
  Thread: http-bio-8181-exec-4
   org.openbravo.dal.core.SessionHandler.getNewConnection(SessionHandler.java:300)
   org.openbravo.dal.core.SessionHandler.createSession(SessionHandler.java:235)
   org.openbravo.dal.core.SessionHandler.begin(SessionHandler.java:561)
   org.openbravo.dal.core.SessionHandler.getSession(SessionHandler.java:183)
   org.openbravo.dal.service.OBDal.createCriteria(OBDal.java:501)
   org.openbravo.authentication.basic.DefaultAuthenticationManager.checkIfPasswordExpired(DefaultAuthenticationManager.java:229)
   org.openbravo.authentication.basic.DefaultAuthenticationManager.doAuthenticate(DefaultAuthenticationManager.java:163)
   org.openbravo.authentication.AuthenticationManager.authenticate(AuthenticationManager.java:172)

---
[1] http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/sso/ForgeModuleDetail/DB-Pool-Logging-Utilities [^] [^]

Proposed Solution

Additional Information