Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036285Openbravo ERP09. Financial managementpublic2017-06-19 18:432017-11-21 20:25
Reportershuehner 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036285: Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use
DescriptionThis issue covers commercial functional modules not part of erp (mod-functional-basic)

The processes below trigger runtime warning about 'Grid Legacy' and should be converted.

pi=# select m.javapackage, p.obuiapp_process_id, p.name, (select count(*) from obuiapp_parameter param where param.ad_reference_id = 'FF80818132D8F0F30132D9BC395D0038' and param.obuiapp_process_id = p.obuiapp_process_id) as grid_param from obuiapp_process p, ad_module m where p.ad_module_id = m.ad_module_id and p.isgridlegacy = 'Y' order by m.javapackage, p.name;

                       javapackage | obuiapp_process_id | name | grid_param
---------------------------------------------------------+----------------------------------+----------------------------------------------------------+------------
 org.openbravo.erputil.carrierintegration | CB4406EEECCF40808D8E3F54684366C4 | Send Pack to Carrier | 0
 org.openbravo.erputil.carrierintegration | 4002B7E5039741DD82CE576A3408FBF7 | Send Shipment to Carrier | 0
 org.openbravo.financialmgmt.accounting.report.notposted | EFAA65F3BF544918B1FF96B45879D0D4 | Post | 0
 org.openbravo.materialmgmt.catalog | 3AC9DF6930E84E68BFED5CB5A61B86E9 | Copy Categorization | 0
 org.openbravo.materialmgmt.catalog | 55337EA103544E80902027D3E9DAB34A | Manage Catalog | 0
 org.openbravo.materialmgmt.catalog | C59840DE310D4A23882E1E5D529E5190 | Unlist Products | 0
 org.openbravo.materialmgmt.freightmgmt | 3E856A258BAB43A88E674BB437A6A0C9 | Create Freight | 0
 org.openbravo.materialmgmt.freightmgmt | C082320ED82546AA8F2C4A68D54C37BC | Select Freight | 1
 org.openbravo.materialmgmt.freightmgmt | 5F2AE77E70F945BBA12423BAB4E7793D | Set Total Weight | 0
 org.openbravo.module.remittance | C88AB6CBA1694000AFF5706A31B08AE1 | Select Payments Pick and Edit | 1
 org.openbravo.warehouse.packing | C4043A216BD7429BB4D77469E7886BAA | Create Packing | 0
 org.openbravo.warehouse.packing | F3B77135F9D94C8FA1EFA270691265FB | Create Packing Header | 0
 org.openbravo.warehouse.packing | C1130D0D7BE54462BBEAD1F83405B295 | OBWPACK_ProcessPackShip | 0
 org.openbravo.warehouse.packing | E8C683DEA4854D4491105C7F7A8EC63E | Pick Goods Shipments | 1
 org.openbravo.warehouse.packing | E01E33615D864CB4A3A0F48598054CC1 | processPack | 0
Steps To Reproduce-
Proposed SolutionCheck migration guide [1]

[1] http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Migrating_old_Processes [^]
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0036281 acknowledged jarmendariz "Grid Legacy" warning should be moved from runtime to compile time 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 18:43shuehnerNew Issue
2017-06-19 18:43shuehnerAssigned To => Triage Finance
2017-06-19 18:43shuehnerModules => Core
2017-06-19 18:43shuehnerTriggers an Emergency Pack => No
2017-06-19 18:43shuehnerRelationship addedrelated to 0036281
2017-07-04 10:09alostaleProposed Solution updated
2017-07-05 16:12vmromanosStatusnew => scheduled
2017-07-05 16:12vmromanosAssigned ToTriage Finance => vmromanos
2017-07-05 16:21hgbotCheckin
2017-07-05 16:21hgbotNote Added: 0097876
2017-07-05 16:21hgbotStatusscheduled => resolved
2017-07-05 16:21hgbotResolutionopen => fixed
2017-07-05 16:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.erputil.carrierintegration/rev/c49544b517da1af2778718a08723bb8ab58d57f3 [^]
2017-07-05 16:22hgbotCheckin
2017-07-05 16:22hgbotNote Added: 0097877
2017-07-05 16:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.erputil.carrierintegration/rev/c49544b517da1af2778718a08723bb8ab58d57f3 [^] => http://code.openbravo.com/erp/mods/org.openbravo.financialmgmt.accounting.report.notposted/rev/f0f8a57bda51d8ffd94562a8cf2e1e884569441c [^]
2017-07-05 16:57hgbotCheckin
2017-07-05 16:57hgbotNote Added: 0097878
2017-07-05 16:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.financialmgmt.accounting.report.notposted/rev/f0f8a57bda51d8ffd94562a8cf2e1e884569441c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.materialmgmt.catalog/rev/04c7f381f7c60e9740b61ff4c760d8004abe7d90 [^]
2017-07-05 17:18hgbotCheckin
2017-07-05 17:18hgbotNote Added: 0097879
2017-07-05 17:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.materialmgmt.catalog/rev/04c7f381f7c60e9740b61ff4c760d8004abe7d90 [^] => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/2e4e9057fba23f45be836f5647d3fa78af62c2b5 [^]
2017-07-06 09:22hgbotCheckin
2017-07-06 09:22hgbotNote Added: 0097898
2017-07-06 09:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/2e4e9057fba23f45be836f5647d3fa78af62c2b5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.packing/rev/4d4229f8a68b143fe1a9b60d81f922f7af097902 [^]
2017-07-06 10:14hgbotCheckin
2017-07-06 10:14hgbotNote Added: 0097900
2017-07-06 10:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.packing/rev/4d4229f8a68b143fe1a9b60d81f922f7af097902 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.materialmgmt.freightmgmt/rev/7b6779e41acb0c987986d976ec9ca1d37e72c59d [^]
2017-07-06 10:16vmromanosNote Added: 0097901
2017-07-06 10:16vmromanosNote Added: 0097902
2017-07-06 10:17vmromanosReview Assigned To => aferraz
2017-07-10 16:49aferrazNote Added: 0097987
2017-07-10 16:49aferrazStatusresolved => closed
2017-11-21 20:25eugeniIssue Monitored: eugeni

Notes
(0097876)
hgbot   
2017-07-05 16:21   
Repository: erp/pmods/org.openbravo.erputil.carrierintegration
Changeset: c49544b517da1af2778718a08723bb8ab58d57f3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 05 16:14:46 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.erputil.carrierintegration/rev/c49544b517da1af2778718a08723bb8ab58d57f3 [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

Send Pack to Carrier and Send Shipment to Carrier: set "Compatibility with Legacy Grids" = N as they are manual UI Pattern processes

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
---
(0097877)
hgbot   
2017-07-05 16:22   
Repository: erp/mods/org.openbravo.financialmgmt.accounting.report.notposted
Changeset: f0f8a57bda51d8ffd94562a8cf2e1e884569441c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 05 16:22:09 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.financialmgmt.accounting.report.notposted/rev/f0f8a57bda51d8ffd94562a8cf2e1e884569441c [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

Post: set "Compatibility with Legacy Grids" = N as they are manual UI Pattern processes

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
---
(0097878)
hgbot   
2017-07-05 16:57   
Repository: erp/pmods/org.openbravo.materialmgmt.catalog
Changeset: 04c7f381f7c60e9740b61ff4c760d8004abe7d90
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 05 16:58:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.materialmgmt.catalog/rev/04c7f381f7c60e9740b61ff4c760d8004abe7d90 [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

ManageCatalog: set "Compatibility with Legacy Grids" = N as it is a manual UI Pattern process
Copy Categorization and Unlist Products: set "Compatibility with Legacy Grids" = N as they don't have a grid parameter

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
---
(0097879)
hgbot   
2017-07-05 17:18   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 2e4e9057fba23f45be836f5647d3fa78af62c2b5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 05 17:20:22 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/2e4e9057fba23f45be836f5647d3fa78af62c2b5 [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

Select Payments Pick and Edit: minor refactor in associated handler to remove grid legacy compatibility

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/module/remittance/process/SelectPaymentsPickEditLines.java
---
(0097898)
hgbot   
2017-07-06 09:22   
Repository: erp/pmods/org.openbravo.warehouse.packing
Changeset: 4d4229f8a68b143fe1a9b60d81f922f7af097902
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 06 09:23:58 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.packing/rev/4d4229f8a68b143fe1a9b60d81f922f7af097902 [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

Create Packing, Create Packing Header, OBWPACK_ProcessPackShip and processPack: set "Compatibility with Legacy Grids" = N as they are manual UI Pattern processes
Pick Goods Shipments: minor refactor in associated handler to remove grid legacy compatibility

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/warehouse/packing/PickEditGSActionHandler.java
---
(0097900)
hgbot   
2017-07-06 10:14   
Repository: erp/pmods/org.openbravo.materialmgmt.freightmgmt
Changeset: 7b6779e41acb0c987986d976ec9ca1d37e72c59d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 06 10:15:32 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.materialmgmt.freightmgmt/rev/7b6779e41acb0c987986d976ec9ca1d37e72c59d [^]

Fixed issue 36285: Adapted Process Definition to remove grid legacy compatibility

Create Freight and Set Total Weight: set "Compatibility with Legacy Grids" = N as they don't have a grid parameter
Select Freight: minor refactor in associated handler to remove grid legacy compatibility

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/materialmgmt/freightmgmt/SelectFreightHandler.java
---
(0097901)
vmromanos   
2017-07-06 10:16   
Test plan Remittance module:
Install remittance module
As Openbravo Admin
Go to Enterprise Module Management window, select * and apply Remittance dataset
Go to Financial Account window, select Cuenta de Banco and add Remittance payment method
Go to Sales Invoice window and create two invoices with payment method "Remittance"
Add a Payment for each invoice (with payment method "Remittance")
Go to Remittance window create a new header and fill mandatory fields
Press select payments button.
Select one of the payments created before.
Verify process is completed successfully and just the selected line has been added to Lines tab.
Press again Select Payments and uncheck selected line.
Verify process is completed successfully and the line has been removed from the Lines tab.


Test plan Warehouse Packing:
Install Warehouse Packing module
As Openbravo Admin
Go to Goods Shipment window and create two record for the same business partner with any line each. Complete them.
Go to Packing window and create a new record for the previous business partner and press the Pick Shipments button.
Select any line and press Done.
Verify process is completed successfully and just the selected line has been added to the Goods Shipment and Goods Shipment Lines tabs
Press again Pick Shipments button and uncheck selected line.
Verify process is completed successfully and the line has been removed from the Goods Shipment tab


Test plan Freight Management:
Install Freight Management module
As Openbravo Admin
Go to Freight Category window and create a new record. Fill mandatory fields
Go to Delivery Period window and create a new record. Fill mandatory fields
Go to Carrier window. Set a name and Product
Go to Freight tab. Fill mandatory fields with records created before. Set Valid From date some day in the past
Go to definition window and set Freight Amount=50. Leave blank other fields
Go to Sales Order window and create a new header.
Press Select Freight button and select the line. Press Done.
Verify process is completed successfully and selected freight is set in Freight field at the header
(0097902)
vmromanos   
2017-07-06 10:16   
Fixed in modules:
Carrier Integration Base 1.0.100
Not Posted Transactions 1.1.100
Product Catalogs 1.0.300
Remittances infrastructure 3.2.1700
Warehouse Packing 1.1.200
Freight Management 1.0.200
(0097987)
aferraz   
2017-07-10 16:49   
Code review OK