Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036281Openbravo ERPA. Platformpublic2017-06-19 18:332018-01-18 12:34
Reportershuehner 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036281: "Grid Legacy" warning should be moved from runtime to compile time
DescriptionWarning about 'Grid Legacy' asking for updating the process definition+code is currently shown only when running the process via BaseProcessActionHandler.

That makes is very hard to spot all processes in need for conversion.

The simple part which can be checked with looking at actual request values should be moved to compile time to notice when compiling or in ci all the processes

Quick check of the code shows an sql similar to the following seems cover:
a.) the basic check about legacy
b.) the 'can be safely marked non-legacy part also

select m.javapackage, p.obuiapp_process_id, p.name, (select count(*) from obuiapp_parameter param where param.ad_reference_id = 'FF80818132D8F0F30132D9BC395D0038' and param.obuiapp_process_id = p.obuiapp_process_id) as grid_param from obuiapp_process p, ad_module m where p.ad_module_id = m.ad_module_id and p.isgridlegacy = 'Y' order by m.javapackage, p.name;

Note: the sub-select covers checking the defined grid-parameters similar to the check in BaseProcessActionHandler (without the 'request' part which is unclear if needed to be checked for this)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00362823.0PR17Q4 closed vmromanos Openbravo ERP Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use 
related to defect 0036283 closed ranjith_qualiantech_com Retail Modules Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use 
related to defect 0036284 closed ranjith_qualiantech_com Retail Modules Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use 
related to defect 0036285 closed vmromanos Openbravo ERP Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use 
related to defect 0036286 closed jarmendariz Openbravo ERP Several processes are marked as 'Grid Legacy' and should be converted to avoid runtime warning on every use 
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 18:33shuehnerNew Issue
2017-06-19 18:33shuehnerAssigned To => platform
2017-06-19 18:33shuehnerModules => Core
2017-06-19 18:33shuehnerTriggers an Emergency Pack => No
2017-06-19 18:35shuehnerRelationship addedrelated to 0036282
2017-06-19 18:36shuehnerRelationship addedrelated to 0036283
2017-06-19 18:41shuehnerRelationship addedrelated to 0036284
2017-06-19 18:43shuehnerRelationship addedrelated to 0036285
2017-06-19 18:45shuehnerRelationship addedrelated to 0036286
2017-06-20 09:26alostaleStatusnew => acknowledged
2017-06-20 09:27alostaleRelationship addedblocks 0036162
2018-01-18 12:34jarmendarizAssigned Toplatform => jarmendariz

There are no notes attached to this issue.