Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036280Openbravo ERP01. General setuppublic2017-06-19 18:162018-05-14 13:09
Reportershuehner 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036280: Several unused + probably unusable callouts exists and are candidates to be deleted
DescriptionThe following classes are servlets but do all do not have a corresponding ad_model_object entry.

That means they have no servlet mapping and that they cannot be used as callouts (as defined callouts find the java class implementing them via ad_model_object).

So all these seem not usable and are candidates for deletion:

org.openbravo.erpCommon.ad_callouts.SE_Years_For_Calendar
org.openbravo.erpCommon.ad_callouts.SL_CreateFromMultiple_Warehouse
org.openbravo.erpCommon.ad_callouts.SL_Payment_No_Verify
org.openbravo.erpCommon.ad_callouts.SL_CreateFromMultiple_Conversion
org.openbravo.erpCommon.ad_callouts.SL_MovementAll_Locator
org.openbravo.erpCommon.ad_callouts.SL_Payment_DocType
org.openbravo.erpCommon.ad_callouts.SL_CreateFromMultiple_Product
org.openbravo.erpCommon.ad_callouts.SL_Payment_Amounts
org.openbravo.erpCommon.ad_callouts.SE_Calendar_For_Org
org.openbravo.erpCommon.ad_callouts.SL_WorkRequirement_Sequence
org.openbravo.erpCommon.ad_callouts.SL_Invoice_Tax
org.openbravo.erpCommon.ad_callouts.SL_InOutLine_Locator
Steps To Reproduce-
Proposed SolutionDouble check each as usual before deleting anything and maybe remove them.
Note on removal careful to also remove any related items no longer used after deleting those callouts (i.e. xsql files, xmlengine template ...)
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0036362 closed AtulOpenbravo API Change request 
related to defect 0036279 closed shuehner Unused manual servlets: HeartbeatConfirm & RegistrationConfirm 
related to defect 0036358 closed markmm82 Create From Multiple process and related callouts are candidates to be deleted 
related to design defect 0036067 closed markmm82 old callouts should be refactored to implement SimpleCallout 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Filesdiff 36280.diff (62,814) 2017-06-27 13:36
https://issues.openbravo.com/file_download.php?file_id=10874&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 18:16shuehnerNew Issue
2017-06-19 18:16shuehnerAssigned To => Triage Finance
2017-06-19 18:16shuehnerModules => Core
2017-06-19 18:16shuehnerTriggers an Emergency Pack => No
2017-06-19 18:16shuehnerRelationship addedrelated to 0036279
2017-06-27 12:23vmromanosStatusnew => scheduled
2017-06-27 12:23vmromanosAssigned ToTriage Finance => vmromanos
2017-06-27 12:42vmromanosRelationship addedrelated to 0036358
2017-06-27 12:45vmromanosNote Added: 0097708
2017-06-27 13:36vmromanosFile Added: 36280.diff
2017-06-27 14:12vmromanosRelationship addeddepends on 0036362
2017-09-22 15:14aferrazRelationship addedrelated to 0036067
2018-04-16 11:59shuehnerRelationship addedblocks 0032688
2018-04-25 10:05dmiguelezAssigned Tovmromanos => AtulOpenbravo
2018-05-11 13:58hgbotCheckin
2018-05-11 13:58hgbotNote Added: 0104473
2018-05-11 13:58hgbotCheckin
2018-05-11 13:58hgbotNote Added: 0104475
2018-05-11 13:58hgbotStatusscheduled => resolved
2018-05-11 13:58hgbotResolutionopen => fixed
2018-05-11 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2db82514d5d58618fd8621ec5722e3b7a24c8f5e [^]
2018-05-11 13:58hgbotCheckin
2018-05-11 13:58hgbotNote Added: 0104476
2018-05-11 13:59aferrazReview Assigned To => aferraz
2018-05-11 13:59aferrazNote Added: 0104480
2018-05-11 13:59aferrazStatusresolved => closed
2018-05-11 13:59aferrazFixed in Version => 3.0PR18Q3
2018-05-14 13:09hudsonbotCheckin
2018-05-14 13:09hudsonbotNote Added: 0104495
2018-05-14 13:09hudsonbotCheckin
2018-05-14 13:09hudsonbotNote Added: 0104496

Notes
(0097708)
vmromanos   
2017-06-27 12:45   
Most of these callouts can be safely removed because they are not referenced by any internal or external class. This will obviously create an API change with very low risk.

However there are 3 callouts that won't be removed right now because they are referenced by a process. See 0036358 for details
(0104473)
hgbot   
2018-05-11 13:58   
Repository: erp/devel/api-checks
Changeset: 3aec9468515a8265dce7b7d5e03ac5ddbab136ed
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 11 13:57:15 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3aec9468515a8265dce7b7d5e03ac5ddbab136ed [^]

Fixes issue 36362: API change for issue 36280

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_CALLOUT.xml
---
(0104475)
hgbot   
2018-05-11 13:58   
Repository: erp/devel/pi
Changeset: 2db82514d5d58618fd8621ec5722e3b7a24c8f5e
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed May 02 23:46:36 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/2db82514d5d58618fd8621ec5722e3b7a24c8f5e [^]

Fixes Issue 36280:Several unused + probably unusable callouts exists and are
candidates to be deleted.

** All the below callouts are not used in internal and external class and
has a low risk to remove them.
** Removed java files for SE_Years_For_Calendar, SE_Calendar_For_Org and
registers in ad_callout.
** Removed java files for SL_Payment_No_Verify, SL_MovementAll_Locator,
SL_Payment_DocType & data xsql file, SL_Payment_Amounts,
SL_WorkRequirement_Sequence & xsql file, SL_Invoice_Tax,
SL_InOutLine_Locator & data xsql file.

---
M src-db/database/sourcedata/AD_CALLOUT.xml
R src/org/openbravo/erpCommon/ad_callouts/SE_Calendar_For_Org.java
R src/org/openbravo/erpCommon/ad_callouts/SE_Years_For_Calendar.java
R src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Locator.java
R src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Locator_data.xsql
R src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Tax.java
R src/org/openbravo/erpCommon/ad_callouts/SL_MovementAll_Locator.java
R src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts.java
R src/org/openbravo/erpCommon/ad_callouts/SL_Payment_DocType.java
R src/org/openbravo/erpCommon/ad_callouts/SL_Payment_DocType_data.xsql
R src/org/openbravo/erpCommon/ad_callouts/SL_Payment_No_Verify.java
R src/org/openbravo/erpCommon/ad_callouts/SL_WorkRequirement_Sequence.java
R src/org/openbravo/erpCommon/ad_callouts/SL_WorkRequirement_Sequence.xsql
---
(0104476)
hgbot   
2018-05-11 13:58   
Repository: erp/devel/pi
Changeset: 2663ab08fb3f48cd010666fb0c5e58fc276dd25d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 11 10:13:35 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2663ab08fb3f48cd010666fb0c5e58fc276dd25d [^]

Related to issue 36280: Remove SL_Payment_Amounts_data.xsql

---
R src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts_data.xsql
---
(0104480)
aferraz   
2018-05-11 13:59   
Code review + Testing OK
(0104495)
hudsonbot   
2018-05-14 13:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ed385e0e027b [^]
Maturity status: Test
(0104496)
hudsonbot   
2018-05-14 13:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ed385e0e027b [^]
Maturity status: Test