Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036279Openbravo ERPA. Platformpublic2017-06-19 18:062017-09-22 10:17
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036279: Unused manual servlets: HeartbeatConfirm & RegistrationConfirm
DescriptionThose 2 files are servlet but do not have an entry in ad_model_object mapping.

That means they do not have a mapping as a servlet in web.xml so are not callable.

So they appear unused & unusable in their current state.

9062 [main] WARN org.openbravo.test.model.UnusedServletTest - NO ad_model_object entry for servlet: org.openbravo.erpCommon.ad_forms.HeartbeatConfirm
9150 [main] WARN org.openbravo.test.model.UnusedServletTest - NO ad_model_object entry for servlet: org.openbravo.erpCommon.ad_forms.RegistrationConfirm
Steps To Reproduce-
Proposed SolutionDelete the 2 files + their associated data (i.e. textinterfaces + html/xml of xmlEngine templates)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036280 closed AtulOpenbravo Several unused + probably unusable callouts exists and are candidates to be deleted 
related to defect 0036923 closed shuehner api-changes related to unused code removal 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 18:06shuehnerNew Issue
2017-06-19 18:06shuehnerAssigned To => platform
2017-06-19 18:06shuehnerOBNetwork customer => No
2017-06-19 18:06shuehnerModules => Core
2017-06-19 18:06shuehnerTriggers an Emergency Pack => No
2017-06-19 18:16shuehnerRelationship addedrelated to 0036280
2017-06-20 09:25alostaleRelationship addedblocks 0032688
2017-06-20 09:25alostaleStatusnew => acknowledged
2017-09-15 17:48shuehnerAssigned Toplatform => shuehner
2017-09-21 23:06shuehnerRelationship addedrelated to 0036923
2017-09-21 23:10hgbotCheckin
2017-09-21 23:10hgbotNote Added: 0099438
2017-09-21 23:10hgbotStatusacknowledged => resolved
2017-09-21 23:10hgbotResolutionopen => fixed
2017-09-21 23:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6c767fe487d2ffed7acafd0fe344b8d6b89f3bf0 [^]
2017-09-21 23:14shuehnerReview Assigned To => alostale
2017-09-21 23:14shuehnerFixed in Version => 3.0PR17Q4
2017-09-22 10:17alostaleNote Added: 0099466
2017-09-22 10:17alostaleStatusresolved => closed

Notes
(0099438)
hgbot   
2017-09-21 23:10   
Repository: erp/devel/pi
Changeset: 6c767fe487d2ffed7acafd0fe344b8d6b89f3bf0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Sep 15 16:42:36 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c767fe487d2ffed7acafd0fe344b8d6b89f3bf0 [^]

Fixed 36279. Removed unused HeartbeatConfirm & RegistrationConfirm files.

Both servlets did already not have a ad_model_object and _mapping entry so they
could not be called.
Also checking in getAllModules did not find any references in modules.

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
R src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.html
R src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.java
R src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.xml
R src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.html
R src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.java
R src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.xml
---
(0099466)
alostale   
2017-09-22 10:17   
reviewed