0036275: [SERQA 3022] Error callback not done in runSyncProcess (PostCustomerSave hook)

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036275

Retail Modules

Web POS

public

2017-06-19 16:59

2017-06-27 09:12

Reporter

jonibc

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036275: [SERQA 3022] Error callback not done in runSyncProcess (PostCustomerSave hook)

Description

Error callback is not sent to RunSyncProcess function, so if an error is raised, while saving a customer, can block 'Save' and 'Cancel' buttons until a refresh is done in the browser.

          OB.UTIL.HookManager.executeHooks('OBPOS_PostCustomerSave', {
            customer: customer,
            bpToSave: bpToSave
          }, function (args) {
            OB.Dal.save(bpToSave, function () {
              // update each order also so that new name is shown and the bp
              // in the order is the same as what got saved
....
              var successCallback, errorCallback, List;
              successCallback = function () {
                if (callback) {
                  callback();
                }
                OB.UTIL.showSuccess(OB.I18N.getLabel('OBPOS_customerSaved', [customer.get('_identifier')]));
              };
              OB.MobileApp.model.runSyncProcess(successCallback);
            }, function () {
              //error saving BP changes with changes in changedbusinesspartners
              OB.UTIL.showError(OB.I18N.getLabel('OBPOS_errorSavingCustomerChanges', [customer.get('_identifier')]));
            });

Steps To Reproduce

N/A

Proposed Solution

Add callback to runSyncProcess function as follows:

OB.MobileApp.model.runSyncProcess(successCallback, callback);

Also to avoid the error added in Notes, the proposal is:

Send a boolean parameter through callback function, that allows to skip the code if an error is raised.

Additional Information