Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036273Retail ModulesCash uppublic2017-02-09 18:352017-08-09 13:57
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1.3Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket43392
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036273: during cashup, it is possible duplicate invoice lines when one orderline generates two or more invoice lines
Descriptionwhen one orderline is related with two or more goods shipment lines, tow invoice lines are generated, and in some cases, one extra line is generated and the sum of qty invoiced is higher than qty ordered
Steps To Reproducestock prod1:
  locator 1 - prod1 (with lot1) - qty 1.25
  locator 1 - prod1 (with lot2) - qty 0.72
in POS:
. create one receipt with the check "invoice this receipt"
. add one line:prod1
 qty 2
. complete the receipt

create new receipt without check "invoice this receipt":
 . prod2 (it is not important)
  qty 1
. complete the receipt

in backoffice:
 invoice1 has been created:
   line1 prod1: qty 1.25
   line2 prod1: qty 0.75

in POS:
 do cashup

in backoffice:
 invoice1 has been updated:
   line1 prod1: qty 1.25
   line2 prod1: qty 0.75
   line3 prod1: qty 0.75

It is reproducible randomly
Proposed Solutionattached a patch with a possible solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035216 closed ranjith_qualiantech_com during cashup, it is possible duplicate invoice lines when one orderline generates two or more invoice lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-19 12:45marvintmTypedefect => backport
2017-06-19 12:45marvintmTarget Version => RR17Q1.2
2017-06-19 12:45marvintmTarget VersionRR17Q1.2 => RR17Q1.3
2017-07-05 09:53hgbotCheckin
2017-07-05 09:53hgbotNote Added: 0097864
2017-07-05 09:53hgbotStatusscheduled => resolved
2017-07-05 09:53hgbotResolutionopen => fixed
2017-07-05 09:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8467cfbe97a880b1946632bac69c9d2453a4961d [^] => http://code.openbravo.com/retail/backports/3.0RR17Q1.3/org.openbravo.retail.posterminal/rev/b52a8d53ec5f238bebb0c3e6a90a44a8eee9e163 [^]
2017-07-05 09:53hgbotCheckin
2017-07-05 09:53hgbotNote Added: 0097865
2017-08-02 16:27migueldejuanaReview Assigned Tomarvintm => migueldejuana
2017-08-02 16:27migueldejuanaNote Added: 0098349
2017-08-02 16:27migueldejuanaStatusresolved => closed
2017-08-09 13:57hgbotCheckin
2017-08-09 13:57hgbotNote Added: 0098451

Notes
(0097864)
hgbot   
2017-07-05 09:53   
Repository: retail/backports/3.0RR17Q1.3/org.openbravo.retail.posterminal
Changeset: b52a8d53ec5f238bebb0c3e6a90a44a8eee9e163
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jul 05 13:23:06 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.3/org.openbravo.retail.posterminal/rev/b52a8d53ec5f238bebb0c3e6a90a44a8eee9e163 [^]

Fixes issue 36273 : Invoice Line should not be created again, if it is already created in OrderLoader

* If Invoice Line are already created in OrderLoader, then while doing cashup, Invoice line should not be created/splited again
* Invoice are filterted by CashUp identifier

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0097865)
hgbot   
2017-07-05 09:53   
Repository: retail/backports/3.0RR17Q1.3/pi-mobile
Changeset: 58a150142c246209da760bd8c349688e8e266eb0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jul 05 13:23:15 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.3/pi-mobile/rev/58a150142c246209da760bd8c349688e8e266eb0 [^]

Verifies issue 36273 : Added automated test 'I36273_VerifyCashUpSplitLines'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36273_VerifyCashUpSplitLines.java
---
(0098349)
migueldejuana   
2017-08-02 16:27   
tested and reviewed
(0098451)
hgbot   
2017-08-09 13:57   
Repository: tools/automation/pi-mobile
Changeset: 58a150142c246209da760bd8c349688e8e266eb0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jul 05 13:23:15 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/58a150142c246209da760bd8c349688e8e266eb0 [^]

Verifies issue 36273 : Added automated test 'I36273_VerifyCashUpSplitLines'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36273_VerifyCashUpSplitLines.java
---