Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036268Openbravo ERPA. Platformpublic2017-06-16 12:482017-06-28 10:12
ReporterJONHM 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toinigosanchez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-05-24
Regression introduced in release3.0PR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/9105dfe33d79 [^]
Triggers an Emergency PackNo
Summary0036268: Product Complete selector does not show some fields on picklist
DescriptionProduct Complete selector does not show some fields on picklist
Steps To Reproduce*As System Administrator

1) Open 'Tables and columns' window, select "OrderLine" table and open [M_Product_ID] column
2) Change 'Reference Search Key' field to "Product Complete (Stocked only)"
3) Then, open that reference in 'Reference' window, "Product Complete (Stocked only)", switch to [Defined Selector] tab and then switch to [Defined Selector Field] subtab.
4) Select 'Search Key' field and check on the checkbox "Show in picklist"
-- Recompile the application

*As F&B International Group Admin

5) Open window [Sales Order] and create a new one for 'Alimentos y Supermercados' BP
6) Create a new line and open Product picklist. The search key is not shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00362953.0PR17Q2.1 closed caristu Product Complete selector does not show some fields on picklist 
depends on backport 00362963.0PR17Q1.2 closed caristu Product Complete selector does not show some fields on picklist 
caused by feature request 0033015 closed caristu Performance Improvements in Product Selector 
causes defect 0036728 closed caristu Error displaying in selector picklist a field based in a non-primitive derived property 
Attached Filespng Screenshot from 2017-06-16 12-43-46.png (136,223) 2017-06-16 12:48
https://issues.openbravo.com/file_download.php?file_id=10859&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-06-16 12:48JONHMNew Issue
2017-06-16 12:48JONHMAssigned To => platform
2017-06-16 12:48JONHMFile Added: Screenshot from 2017-06-16 12-43-46.png
2017-06-16 12:48JONHMModules => Core
2017-06-16 12:48JONHMRegression level => Production - Confirmed Stable
2017-06-16 12:48JONHMRegression introduced in release => 3.0PR16Q1
2017-06-16 12:48JONHMTriggers an Emergency Pack => No
2017-06-16 13:25alostaleSeveritycritical => minor
2017-06-16 13:29inigosanchezAssigned Toplatform => inigosanchez
2017-06-16 13:29inigosanchezStatusnew => acknowledged
2017-06-20 02:13inigosanchezRegression date => 2016-05-24
2017-06-20 02:13inigosanchezRegression introduced in release3.0PR16Q1 => 3.0PR16Q3
2017-06-20 02:13inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/9105dfe33d79 [^]
2017-06-20 02:13inigosanchezStatusacknowledged => scheduled
2017-06-20 02:13inigosanchezRelationship addedcaused by 0033015
2017-06-20 12:34inigosanchezStatusscheduled => acknowledged
2017-06-20 12:35inigosanchezStatusacknowledged => scheduled
2017-06-20 16:47inigosanchezNote Added: 0097523
2017-06-21 10:59caristuAssigned Toinigosanchez => caristu
2017-06-21 11:00hgbotCheckin
2017-06-21 11:00hgbotNote Added: 0097542
2017-06-21 11:00hgbotStatusscheduled => resolved
2017-06-21 11:00hgbotResolutionopen => fixed
2017-06-21 11:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bdca94625dbf67b7e9dbf54f7535f6f22b499b14 [^]
2017-06-21 11:09caristuReview Assigned To => inigosanchez
2017-06-21 14:54inigosanchezNote Added: 0097555
2017-06-21 14:54inigosanchezStatusresolved => closed
2017-06-21 14:54inigosanchezFixed in Version => 3.0PR17Q3
2017-06-21 23:43hudsonbotCheckin
2017-06-21 23:43hudsonbotNote Added: 0097574
2017-06-28 10:12caristuNote Added: 0097734
2017-08-29 12:35caristuRelationship addedcauses 0036728

Notes
(0097523)
inigosanchez   
2017-06-20 16:47   
Added a test case in TestLink 3.0 Test Suite > Regression test cases > Test cases for 3.0PR16Q3 > 36268: Product Complete selector should show some fields with derived properties on picklist
(0097542)
hgbot   
2017-06-21 11:00   
Repository: erp/devel/pi
Changeset: bdca94625dbf67b7e9dbf54f7535f6f22b499b14
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jun 21 10:56:26 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bdca94625dbf67b7e9dbf54f7535f6f22b499b14 [^]

fixes bug 36268: Some fields marked to be shown on picklist show empty values

  With the fix for issue 0033015 just the required selector properties are sent, in order to prevent unneeded joins. With this change the properties of the fields to be displayed on the picklist and the extra properties are handled separately by the datasource.

  The poblem here is that the datasource was not handling properly the properties to be shown in the picklist which are derived, i.e., those properties that are resolved through property navigation. But this kind of properties are resolved properly if they are sent as extra properties.

  Therefore, to solve this issue, this kind of derived properties are sent as part of the extra properties.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0097555)
inigosanchez   
2017-06-21 14:54   
reviewed + tested
(0097574)
hudsonbot   
2017-06-21 23:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5e0471c14ef8 [^]
Maturity status: Test
(0097734)
caristu   
2017-06-28 10:12   
Added a new test into TestLink[1], to test that derived properties can be displayed on a selector drop-down list.

[1] https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10693 [^]