Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036261Openbravo ERPA. Platformpublic2017-06-16 10:392017-06-20 09:21
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036261: connections logged as abandoned in translate task
DescriptionIf logging abandoned connections is enabled, translate task logs its connection as abandoned when it finalizes.
Steps To Reproduce1. Configure Openbravo.properties to log abandoned connections: logAbandoned=true
2. ant smartbuild
   -> check compilation logs:
...
compile.translate:
...
     [java] 130823 [main] INFO org.openbravo.translate.Translate - Translated files for html: 486
     [java] Jun 16, 2017 10:30:25 AM org.apache.tomcat.jdbc.pool.ConnectionPool abandon
     [java] WARNING: Connection has been abandoned PooledConnection[org.postgresql.jdbc.PgConnection@6b5ceef5]:java.lang.Exception
     [java] at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:1096)
     [java] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:799)
     [java] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:648)
     [java] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:200)
     [java] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:128)
     [java] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnectionFromDS(JdbcExternalConnectionPool.java:130)
     [java] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnection(JdbcExternalConnectionPool.java:93)
     [java] at org.openbravo.database.ConnectionProviderImpl.getNewConnection(ConnectionProviderImpl.java:260)
     [java] at org.openbravo.database.ConnectionProviderImpl.getConnection(ConnectionProviderImpl.java:236)
     [java] at org.openbravo.database.ConnectionProviderImpl.getPreparedStatement(ConnectionProviderImpl.java:369)
     [java] at org.openbravo.database.ConnectionProviderImpl.getPreparedStatement(ConnectionProviderImpl.java:361)
     [java] at org.openbravo.database.CPStandAlone.getPreparedStatement(CPStandAlone.java:83)
     [java] at org.openbravo.translate.TranslateData.systemLanguage(TranslateData.java:571)
     [java] at org.openbravo.translate.TranslateData.systemLanguage(TranslateData.java:555)
     [java] at org.openbravo.translate.Translate.<init>(Translate.java:100)
     [java] at org.openbravo.translate.Translate.main(Translate.java:142)


Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036162 acknowledged Triage Platform Base clean up openbravo.log 
depends on feature request 00357043.0PR17Q3 closed alostale add support to log abandoned pool connections 
related to defect 0036274 closed alostale abandoned connection in SessionListener 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-16 10:39alostaleNew Issue
2017-06-16 10:39alostaleAssigned To => platform
2017-06-16 10:39alostaleModules => Core
2017-06-16 10:39alostaleTriggers an Emergency Pack => No
2017-06-16 10:39alostaleRelationship addedrelated to 0036162
2017-06-16 10:58alostaleRelationship addeddepends on 0035704
2017-06-16 10:58alostaleStatusnew => acknowledged
2017-06-16 12:55alostaleSummaryConnections are not properly closed in translate task => connections logged as abandoned in translate task
2017-06-16 12:55alostaleDescription Updatedbug_revision_view_page.php?rev_id=15377#r15377
2017-06-16 12:57alostaleAssigned Toplatform => alostale
2017-06-16 12:58hgbotCheckin
2017-06-16 12:58hgbotNote Added: 0097440
2017-06-16 12:58hgbotStatusacknowledged => resolved
2017-06-16 12:58hgbotResolutionopen => fixed
2017-06-16 12:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4e163d7f2a1d76a1aea1b09d388807a40cf06fb0 [^]
2017-06-16 19:02hudsonbotCheckin
2017-06-16 19:02hudsonbotNote Added: 0097462
2017-06-19 09:37alostaleReview Assigned To => caristu
2017-06-19 15:10alostaleRelationship addedrelated to 0036274
2017-06-20 09:21caristuNote Added: 0097500
2017-06-20 09:21caristuStatusresolved => closed
2017-06-20 09:21caristuFixed in Version => 3.0PR17Q3
2022-02-02 17:20AugustoMauchRelationship addedrelated to 0048510

Notes
(0097440)
hgbot   
2017-06-16 12:58   
Repository: erp/devel/pi
Changeset: 4e163d7f2a1d76a1aea1b09d388807a40cf06fb0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jun 16 12:57:27 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4e163d7f2a1d76a1aea1b09d388807a40cf06fb0 [^]

fixed bug 36261: connections logged as abandoned in translate task

  Connection for Translate task was kept unclosed in SessionInfo so when the pool
  was destroyed it was logged as abandoned.

  Fixed by closing it before destroying pool.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0097462)
hudsonbot   
2017-06-16 19:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/38c05e8441a9 [^]
Maturity status: Test
(0097500)
caristu   
2017-06-20 09:21   
Code reviewed + tested OK.