Openbravo Issue Tracking System - Retail Modules
View Issue Details
0036246Retail ModulesWeb POSpublic2017-05-09 16:032017-06-21 18:35
guilleaer 
guilleaer 
normalmajorhave not tried
closedfixed 
5
 
RR17Q2.1RR17Q2.1 
marvintm
No
0036246: Due to previous fix, popups are closed if a resize event occurs while a popup is opened
A bit of history about this issue:

Before to 17Q2, there was one issue which we were unable to fix (32975, 31071 and 31163) for a long time. The problem reported by all issues mentioned above talks about the same problem:
- "Popups do not work if you resize the window while the popup is opened"
- "Popups in web pos stop working if they are opened and the the pos window is resized"

Finally in 17Q2 we were able to find a fix, but this fix have one restriction explained in the notes:
"If you open a popup and then, having the popup opened the window is resized then the popup will be closed. The user can open it again and continue working."

Later in april, we decided that this restriction is not acceptable so this issue has been created. We need to completely solve the problem, even if the popup is opened.

Important note: This issue is not a regression because without the previous fix, popups are not closed but they are not working

why we can't close the popups if a resize occurs:

1. Imagine that a user is filling a long form which is is a popup and suddenly a resize event occurs. In this case the user will lose the data inserted in the popup
2. Some payments gateways are rendered using a popup. If a resize event occurs during the communication with the payment gateway, the popup will be closed and the user perception about the result of the transaction will be unpredictable.
Open receipts popup
resize the window

Result: Popup will be closed.
Popups should continue working even if a resize event happens.
No tags attached.
blocks defect 0035961RR17Q3 closed guilleaer Due to previous fix, popups are closed if a resize event occurs while a popup is opened 
Issue History
2017-06-13 18:11guilleaerTypedefect => backport
2017-06-13 18:11guilleaerTarget VersionRR17Q3 => RR17Q2.1
2017-06-13 18:39hgbotCheckin
2017-06-13 18:39hgbotNote Added: 0097375
2017-06-13 18:41hgbotCheckin
2017-06-13 18:41hgbotNote Added: 0097377
2017-06-13 18:43guilleaerStatusscheduled => resolved
2017-06-13 18:43guilleaerFixed in Version => RR17Q2.1
2017-06-13 18:43guilleaerResolutionopen => fixed
2017-06-21 18:35marvintmStatusresolved => closed

Notes
(0097375)
hgbot   
2017-06-13 18:39   
Repository: retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal
Changeset: f6c9961bc1d01b63e90266eef4e0c311f197e6fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:39:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/f6c9961bc1d01b63e90266eef4e0c311f197e6fa [^]

Related to issue 36246 backport of issue 35961: Remove red popup about not working popups

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0097377)
hgbot   
2017-06-13 18:41   
Repository: retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core
Changeset: e812f2772dc030460b2fb97233e5da716832fe93
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:40:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core/rev/e812f2772dc030460b2fb97233e5da716832fe93 [^]

Related to issue 36246 backport of issue 35961: Remove old code and apply new fix

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---