0036232: Discounts are not applied when a product is not included in the store assortment

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036232

Retail Modules

Discounts and Promotions

public

2017-06-01 11:59

2017-06-27 09:50

Reporter

malsasua

Assigned To

ranjith_qualiantech_com

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR17Q1.2

Fixed in Version

RR17Q1.2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

46774

Regression level

Production - Confirmed Stable

Regression date

2017-02-17

Regression introduced in release

RR17Q2

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]

Triggers an Emergency Pack

Summary

0036232: Discounts are not applied when a product is not included in the store assortment

Description

when a discount is configured with "included product: All excluding defined", and there is some product in product tab, then the discount is not applied for any product

Steps To Reproduce

in backend:
. discount and promotion window:
. discount: GPS_10_per
. change "included product" field, from "Only those defined" to "All excluding defined"
in product tab there are two products: gps handled and gps touch screen

in POS:
. add new product: inspect repelent
expected behavior: discount GPS_10_per should be applied, but it is not applied. It is not applied for any discount

Proposed Solution

in discount master query, this part should be removed:
    hql += "and ((p.includedProducts = 'Y' and not exists (select 1 ";
    hql += " from PricingAdjustmentProduct pap, OBRETCO_Prol_Product ppl ";
    hql += " where pap.active = true and pap.priceAdjustment = p ";
    hql += " and pap.product.id = ppl.product.id ";
    hql += " and ppl.obretcoProductlist.id ='" + productList.getId() + "')) ";

Additional Information