Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036210Retail ModulesWeb POSpublic2017-06-08 16:222017-06-26 10:01
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036210: It is possible to set more than 2 decimals on the Amount to Layaway popup on Pay Open Tickets
DescriptionOn the Pay Open Tickets window in web pos, it is possible to define an "amount to layaway" for each receipt, allowing to pay less than the total amount of that receipt and making it a layaway.
The numeric input on the Amount to Layaway popup allows the input of numbers with several decimals (i.e. 100.005) as an amount, which is not rounded correctly and can generate wrong payments
Steps To ReproduceLogin in web pos.
Create two draft receipts, and add products to both (i.e. Avalanche transceivers).
Go to the menu > Pay Open Tickets
Search and select both draft tickets
click on Done.
On the Pay Open Tickets screen, click on the first ticket to open the Amount to Layaway popup. Insert an amount of 100.005 and click on Apply.
Repeat the same step for the second ticket.
Result:
*The amount to pay of each ticket will show 100.01.
*The payment tab will show the message "200.01€ remaining to pay."

When the payment is added and the ticket is completed, both tickets are synchronized with a 100.01€ payment, generating an extra 0.01€.
Proposed SolutionAfter validating that the entered amount to layaway is a valid number, the amount should be rounded to two decimals.

Alternatively, the numeric validation of the amount to layaway might check that the number entered has at most 2 decimals.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-08 16:22aaroncaleroNew Issue
2017-06-08 16:22aaroncaleroAssigned To => Retail
2017-06-08 16:22aaroncaleroOBNetwork customer => Yes
2017-06-08 16:22aaroncaleroResolution time => 1498082400
2017-06-08 16:22aaroncaleroTriggers an Emergency Pack => No
2017-06-12 14:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-06-12 14:05ranjith_qualiantech_comStatusnew => scheduled
2017-06-14 10:56hgbotCheckin
2017-06-14 10:56hgbotNote Added: 0097386
2017-06-15 07:58hgbotCheckin
2017-06-15 07:58hgbotNote Added: 0097400
2017-06-15 07:58hgbotStatusscheduled => resolved
2017-06-15 07:58hgbotResolutionopen => fixed
2017-06-15 07:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9935019822db108d37a417de6aea1fb425a974ec [^]
2017-06-21 07:49mtaalReview Assigned To => mtaal
2017-06-21 07:49mtaalNote Added: 0097540
2017-06-21 07:49mtaalStatusresolved => closed
2017-06-21 07:49mtaalFixed in Version => RR17Q3
2017-06-21 13:17hgbotCheckin
2017-06-21 13:17hgbotNote Added: 0097550
2017-06-22 14:01mtaalNote Added: 0097586
2017-06-22 14:01mtaalStatusclosed => new
2017-06-22 14:01mtaalResolutionfixed => open
2017-06-22 14:01mtaalFixed in VersionRR17Q3 =>
2017-06-22 14:36ranjith_qualiantech_comStatusnew => scheduled
2017-06-22 23:22mtaalNote Added: 0097595
2017-06-26 07:04hgbotCheckin
2017-06-26 07:04hgbotNote Added: 0097625
2017-06-26 07:04hgbotStatusscheduled => resolved
2017-06-26 07:04hgbotResolutionopen => fixed
2017-06-26 07:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9935019822db108d37a417de6aea1fb425a974ec [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b010a60675e17c056d465640af34f50ca21d026c [^]
2017-06-26 08:40mtaalNote Added: 0097629
2017-06-26 08:40mtaalStatusresolved => new
2017-06-26 08:40mtaalResolutionfixed => open
2017-06-26 09:24ranjith_qualiantech_comStatusnew => scheduled
2017-06-26 09:27hgbotCheckin
2017-06-26 09:27hgbotNote Added: 0097634
2017-06-26 09:27hgbotStatusscheduled => resolved
2017-06-26 09:27hgbotResolutionopen => fixed
2017-06-26 09:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b010a60675e17c056d465640af34f50ca21d026c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/86aca8f02b236dca27e19cd8a1dcf1846e41d5f2 [^]
2017-06-26 10:01mtaalNote Added: 0097640
2017-06-26 10:01mtaalStatusresolved => closed
2017-06-26 10:01mtaalFixed in Version => RR17Q3

Notes
(0097386)
hgbot   
2017-06-14 10:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2fc377756e99fa56141f6c07c770e747b8366036
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Jun 12 18:41:15 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2fc377756e99fa56141f6c07c770e747b8366036 [^]

Related issue 36210: Check decimal precision for payment amount

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0097400)
hgbot   
2017-06-15 07:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9935019822db108d37a417de6aea1fb425a974ec
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 15 11:28:20 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9935019822db108d37a417de6aea1fb425a974ec [^]

Fixed issue 36210 : Added Rounding Mode to amount to layaway in Pay Open Tickets

---
M web/org.openbravo.retail.posterminal/js/components/modalmultiorderslayaway.js
---
(0097540)
mtaal   
2017-06-21 07:49   
Reviewed
(0097550)
hgbot   
2017-06-21 13:17   
Repository: tools/automation/pi-mobile
Changeset: f754f54a3db770acc3b4260d59eb11ee119017ed
Author: Eduardo Becerra <ebec70 <at> yahoo.com>
Date: Mon Jun 19 10:19:58 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f754f54a3db770acc3b4260d59eb11ee119017ed [^]

Verifies issue 36210: Add automated test 'I36210_VerifyDecimalPlacesOnPaymentAmount'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36210_VerifyDecimalPlacesOnPaymentAmount.java
---
(0097586)
mtaal   
2017-06-22 14:01   
In hinsight the current solution rounds if a user enters too many decimals in the popup. It is better if this is prevented just like the case if the user enters the amount through the keypad.
 
So not round but prevent people to enter (or give error message) too many decimals as it is most probably a typing error.
(0097595)
mtaal   
2017-06-22 23:22   
Also add log statements for the following cases:
- that the total which will be paid is more than the total to pay
- if the user enters more than the allowed digits, to keep track on how often this happens

The log statements should be client log statements which are send to the backoffice to be saved.
(0097625)
hgbot   
2017-06-26 07:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b010a60675e17c056d465640af34f50ca21d026c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 10:33:29 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b010a60675e17c056d465640af34f50ca21d026c [^]

Fixes issue 36210 : Validate amount to lawaway with receipt total amount

* If amount to lawaway decimal values length are not equal with default decimal value length, the user must be alerted with decimals are not correct
* Added logs when user enter more decimals than default and user enter more amount than receipt amount

---
M web/org.openbravo.retail.posterminal/js/components/modalmultiorderslayaway.js
---
(0097629)
mtaal   
2017-06-26 08:40   
Please change the OB.info log statements to OB.warn
(0097634)
hgbot   
2017-06-26 09:27   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 86aca8f02b236dca27e19cd8a1dcf1846e41d5f2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 12:55:44 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/86aca8f02b236dca27e19cd8a1dcf1846e41d5f2 [^]

Fixed issue 36210 : Changed log level from info to warn while adding amount to lawaway

---
M web/org.openbravo.retail.posterminal/js/components/modalmultiorderslayaway.js
---
(0097640)
mtaal   
2017-06-26 10:01   
Reviewed and checked