Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0036206 | Openbravo ERP | 04. Warehouse management | public | 2017-06-08 13:44 | 2017-06-27 00:09 |
|
Reporter | ngarcia | |
Assigned To | collazoandy4 | |
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR17Q3 | |
Merge Request Status | |
Review Assigned To | aferraz |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0036206: Cannot calculate costs if the costing rule is validated with FIFO Costing Algorithm and Backdated Transactions Fixed |
Description | Cannot calculate costs if the costing rule is validated with FIFO Costing Algorithm and Backdated Transactions Fixed |
Steps To Reproduce | As system admin role:
Install FIFO Costing Algorithm module
As group admin role:
Validate a new costing rule:
Costing Algorithm: FIFO Costing Algorithm
Backdated Transaction Fixed: Y
Create a new product
Add a purchase price list
Create a Goods Receipt with a date in the future, add the previously created product and complete it
Create a Goods Shipment with a date in the future, add the previously created product and complete it
Launch the Costing Background Process and check it finishes successfully
Create a Goods Receipt with today's date, add the previously created product and complete it
Launch the Costing Background Process and check it finishes with the following message in Process Log field:
"The algorithm used to calculate the cost of the transaction does not implement cost adjustments."
Try to validate a new costing rule with the same algorithm but without backdated transactions fixed option selected and check the following error message is shown:
"Transaction with Cost Not Calculated" |
Proposed Solution | It should not be possible to validate a Costing Rule with FIFO Costing Algorithm and Backdated Transactions Fixed.
It should not be possible to launch the Fix Backdated Transactions process for an already costing rule with FIFO Costing Algorithm |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | feature request | 0029957 | | new | Triage Omni WMS | It would be fine to have Cost Adjustments and Landed Cost implemented for FIFO Costing Algorithm | related to | design defect | 0030776 | | new | Triage Omni WMS | Backdated Transactions Fixed check-box not shown for the modules that does not support this function. | related to | design defect | 0036326 | | acknowledged | Triage Platform Base | WeldUtils not supported from @BeforeClass method in JUnit |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2017-06-08 13:44 | ngarcia | New Issue | |
2017-06-08 13:44 | ngarcia | Assigned To | => Triage Finance |
2017-06-08 13:44 | ngarcia | Modules | => Core |
2017-06-08 13:44 | ngarcia | Resolution time | => 1498687200 |
2017-06-08 13:44 | ngarcia | Triggers an Emergency Pack | => No |
2017-06-08 13:45 | ngarcia | Issue Monitored: networkb | |
2017-06-08 13:46 | ngarcia | Relationship added | related to 0029957 |
2017-06-09 13:11 | aferraz | Relationship added | related to 0030776 |
2017-06-09 14:02 | aferraz | Assigned To | Triage Finance => collazoandy4 |
2017-06-19 16:14 | collazoandy4 | Status | new => scheduled |
2017-06-20 17:27 | collazoandy4 | Note Added: 0097530 | |
2017-06-22 23:28 | collazoandy4 | Note Edited: 0097530 | bug_revision_view_page.php?bugnote_id=0097530#r15405 |
2017-06-23 13:37 | aferraz | Relationship added | related to 0036326 |
2017-06-23 13:39 | hgbot | Checkin | |
2017-06-23 13:39 | hgbot | Note Added: 0097609 | |
2017-06-23 13:39 | hgbot | Status | scheduled => resolved |
2017-06-23 13:39 | hgbot | Resolution | open => fixed |
2017-06-23 13:39 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5499606ee60dd23a93e3b0eb71181e2ee5a0fd47 [^] |
2017-06-23 13:39 | hgbot | Checkin | |
2017-06-23 13:39 | hgbot | Note Added: 0097610 | |
2017-06-23 13:39 | hgbot | Checkin | |
2017-06-23 13:39 | hgbot | Note Added: 0097611 | |
2017-06-23 13:41 | aferraz | Review Assigned To | => aferraz |
2017-06-23 13:41 | aferraz | Note Added: 0097612 | |
2017-06-23 13:41 | aferraz | Status | resolved => closed |
2017-06-23 13:41 | aferraz | Fixed in Version | => 3.0PR17Q3 |
2017-06-27 00:09 | hudsonbot | Checkin | |
2017-06-27 00:09 | hudsonbot | Note Added: 0097686 | |
2017-06-27 00:09 | hudsonbot | Checkin | |
2017-06-27 00:09 | hudsonbot | Note Added: 0097687 | |
2017-06-27 00:09 | hudsonbot | Checkin | |
2017-06-27 00:09 | hudsonbot | Note Added: 0097688 | |
Notes |
|
(0097530)
|
collazoandy4
|
2017-06-20 17:27
(edited on: 2017-06-22 23:28) |
|
As group admin role:
Go to Costing Rule window and create a new record:
Costing Algorithm: FIFO Costing Algorithm
Backdated Transaction Fixed: Y
Clic on Validate button and check an error is shown
The algorithm used to calculate the cost of the transaction does not implement cost adjustments.
Edit the previous costing rule created and set
Backdated Transaction Fixed: N
Clic on Validate button
Clic on Fix Backdated Transaction and check an error is shown
The algorithm used to calculate the cost of the transaction does not implement cost adjustments.
|
|
|
(0097609)
|
hgbot
|
2017-06-23 13:39
|
|
Repository: erp/devel/pi
Changeset: 5499606ee60dd23a93e3b0eb71181e2ee5a0fd47
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jun 22 12:10:10 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/5499606ee60dd23a93e3b0eb71181e2ee5a0fd47 [^]
Fixes issue 36206: Error when validating FIFO costing rule with backdated
A new validation was added to the Fix Backdated Transaction process and Validate Costing Rule
with Backdated transactions fixed activated to check if the algorithm supports cost
adjustment raising an exception message if not.
---
M src/org/openbravo/costing/CostAdjustmentProcess.java
M src/org/openbravo/costing/CostingRuleProcess.java
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
|
|
|
(0097610)
|
hgbot
|
2017-06-23 13:39
|
|
|
|
(0097611)
|
hgbot
|
2017-06-23 13:39
|
|
Repository: erp/devel/pi
Changeset: 9cbc43343d02e8e284abf96ea991c2cb4fb5bff3
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Jun 23 13:10:31 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9cbc43343d02e8e284abf96ea991c2cb4fb5bff3 [^]
Related to issue 36206: Adapt TestCosting
Change setInitialConfiguration() method from @BeforeClass to @Before
to avoid error when calling to CostAdjustmentProcess.doGetAlgorithmAdjustmentImp()
as it is not possible to use Weld from @BeforeClass.
Although @Before methods are executed before each method,
we will execute it only once, same as @BeforeClass,
using runBefore flag.
---
M src-test/src/org/openbravo/test/costing/TestCosting.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|