Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036198Openbravo ERP02. Master data managementpublic2017-06-08 11:232017-06-23 13:53
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket47074
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036198: Volume Discount Invoice is created with 0 total gross amount if the price list includes taxes
DescriptionVolume Discount Invoice is created with 0 total gross amount if the price list includes taxes
Steps To ReproduceAs System Admin role:
   Set as Active the Volume Discount and Volume Discount Settlement windows
   Compile them

As group admin role:
   Set Tarifa de ventas as Price Includes Tax = 'Y'
   Check it is assigned to Hoteles Buenas Noches, S.A. business partner (Customer tab)
   Create a new record in Volume Discount window:
      Included product: All excluding defined
      Included Product Categories: All excluding defined
   Add a record in Volume Discount Parameters:
      Discount %: 5
      Min Amount: 0
   Add Hoteles Buenas Noches, S.A. in Business Partner tab
   Create a Sales Invoice for that business partner
   Go to Business Partner - Volume Discounts tab and launch the Create Invoice (Volume Discount) process
   Check the Line Net and Gross Amounts are 0 and thus the Total Net and Gross Amounts
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-08 11:23ngarciaNew Issue
2017-06-08 11:23ngarciaAssigned To => Triage Finance
2017-06-08 11:23ngarciaOBNetwork customer => Yes
2017-06-08 11:23ngarciaModules => Core
2017-06-08 11:23ngarciaSupport ticket => 47074
2017-06-08 11:23ngarciaResolution time => 1498687200
2017-06-08 11:23ngarciaTriggers an Emergency Pack => No
2017-06-08 11:23ngarciaIssue Monitored: networkb
2017-06-09 13:42aferrazAssigned ToTriage Finance => collazoandy4
2017-06-16 16:06collazoandy4Statusnew => scheduled
2017-06-19 16:14collazoandy4Note Added: 0097480
2017-06-22 13:49hgbotCheckin
2017-06-22 13:49hgbotNote Added: 0097584
2017-06-22 13:49hgbotStatusscheduled => resolved
2017-06-22 13:49hgbotResolutionopen => fixed
2017-06-22 13:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b1547bcf9013398566e63cd1176d1f572fae1696 [^]
2017-06-22 13:50aferrazReview Assigned To => aferraz
2017-06-22 13:50aferrazNote Added: 0097585
2017-06-22 13:50aferrazStatusresolved => closed
2017-06-22 13:50aferrazFixed in Version => 3.0PR17Q3
2017-06-23 13:53hudsonbotCheckin
2017-06-23 13:53hudsonbotNote Added: 0097614

Notes
(0097480)
collazoandy4   
2017-06-19 16:14   
As System Admin role:
  Set Core module as development
  Go to windows tabs and fields window and select Business Partner record:
    Check active field for the Volume Discount and Volume Discount Settlement tabs
  Rebuild the system

As group admin role:
  Go to Price List window and edit Tarifa de ventas record:
    Price Includes Tax = 'Y'
  Go to Volume Discount window and create a new record:
    Name: Issue
    Included product: All excluding defined
    Included Product Categories: All excluding defined
    Add a record in Volume Discount Parameters tab:
      Discount %: 5
      Min Amount: 0
    Add a new record in Business Partner tab:
      Business Partner: Hoteles Buenas Noches, S.A.
      Valid from date: today
  Go to Sales Invoice window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Create a new record in Lines tab:
      Product: Limonada 0,5L
      Invoiced Quantity: 10
    Complete the invoice
  Go to Business Partner window and select Hoteles Buenas Noches, S.A. record
    In Volume Discounts tab launch the Create Invoice (Volume Discount) process
  Go to the invoice created by the process and check the total net, gross amounts, line net are not 0
  
Test Plan II
  Go to Sales Invoice window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Create a new record in Lines tab:
      Product: Cola 0,5L
      Invoiced Quantity: 10
      Tax: Ventas exentas
    Create a new record in Basic Discounts tab:
      Basic Discount: Descuento 5%
   Complete the invoice and check:
     A new discount line was added with Net unit price / Line net amount: -0.42
(0097584)
hgbot   
2017-06-22 13:49   
Repository: erp/devel/pi
Changeset: b1547bcf9013398566e63cd1176d1f572fae1696
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Sat Jun 17 00:35:55 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/b1547bcf9013398566e63cd1176d1f572fae1696 [^]

Fixes issue 36198: Volume Discount Invoice is created with 0 total gross amount

The gross amount value was not added to the created invoice line causing 0 amount
if the price list include taxes

Now the gross amount is added to the invoice line and recalculate the line gross amount
if the line qtyinvoiced <> 0

---
M src-db/database/model/functions/M_RAPPEL_INVOICE_CREATE.xml
M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
---
(0097585)
aferraz   
2017-06-22 13:50   
Code review + Testing OK
(0097614)
hudsonbot   
2017-06-23 13:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/678e11052373 [^]
Maturity status: Test