Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036196Retail ModulesStoreServerpublic2017-06-08 09:192017-06-16 15:47
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q3Fixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036196: Prevent same ticket from being send twice by the user from being processed
DescriptionThere are special cases that the user submits a ticket but the request is processed on the server but the response is lost. In this case the ticket remains in the browser and the user can send it again (after refreshing for example to enable the pay button).

Currently an 'ugly' error message is shown. The system should catch this case and show the proper error message.
Steps To ReproducePut breakpoint in orderloader
submit ticket
when it hits breakpoint refresh the page, ticket is shown again
Let the server run through the breakpoint, loading the ticket
Submit the ticket
See error message
Proposed SolutionRe-use the current logic [1] to check for duplicate sending of layaways for all tickets, show a nicer message.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/98e87f3b39b6/src/org/openbravo/retail/posterminal/OrderLoader.java#l247 [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036033RR17Q3 closed mtaal Prevent duplicate/parallel processing of the same message from webpos if it gets retried due to long processing times 
related to defect 0035289 closed mtaal BUT: Duplicate transaction in POS (already done) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-08 09:19mtaalNew Issue
2017-06-08 09:19mtaalAssigned To => mtaal
2017-06-08 09:19mtaalOBNetwork customer => No
2017-06-08 09:19mtaalTriggers an Emergency Pack => No
2017-06-08 09:19mtaalReview Assigned To => marvintm
2017-06-08 09:20hgbotCheckin
2017-06-08 09:20hgbotNote Added: 0097198
2017-06-08 09:20hgbotStatusnew => resolved
2017-06-08 09:20hgbotResolutionopen => fixed
2017-06-08 09:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37dc93155f97c67749a5081f41fc00df38d53457 [^]
2017-06-08 13:44mtaalRelationship addedrelated to 0036033
2017-06-16 15:47marvintmStatusresolved => closed
2017-06-16 15:47marvintmFixed in Version => RR17Q3
2017-06-19 11:09mtaalRelationship addedrelated to 0035289

Notes
(0097198)
hgbot   
2017-06-08 09:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 37dc93155f97c67749a5081f41fc00df38d53457
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 08 09:19:56 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37dc93155f97c67749a5081f41fc00df38d53457 [^]

Fixes issue 36196: Prevent same ticket from being send twice by the user from being processed
Use optimistic locking approach of layaways for all tickets, show nicer message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderLoader.java
---