Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036166Openbravo ERP07. Sales managementpublic2017-06-01 17:022022-02-01 08:08
Reporterngarcia 
Assigned ToTriage Platform Base 
PriorityurgentSeveritymajorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket46967
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036166: Cannot add a product to a commission line if Currency is not shown in header
DescriptionCannot add a product to a commission line if Currency is not shown in header.

inpcCurrencyId is null
Steps To ReproduceAs group admin role:
   Create a Commission
   Having it open in form view add a line to it
   Open Product selector and check you can select a product
   Change the header to grid view (having Currency column hidden)
   Open Product selector and check you cannot select any product:
      "No Items to Show" is shown
   Add Currency column to the header grid
   Open Product selector and check you can select a product again
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00244033.0MP29 closed AugustoMauch When the grid calls the datasource, it should not retrieve the properties that are not shown in the grid. 
related to defect 0024402 closed AugustoMauch API Change: When the datasource is called from the grid, only the visible columns are fetched 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-01 17:02ngarciaNew Issue
2017-06-01 17:02ngarciaAssigned To => Triage Finance
2017-06-01 17:02ngarciaOBNetwork customer => Yes
2017-06-01 17:02ngarciaModules => Core
2017-06-01 17:02ngarciaSupport ticket => 46967
2017-06-01 17:02ngarciaResolution time => 1498082400
2017-06-01 17:02ngarciaTriggers an Emergency Pack => No
2017-06-01 17:02ngarciaIssue Monitored: networkb
2017-06-01 17:03ngarciaDescription Updatedbug_revision_view_page.php?rev_id=15266#r15266
2017-06-01 17:16heccamIssue Monitored: heccam
2017-06-02 09:36aferrazAssigned ToTriage Finance => platform
2017-06-02 11:05alostaleStatusnew => acknowledged
2017-06-07 16:25inigosanchezStatusacknowledged => scheduled
2017-06-07 16:25inigosanchezAssigned Toplatform => inigosanchez
2017-06-08 10:43inigosanchezNote Added: 0097202
2017-06-22 17:25caristuRelationship addedrelated to 0024403
2017-06-22 17:25caristuRelationship addedrelated to 0024402
2017-06-22 18:06caristuTypedefect => design defect
2017-06-22 18:07caristuAssigned Toinigosanchez => platform
2017-06-22 18:07caristuStatusscheduled => acknowledged
2017-06-22 18:33caristuNote Added: 0097594
2017-06-22 18:33caristuNote Edited: 0097594bug_revision_view_page.php?bugnote_id=0097594#r15399
2017-06-22 18:33caristuNote Edited: 0097594bug_revision_view_page.php?bugnote_id=0097594#r15400
2017-06-22 18:33caristuNote Edited: 0097594bug_revision_view_page.php?bugnote_id=0097594#r15401
2017-06-22 18:34caristuNote Edited: 0097594bug_revision_view_page.php?bugnote_id=0097594#r15402
2017-06-22 18:38caristuNote Edited: 0097594bug_revision_view_page.php?bugnote_id=0097594#r15403
2017-06-22 18:44inigosanchezResolution time1498082400 =>
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0097202)
inigosanchez   
2017-06-08 10:43   
When the currency field in the header tab is not displayed, currency value is not accessible and for this reason the product selector fails.

In order to resolve this problem, set "Stored in Session" for the currency column of the header tab. Setting to yes this field the data for this column will be stored as session attribute so its content will be accessible from other tab.
(0097594)
caristu   
2017-06-22 18:33   
(edited on: 2017-06-22 18:38)
With the changes introduced with 0024403 the properties which are not shown in the grid are not retrieved when the grid calls the datasource.

But even if they are not shown in the grid, some properties could be required for other reasons (see [1])

In the case of this issue we should retrieve the property in the header which is referenced by the combo in the child tab, even if it is not displayed in the grid. (In this case, the currency field is referenced in the "Filter Expression" of the product selector in the child tab).

To fix this problem in a general way, we should build a solution to retrieve also all the properties referenced by the child tabs which are not being shown in the grid. For this reason, the issue has been moved to design defect.

The workaround for the moment is to mark the column of the referenced property in the header as "Stored In Session" because this kind of properties are always retrieved even if their related field is not displayed in grid.

[1] https://code.openbravo.com/erp/devel/pi/file/ee31b75a9991/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewGridComponent.java#l229 [^]