Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0036161Openbravo ERPA. Platformpublic2017-06-01 12:242017-06-08 17:12
alostale 
alostale 
normalminorhave not tried
closedfixed 
5
 
3.0PR17Q3 
caristu
Core
No
0036161: useless log having an incorrect definition for validation rule
Incorrect validation rule definition that creates cycles are logged in FIC request as errors, the message in these logs are not very useful because they don't provide any context information.
1. As System Admin
1.1. In Windows Tab and Fields select "Add Multiple Payments P&E" window
1.2. Select Business Partner (or any other) field and unset Read Only flag (this is done just to force FIC request on record selection, there's a validation rule that causes error to be logged for this window)
2. As Openbravo Admin
2.1. Open Financial Account window, select a record and click on "Add Multiple Payments" button
2.2. In P&E grid select any record
   -> Check in logs:

d05203b3 232838 [http-bio-8080-exec-10] ERROR org.openbravo.base.exception.OBException - Error. The columns C_Currency_ID have validations which form a cycle.
No tags attached.
related to defect 0036163 closed alostale val rule referring non-existent col fails if there's a property field with same name 
blocks design defect 0036162 acknowledged Triage Platform Base clean up openbravo.log 
Issue History
2017-06-01 12:24alostaleNew Issue
2017-06-01 12:24alostaleAssigned To => platform
2017-06-01 12:24alostaleModules => Core
2017-06-01 12:24alostaleTriggers an Emergency Pack => No
2017-06-01 12:26alostaleRelationship addedblocks 0036162
2017-06-01 13:23alostaleSummaryuseless log having an incorrect definition for auxiliary input => useless log having an incorrect definition for validation rule
2017-06-01 13:23alostaleDescription Updatedbug_revision_view_page.php?rev_id=15258#r15258
2017-06-01 13:23alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15260#r15260
2017-06-01 13:26alostaleRelationship addedrelated to 0036163
2017-06-01 16:49hgbotCheckin
2017-06-01 16:49hgbotNote Added: 0097079
2017-06-01 16:49hgbotCheckin
2017-06-01 16:49hgbotNote Added: 0097080
2017-06-01 16:49hgbotStatusnew => resolved
2017-06-01 16:49hgbotResolutionopen => fixed
2017-06-01 16:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/37cb0c3edabd7011d30323ed4c720061f4c18976 [^]
2017-06-01 16:49hgbotCheckin
2017-06-01 16:49hgbotNote Added: 0097082
2017-06-01 17:16alostaleAssigned Toplatform => alostale
2017-06-01 17:17alostaleReview Assigned To => caristu
2017-06-02 18:00caristuNote Added: 0097110
2017-06-02 18:00caristuStatusresolved => closed
2017-06-02 18:00caristuFixed in Version => 3.0PR17Q3
2017-06-08 17:12hudsonbotCheckin
2017-06-08 17:12hudsonbotNote Added: 0097229
2017-06-08 17:12hudsonbotCheckin
2017-06-08 17:12hudsonbotNote Added: 0097230
2017-06-08 17:12hudsonbotCheckin
2017-06-08 17:12hudsonbotNote Added: 0097232

Notes
(0097079)
hgbot   
2017-06-01 16:49   
Repository: erp/devel/pi
Changeset: c320af7dd7e585470868a1d7d6f8145632a86f6d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 01 12:32:48 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c320af7dd7e585470868a1d7d6f8145632a86f6d [^]

related to bug 36161: useless log having an incorrect definition for val rule

  In centralized FIC error log
    - added context information (tabId, FIC mode, row id)
    - use standard log: don't print in System.err

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0097080)
hgbot   
2017-06-01 16:49   
Repository: erp/devel/pi
Changeset: 37cb0c3edabd7011d30323ed4c720061f4c18976
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 01 12:41:02 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/37cb0c3edabd7011d30323ed4c720061f4c18976 [^]

fixed bug 36161: useless log having an incorrect definition for validation rule

  Include in the log information about the columns that participate in the faling
  auxiliary input, as well as the list of columns that were sorted before the failure.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0097082)
hgbot   
2017-06-01 16:49   
Repository: erp/devel/pi
Changeset: e00c7560119e7d004e4f08aca99c615c4caae01a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 01 14:28:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e00c7560119e7d004e4f08aca99c615c4caae01a [^]

related to bug 36161: FIC log

  don't calculate log message if known not to be displayed

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0097110)
caristu   
2017-06-02 18:00   
Code reviewed + tested OK.
(0097229)
hudsonbot   
2017-06-08 17:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fda0f16ab470 [^]
Maturity status: Test
(0097230)
hudsonbot   
2017-06-08 17:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fda0f16ab470 [^]
Maturity status: Test
(0097232)
hudsonbot   
2017-06-08 17:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fda0f16ab470 [^]
Maturity status: Test