Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036124ModulesRemittancepublic2017-05-29 12:412017-06-19 16:51
Reporterpsanjuan 
Assigned Tononofrancisco 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0036124: Accounting information should be grouped by invoice when posting a remittance.
DescriptionAccounting information should be grouped by invoice when posting
Steps To ReproduceInstall remittance module and apply its datase to F&B España organization.

Go to Remittance type and select "Printable Remittance".

Fill in Accounting information for both General Ledger (EUR and USD ones).

Go to Financial Account window, and select "Cuenta de Banco". Go to Payment Method tab, and select "Remittance" payment method.

Enter a purchase order for Bebidas Alegres business partner. Select any product and enter below data:
- Ordered Qty = 5
- price = 1.00
- tax rate = Compras exentas.
Book the order.

Enter another purchase order for Bebidas Alegres business partner. Select any product and enter below data:
- Ordered Qty = 30
- price = 1.00
- tax rate = Compras exentas.
Book the order.

Go to Purchase Invoice window, and create a new one for Bebidas Alegres business partner. Use Create Lines From to select just created order lines. Change paymento method to "Remittance". Complete and Post the invoice. Take note of the due date = 28-06-2017.

Go to Remittance window and create a new one for F&B España. Enter an expected date of 30-06-2017.
Click on "Select Orders or Invoices". Once in that new window, select "Payment Out" in the field "Transaction Type" and select the purchase invoice just created for an expected amount = 35.00. Press Process.

Verify that two lines are shown. Click on Process.

No matter which option is selected to process the remittance (i.e. group by business partner), remittance posting "details" are split in two, one for each order.

See image attached.
Proposed SolutionCorrect posting details should be:

35.00 (40000) DEBIT
35.00 (43120) CREDIT
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0034432 closed collazoandy4 Openbravo ERP Accounting information should be grouped by invoice when posting payment/transaction/reconciliation 
causes defect 0038143 closed AtulOpenbravo Modules NullPointerException when posting a remittance that includes an invoice with more than two orders 
Attached Filesjpg Issue_36124.jpg (22,615) 2017-05-29 12:54
https://issues.openbravo.com/file_download.php?file_id=10803&type=bug
jpg

jpg Issue_36124_Details.jpg (12,117) 2017-05-29 12:54
https://issues.openbravo.com/file_download.php?file_id=10804&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2017-05-29 12:41psanjuanNew Issue
2017-05-29 12:41psanjuanAssigned To => Triage Finance
2017-05-29 12:41psanjuanOBNetwork customer => No
2017-05-29 12:41psanjuanRelationship addedrelated to 0034432
2017-05-29 12:52psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15233#r15233
2017-05-29 12:52psanjuanProposed Solution updated
2017-05-29 12:54psanjuanFile Added: Issue_36124.jpg
2017-05-29 12:54psanjuanFile Added: Issue_36124_Details.jpg
2017-05-31 19:50nonofranciscoAssigned ToTriage Finance => nonofrancisco
2017-05-31 19:50nonofranciscoStatusnew => scheduled
2017-05-31 19:52nonofranciscoNote Added: 0097063
2017-05-31 20:12nonofranciscoNote Edited: 0097063bug_revision_view_page.php?bugnote_id=0097063#r15254
2017-06-19 16:38aferrazRelationship replaceddepends on 0034432
2017-06-19 16:49hgbotCheckin
2017-06-19 16:49hgbotNote Added: 0097482
2017-06-19 16:49hgbotStatusscheduled => resolved
2017-06-19 16:49hgbotResolutionopen => fixed
2017-06-19 16:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/d675cb9dedd4ae9e01cda8a912d9ce1f279bbbea [^]
2017-06-19 16:49hgbotCheckin
2017-06-19 16:49hgbotNote Added: 0097483
2017-06-19 16:49hgbotCheckin
2017-06-19 16:49hgbotNote Added: 0097484
2017-06-19 16:51aferrazReview Assigned To => aferraz
2017-06-19 16:51aferrazNote Added: 0097485
2017-06-19 16:51aferrazStatusresolved => closed
2018-03-14 15:26ngarciaRelationship addedrelated to 0038143
2018-03-14 15:49ngarciaRelationship replacedcauses 0038143

Notes
(0097063)
nonofrancisco   
2017-05-31 19:52   
(edited on: 2017-05-31 20:12)
Install remittance module and apply its datase to F&B España organization.

Go to Remittance type and select "Printable Remittance".

Fill in Accounting information for both General Ledger (EUR and USD ones).

Go to Financial Account window, and select "Cuenta de Banco". Go to Payment Method tab, and select "Remittance" payment method.

Enter a purchase order for Bebidas Alegres business partner. Select any product and enter below data:
- Ordered Qty = 5
- price = 1.00
- tax rate = Compras exentas.
Book the order.

Enter another purchase order for Bebidas Alegres business partner. Select any product and enter below data:
- Ordered Qty = 30
- price = 1.00
- tax rate = Compras exentas.
Book the order.

Go to Purchase Invoice window, and create a new one for Bebidas Alegres business partner. Use Create Lines From to select just created order lines. Change paymento method to "Remittance". Complete and Post the invoice. Take note of the due date = 28-06-2017.

Go to Remittance window and create a new one for F&B España. Enter an expected date of 30-06-2017.
Click on "Select Orders or Invoices". Once in that new window, select "Payment Out" in the field "Transaction Type" and select the purchase invoice just created for an expected amount = 35.00. Press Process.

Verify that two lines are shown. Click on Process.

Post the document

Verify Posting details shows only two lines

35.00 (40000) DEBIT
35.00 (43120) CREDIT
(0097482)
hgbot   
2017-06-19 16:49   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: d675cb9dedd4ae9e01cda8a912d9ce1f279bbbea
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed May 31 14:00:00 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/d675cb9dedd4ae9e01cda8a912d9ce1f279bbbea [^]

Fixes issue 36124: Accounting information not grouped by invoice when posting

Accounting information was not properly grouped when posting a payment related
with one invoice created from several orders. Accounting info was splitted by
order when this is not necessary and confusing for end user.

Now if there is a previous Payment Detail that belongs to the same Invoice, the amounts
are added.

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
---
(0097483)
hgbot   
2017-06-19 16:49   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 9a56449876e7889c9cdf618a547c6f460e6ca9c1
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 01 16:42:54 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/9a56449876e7889c9cdf618a547c6f460e6ca9c1 [^]

Related to issue 36124: Code review improvements

Use BigDecimal.ZERO instead of new BigDecimal(0).
Changed totalAmount = amount.add(totalAmount) with totalAmount = totalAmount.add(amount) which is more understandable.

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
---
(0097484)
hgbot   
2017-06-19 16:49   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: adf441f1f1b6c18ecdbc9a50af175d89f5cdd261
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jun 19 16:44:03 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/adf441f1f1b6c18ecdbc9a50af175d89f5cdd261 [^]

Related to issue 36124: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0097485)
aferraz   
2017-06-19 16:51   
Code review + Testing OK