Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036118Retail ModulesDiscount Matrix Managementpublic2017-05-29 07:462017-06-20 16:35
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036118: After adding the Discount Matrix approval the approval object comes empty to the backend
DescriptionAfter adding the Discount Matrix approval the approval object comes empty to the backend.
This is generating wrong data as the approval record does not appear on the Backoffice.
Instead of this:
        approvals = [{
          approvalType: approvalType[i],
          userContact: supervisor.get('id'),
          created: (new Date()).getTime()
        }];
Is coming:
        approvals = [];
Steps To ReproduceUnable to reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-29 07:46guillermogilNew Issue
2017-05-29 07:46guillermogilAssigned To => Retail
2017-05-29 07:46guillermogilOBNetwork customer => Yes
2017-05-29 07:46guillermogilResolution time => 1497823200
2017-05-29 07:46guillermogilTriggers an Emergency Pack => No
2017-06-07 11:27jorge-garciaAssigned ToRetail => jorge-garcia
2017-06-09 12:01hgbotCheckin
2017-06-09 12:01hgbotNote Added: 0097277
2017-06-09 12:01hgbotStatusnew => resolved
2017-06-09 12:01hgbotResolutionopen => fixed
2017-06-09 12:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88d5704ea8d70684a45b22cffa9ec10be6a479b1 [^]
2017-06-09 12:01hgbotCheckin
2017-06-09 12:01hgbotNote Added: 0097278
2017-06-20 16:35marvintmReview Assigned To => marvintm
2017-06-20 16:35marvintmStatusresolved => closed
2017-06-20 16:35marvintmFixed in Version => RR17Q3

Notes
(0097277)
hgbot   
2017-06-09 12:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 88d5704ea8d70684a45b22cffa9ec10be6a479b1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 07 17:18:07 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88d5704ea8d70684a45b22cffa9ec10be6a479b1 [^]

Fixed issue 36118: After adding the Discount Matrix approval the approval
object comes empty to the backend

The proposed solution for this issue on particular is to show the scrim when
a approval request is triggered and hide the scrim on response (including
no connection):

---
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0097278)
hgbot   
2017-06-09 12:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0a451a8975ca62aedfd38f782bec8b89dd90c8da
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 07 17:31:00 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0a451a8975ca62aedfd38f782bec8b89dd90c8da [^]

Related to issue 36118: After adding the Discount Matrix approval the approval
object comes empty to the backend

Hidding of the popup it now done before the approval check. This way, the
scrim shown in the checkApproval works properly.

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---