Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036098Retail ModulesWeb POSpublic2017-05-25 11:302017-06-13 17:50
ReporterSandrahuguet 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusscheduledResolutionopen 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036098: getAllPreferences function is called twice during the login
DescriptiongetAllPreferences function is called twice during the login. The function is called in LoginUtils and RolePermissions.
Steps To ReproduceN/A
Proposed SolutionRolePermissions call is not necessary, the preferences should be read from the session
Additional Information
TagsPerformance
Relationships
Attached Filesdiff 36098.diff (2,930) 2017-06-13 17:50
https://issues.openbravo.com/file_download.php?file_id=10850&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-05-25 11:30SandrahuguetNew Issue
2017-05-25 11:30SandrahuguetAssigned To => Retail
2017-05-25 11:30SandrahuguetOBNetwork customer => Yes
2017-05-25 11:30SandrahuguetResolution time => 1497477600
2017-05-25 11:30SandrahuguetTriggers an Emergency Pack => No
2017-05-25 11:36SandrahuguetProposed Solution updated
2017-06-05 13:44jorge-garciaStatusnew => scheduled
2017-06-05 13:44jorge-garciaAssigned ToRetail => jorge-garcia
2017-06-07 08:57SandrahuguetTag Attached: Performance
2017-06-13 12:33marvintmNote Added: 0097358
2017-06-13 12:33marvintmOBNetwork customerYes => No
2017-06-13 12:33marvintmResolution time1497477600 =>
2017-06-13 17:50jorge-garciaFile Added: 36098.diff

Notes
(0097358)
marvintm   
2017-06-13 12:33   
The idea of the change was to read the preference values from the session. However, this would be a behavior change in the Web POS, as currently every refresh of the page loads the preference and it would no longer be the case once this change is done.

So we need to discuss internally whether the performance improvement justifies this change.