Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036074Openbravo ERPA. Platformpublic2017-05-23 16:302017-05-29 17:43
Reporterngarcia 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket46829
Regression levelProduction - Confirmed Stable
Regression date2016-10-14
Regression introduced in release3.0PR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/89f0eb718711 [^]
Triggers an Emergency PackNo
Summary0036074: inconsistent process (ad_process) configuration generates invalid web.xml
DescriptionHaving defined an inconsistent/incorrect configuration for a process (ad_process) can generate an invalid web.xml which stops Tomcat to be started.

Example of incorrect definition:
  * Report = 'N'
  * UI Pattern = Standard
  * record in AD_MODEL_OBJECT_MAPPING with object_type = 'S'
Steps To ReproduceAs System Admin role:
   1. Set Core In Development
   2. Go to Report and Process Window and select 'Print Requisition' report
   3. Set it as Report = 'N'
   4. Make any change in the Process Class tab and undo it in order the update the updated column (thus the web.xml file will be generated again)
   5. Execute in DB: update ad_model_object set object_type = 'S' where ad_model_object_id = '1004400018'
   6. Compile
   7. Try to restart Tomcat and check the following error is raised:
      Caused by: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Catalina].StandardHost[localhost].StandardContext[/openbravo]]
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:162)
    ... 6 more
Caused by: java.lang.IllegalArgumentException: Servlet mapping specifies an unknown servlet name R1004400018
    at org.apache.catalina.core.StandardContext.addServletMapping(StandardContext.java:3425)

      Check in build/javasqlc/src/web.xml file that there is an <servlet-mapping> entry for the 1004400018 ad_model_object but there is not the <servlet-class> entry
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00360793.0PR17Q2.1 closed caristu inconsistent process (ad_process) configuration generates invalid web.xml 
depends on backport 00360803.0PR17Q1.2 closed alostale inconsistent process (ad_process) configuration generates invalid web.xml 
caused by feature request 00325123.0PR17Q1 closed alostale support WildFly 10 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-23 16:30ngarciaNew Issue
2017-05-23 16:30ngarciaAssigned To => platform
2017-05-23 16:30ngarciaOBNetwork customer => Yes
2017-05-23 16:30ngarciaModules => Core
2017-05-23 16:30ngarciaResolution time => 1497304800
2017-05-23 16:30ngarciaTriggers an Emergency Pack => No
2017-05-23 16:30ngarciaIssue Monitored: networkb
2017-05-23 16:31ngarciaSupport ticket => 46829
2017-05-24 10:20alostaleRelationship addedcaused by 0032512
2017-05-24 10:26alostaleReview Assigned To => caristu
2017-05-24 10:26alostaleRegression level => Production - Confirmed Stable
2017-05-24 10:26alostaleRegression date => 2016-10-14
2017-05-24 10:26alostaleRegression introduced in release => 3.0PR17Q1
2017-05-24 10:26alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/89f0eb718711 [^]
2017-05-24 10:26alostalePriorityurgent => immediate
2017-05-24 10:26alostaleSeveritymajor => minor
2017-05-24 10:26alostaleSummaryCannot start Tomcat if a report is defined with Report = 'N', UI Pattern = Standard and has a record in AD_MODEL_OBJECT_MAPPING => inconsistent process (ad_process) configuration generates invalid web.xml
2017-05-24 10:26alostaleDescription Updatedbug_revision_view_page.php?rev_id=15206#r15206
2017-05-24 10:26alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15208#r15208
2017-05-24 10:28alostaleStatusnew => scheduled
2017-05-24 10:35alostaleAssigned Toplatform => alostale
2017-05-24 10:40hgbotCheckin
2017-05-24 10:40hgbotNote Added: 0096748
2017-05-24 10:40hgbotStatusscheduled => resolved
2017-05-24 10:40hgbotResolutionopen => fixed
2017-05-24 10:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/42059137939cc613bd94145ea7dc8eeb7fa73e55 [^]
2017-05-25 09:56caristuNote Added: 0096777
2017-05-25 09:56caristuStatusresolved => closed
2017-05-25 09:56caristuFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096983

Notes
(0096748)
hgbot   
2017-05-24 10:40   
Repository: erp/devel/pi
Changeset: 42059137939cc613bd94145ea7dc8eeb7fa73e55
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 24 10:39:33 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/42059137939cc613bd94145ea7dc8eeb7fa73e55 [^]

fixed bug 36074: inconsistent ad_process generates invalid web.xml

  Some invalid defintions of ad_process generated invalid web.xml because mapping
  was included referencing to a class that was filtered out, causing Tomcat to
  refuse to start.

  It has been fixed by adding to the query that retrieves mappings the same restrictions
  already added to the query looking for classes, so mappings will be obtained
  only if class is present.

---
M src-wad/src/org/openbravo/wad/Wad_data.xsql
---
(0096777)
caristu   
2017-05-25 09:56   
Code reviewed + testing OK
(0096983)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test