Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036047Retail ModulesWeb POSpublic2017-05-19 09:342017-06-06 10:17
Reporterpaul_guiot 
Assigned Tomigueldejuana 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036047: [SER-QA 2869] Cash up: financial movements done even if it should not
DescriptionWith a a specific configuration, when a cash up is performed, some financial movements are done even if it should not
Steps To ReproduceIn BO, Make sure that you have the following configuration:
- Payment method: Flagged as "No automatic deposit"(ex remittance)
- Payment type: NO Flagged as "Automate movement to other account"

Go to the webpos on a seller terminal and perform a cash up.

Error: No movements need to be moved!
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036127 closed Retail When reactivating a payment we wrongly take currentBalance as starting 
related to defect 0036128 new migueldejuana Rename "Automate movement to other account" check 
Attached Filesdiff issue36047.diff (4,489) 2017-05-23 13:00
https://issues.openbravo.com/file_download.php?file_id=10787&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-05-19 09:34paul_guiotNew Issue
2017-05-19 09:34paul_guiotAssigned To => Retail
2017-05-19 09:34paul_guiotResolution time => 1498860000
2017-05-19 09:34paul_guiotTriggers an Emergency Pack => No
2017-05-23 13:00marvintmFile Added: issue36047.diff
2017-05-23 13:01marvintmNote Added: 0096729
2017-05-24 13:34marvintmNote Added: 0096757
2017-05-25 11:58marvintmAssigned ToRetail => migueldejuana
2017-05-25 11:58marvintmStatusnew => scheduled
2017-05-29 15:49migueldejuanaRelationship addedrelated to 0036127
2017-05-29 15:50hgbotCheckin
2017-05-29 15:50hgbotNote Added: 0096858
2017-05-29 15:50hgbotStatusscheduled => resolved
2017-05-29 15:50hgbotResolutionopen => fixed
2017-05-29 15:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]
2017-05-29 15:57migueldejuanaRelationship addedrelated to 0036128
2017-05-30 08:50marvintmNote Added: 0096999
2017-05-30 17:04marvintmNote Added: 0097021
2017-05-30 17:04marvintmStatusresolved => new
2017-05-30 17:04marvintmResolutionfixed => open
2017-05-31 09:39hgbotCheckin
2017-05-31 09:39hgbotNote Added: 0097043
2017-05-31 09:39hgbotStatusnew => resolved
2017-05-31 09:39hgbotResolutionopen => fixed
2017-05-31 09:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/340c28bbf70f706c3984454eb7309e51a7c00d43 [^]
2017-06-06 10:17marvintmReview Assigned To => marvintm
2017-06-06 10:17marvintmStatusresolved => closed
2017-06-06 10:17marvintmFixed in Version => RR17Q3

Notes
(0096729)
marvintm   
2017-05-23 13:01   
Attached diff is the skeleton of a possible approach, but we need to review if the changes to the reconciliation ending balance make sense or not, and if the financial account balance should also be changed.
(0096757)
marvintm   
2017-05-24 13:34   
After discussing further, the changes which need to be done are:
- For automatic deposited payments which do not have "automate movement to other account" enabled: reconciliation should be done, its ending balance should be the counted amount, amount to keep in this case should be counted amount also, both transactions to automated movement should not be done

- For non-automatic deposited payments, regardless of "automate movement to other account" setting: reconciliation should never be done, amount to keep should not be changed, transactions to automate movement should also not be done.
(0096858)
hgbot   
2017-05-29 15:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3dbcb6b316eb645730de8604dbc5f2df21ef91d8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon May 29 15:50:17 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]

Fixed issue 0036047: [SER-QA 2869] Cash up: financial movements done even if it should not

- Do not create any transaction or reconciliation if payment method is No Automate Deposit

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0096999)
marvintm   
2017-05-30 08:50   
Finally, after discussing internally, it's been decided that the first discussed change for automatic deposited payments will not be implemented, because the behavior has been like this since the beginning of the Web POS, and changing it would be quite harsh for customers.

Instead, the name of the field, and its description and help information, will be updated to clarify what it actually does. This will be done as part of related issue 36128
(0097021)
marvintm   
2017-05-30 17:04   
The change which is currently committed is changing not just the automatic deposit flow but also other flow which we decided not to change after all.
(0097043)
hgbot   
2017-05-31 09:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 340c28bbf70f706c3984454eb7309e51a7c00d43
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue May 30 17:22:38 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/340c28bbf70f706c3984454eb7309e51a7c00d43 [^]

Fixed issue 0036047: [SER-QA 2869] Cash up: financial movements done even if it should not

- Remove unneeded changes

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---