Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036045Retail ModulesWeb POSpublic2017-04-27 15:402017-07-03 16:59
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR17Q2.1Fixed in VersionRR17Q2.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036045: [RR17Q2] Already paid receipts can be completed again through "Receipts" option
DescriptionAlready paid and completed receipts are possible to be completed again using "Receipts" option in certain circumstances. One of the flows is using gift card payment to pay the receipt.
Steps To Reproduce0-Login POS as vallblanca with a Gift Card properly configured.
1-Add 1x Alpine poles and complete that receipt using Gift Card to pay it.
2-Once the receipt has been completed, go to dropdown menu and click Receipts option.
3-Select the just created receipt and click Total Amount button (0.00 will be shown).
4-DEFECT: "Total is zero. No payment needed" will be shown at the right of the screen, next to the clickable "Done" button.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035867 closed ranjith_qualiantech_com [RR17Q2] Already paid receipts can be completed again through "Receipts" option 
Attached Filesdiff issue36045.diff (977) 2017-05-22 19:09
https://issues.openbravo.com/file_download.php?file_id=10776&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-05-19 09:26marvintmTypedefect => backport
2017-05-19 09:26marvintmTarget Version => RR17Q2
2017-05-22 15:47ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-05-22 16:01hgbotCheckin
2017-05-22 16:01hgbotNote Added: 0096717
2017-05-22 16:01hgbotStatusscheduled => resolved
2017-05-22 16:01hgbotResolutionopen => fixed
2017-05-22 16:01hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/ca594c5317815036302fdd3729a7139acfdc05b4 [^]
2017-05-22 16:01hgbotCheckin
2017-05-22 16:01hgbotNote Added: 0096718
2017-05-22 19:09marvintmFile Added: issue36045.diff
2017-05-22 19:10marvintmNote Added: 0096723
2017-05-22 19:10marvintmStatusresolved => new
2017-05-22 19:10marvintmResolutionfixed => open
2017-05-22 19:11marvintmTarget VersionRR17Q2 => RR17Q2.1
2017-05-22 19:16hgbotCheckin
2017-05-22 19:16hgbotNote Added: 0096724
2017-05-24 10:29lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=15210#r15210
2017-05-24 12:55ranjith_qualiantech_comStatusnew => scheduled
2017-05-25 14:35hgbotCheckin
2017-05-25 14:35hgbotNote Added: 0096802
2017-05-25 14:35hgbotCheckin
2017-05-25 14:35hgbotNote Added: 0096803
2017-05-30 15:04hgbotCheckin
2017-05-30 15:04hgbotNote Added: 0097013
2017-05-30 15:04hgbotStatusscheduled => resolved
2017-05-30 15:04hgbotResolutionopen => fixed
2017-05-30 15:04hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/ca594c5317815036302fdd3729a7139acfdc05b4 [^] => http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/d5ee6af9aaa82a4fcec6b133be6ca000f722786f [^]
2017-05-30 15:04hgbotCheckin
2017-05-30 15:04hgbotNote Added: 0097014
2017-06-20 15:47marvintmReview Assigned To => marvintm
2017-06-20 15:47marvintmStatusresolved => closed
2017-06-20 15:47marvintmFixed in Version => RR17Q2.1
2017-07-03 16:59hgbotCheckin
2017-07-03 16:59hgbotNote Added: 0097802

Notes
(0096717)
hgbot   
2017-05-22 16:01   
Repository: retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal
Changeset: ca594c5317815036302fdd3729a7139acfdc05b4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 22 19:30:22 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/ca594c5317815036302fdd3729a7139acfdc05b4 [^]

Fixes issue 36045 : Payment should not be added for paid receipt if gross amount is zero

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0096718)
hgbot   
2017-05-22 16:01   
Repository: retail/backports/3.0RR17Q2/pi-mobile
Changeset: 2992006d514c4d5bf26ef3478c250eee0165be18
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 22 19:30:48 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/pi-mobile/rev/2992006d514c4d5bf26ef3478c250eee0165be18 [^]

Verifies issue 36045 : Added automated test 'I36045_VerifyPaidReceiptPaymentLabels'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---
(0096723)
marvintm   
2017-05-22 19:10   
Repository: retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal
Changeset: e5f05d52bc256ed0ec0894adfadd1cc4acce474a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 22 19:07:44 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/e5f05d52bc256ed0ec0894adfadd1cc4acce474a [^] [^]

Related to issue 35867. Reverted change. Will be fixed in next version of 17Q2.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
(0096724)
hgbot   
2017-05-22 19:16   
Repository: retail/backports/3.0RR17Q2/pi-mobile
Changeset: 0193e7854c8bfd8fb4089cd13f6e1c4588154919
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 22 19:15:34 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/pi-mobile/rev/0193e7854c8bfd8fb4089cd13f6e1c4588154919 [^]

Related to issue 36045. Reverted change. Will be fixed in next version of 17Q2.

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---
(0096802)
hgbot   
2017-05-25 14:35   
Repository: tools/automation/pi-mobile
Changeset: 2992006d514c4d5bf26ef3478c250eee0165be18
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 22 19:30:48 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2992006d514c4d5bf26ef3478c250eee0165be18 [^]

Verifies issue 36045 : Added automated test 'I36045_VerifyPaidReceiptPaymentLabels'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---
(0096803)
hgbot   
2017-05-25 14:35   
Repository: tools/automation/pi-mobile
Changeset: 0193e7854c8bfd8fb4089cd13f6e1c4588154919
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 22 19:15:34 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0193e7854c8bfd8fb4089cd13f6e1c4588154919 [^]

Related to issue 36045. Reverted change. Will be fixed in next version of 17Q2.

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---
(0097013)
hgbot   
2017-05-30 15:04   
Repository: retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal
Changeset: d5ee6af9aaa82a4fcec6b133be6ca000f722786f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 30 18:31:19 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/d5ee6af9aaa82a4fcec6b133be6ca000f722786f [^]

Fixes issue 36045 : Payment DONE Button should be disabled if receipt is paid and its gross is zero

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0097014)
hgbot   
2017-05-30 15:04   
Repository: retail/backports/3.0RR17Q2.1/pi-mobile
Changeset: b840116fed9441ee27c2026994f54a9de1294695
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 30 18:33:27 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/pi-mobile/rev/b840116fed9441ee27c2026994f54a9de1294695 [^]

Verifies issue 36045 : Added automated test 'I36045_VerifyPaidReceiptPaymentLabels'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---
(0097802)
hgbot   
2017-07-03 16:59   
Repository: tools/automation/pi-mobile
Changeset: b840116fed9441ee27c2026994f54a9de1294695
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 30 18:33:27 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b840116fed9441ee27c2026994f54a9de1294695 [^]

Verifies issue 36045 : Added automated test 'I36045_VerifyPaidReceiptPaymentLabels'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36045_VerifyPaidReceiptPaymentLabels.java
---