Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036041Retail ModulesDiscounts and Promotionspublic2017-05-16 11:192017-05-25 14:34
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionRR17Q2Fixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-08-24
Regression introduced in releaseRR16Q4.3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/94dca5a2d2faa9390d578f061ce048616aa03514 [^]
Triggers an Emergency PackNo
Summary0036041: [RR17Q2] POS breaks when several discounts are applied to same product
DescriptionWhen two discounts are applied to same product, adding several lines of same discounted product induces errors in POS.
I have reproduced this issue in RR17Q2, RR17Q1.1 and RR16Q4.3. I have not been able to reproduce this issue in RR16Q3.5 or RR16Q2.4.
This issue has been reproduced following these test cases:
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9442 [^]
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9443 [^]
Steps To ReproduceLog in ERP as Group -Admin-The White Valley Group
Go to Discounts and Promotions window
Create new record
Header tab
Discount type: Buy X pay Y of same product
Name: Discount 3x2 of same product (Re-Factor)
Starting date: 01-01-2012
Priority: 10
Apply Next Discount/Promotion: Unchecked
Included Products: Only those defined
X: 3
Y: 2
Products tab
Product: Bottle 1 L

Product configuration:
Log in ERP as Group -Admin-The White Valley Group
Go to product window
Then select product “Bottle 1L”
Then change the field “Grouped” to
· Grouped: Unchecked

Then click Ctrl + s to save the changes
----

In Discounts and Promotions window

Create new record

Header tab

Discount type: Buy X pay Y of Different product
Name: Discount 3x2 (Re-Factor II)
Starting date: 01-01-2012
Priority: 20
Apply Next Discount/Promotion: Unchecked
Included Products: Only those defined
X: 3
Y: 2
Products tab

Product: Bottle 1 L
Product: Plastic Bottle
Product configuration:

Log in ERP as Group -Admin-The White Valley Group

Go to product window

Then select product “Plastic Bottle”

Then change the field “Grouped” to

· Grouped: Unchecked

Then click Ctrl + s to save the changes
----

Now, go to POS, login, search Bottle 1L product and click 6 times to add 6 Bottle 1L to the receipt. Verify that the total amount of the receipt is not properly calculated, and the button becomes stuck.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036082 closed Retail There are errors in the Chrome console when working in remote mode 
blocks defect 0036003 closed ranjith_qualiantech_com [RR17Q2] POS breaks when several discounts are applied to same product 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-18 15:50marvintmTypedefect => backport
2017-05-18 15:50marvintmTarget Version => RR17Q2
2017-05-19 10:10hgbotCheckin
2017-05-19 10:10hgbotNote Added: 0096672
2017-05-19 10:10hgbotStatusscheduled => resolved
2017-05-19 10:10hgbotResolutionopen => fixed
2017-05-19 10:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5fbd0b50f1ad90e371e34413b47ee88a1bdaa256 [^] => http://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/1ab49b21efc0fa4a0761578bd06556a15d91582e [^]
2017-05-19 10:11hgbotCheckin
2017-05-19 10:11hgbotNote Added: 0096673
2017-05-22 18:22marvintmReview Assigned To => marvintm
2017-05-22 18:22marvintmStatusresolved => closed
2017-05-22 18:22marvintmFixed in Version => RR17Q2
2017-05-24 12:01marvintmRelationship addedrelated to 0036082
2017-05-24 12:02marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15213#r15213
2017-05-25 14:34hgbotCheckin
2017-05-25 14:34hgbotNote Added: 0096801

Notes
(0096672)
hgbot   
2017-05-19 10:10   
Repository: retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal
Changeset: 1ab49b21efc0fa4a0761578bd06556a15d91582e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 19 12:07:23 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/org.openbravo.retail.posterminal/rev/1ab49b21efc0fa4a0761578bd06556a15d91582e [^]

Fixed issue 36041 : Validated promotions while calculating receipt taxes

* In some cases, Promotions Amount will be zero. So it needs to be validated to calculate receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0096673)
hgbot   
2017-05-19 10:11   
Repository: retail/backports/3.0RR17Q2/pi-mobile
Changeset: 41b76e9a2dcc940f1f190123e7b0479d815e47a3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 19 12:07:19 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2/pi-mobile/rev/41b76e9a2dcc940f1f190123e7b0479d815e47a3 [^]

Verifies issue 36041 : Added automated test 'I36041_VerifyDiscountWithNonGroupedProduct'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36041_VerifyDiscountWithNonGroupedProduct.java
---
(0096801)
hgbot   
2017-05-25 14:34   
Repository: tools/automation/pi-mobile
Changeset: 41b76e9a2dcc940f1f190123e7b0479d815e47a3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 19 12:07:19 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/41b76e9a2dcc940f1f190123e7b0479d815e47a3 [^]

Verifies issue 36041 : Added automated test 'I36041_VerifyDiscountWithNonGroupedProduct'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36041_VerifyDiscountWithNonGroupedProduct.java
---