Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036037Retail ModulesWeb POSpublic2017-05-18 11:442017-06-02 14:08
Reporterguillermogil 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036037: PostImportEntry hook is getting executed even if the record goes to Errors While Importing window
DescriptionPostImportEntry hook is getting executed even if the record goes to Errors While Importing window.

It shoould not call to PostImportEntry if the record fails, it can rely on several Sync errors if there are some third party listening to it.
Also it is a performance issue due to not needed calls.
Steps To ReproducePut a Breakpoint in ImportEntryProcessor.java in Execute post process hooks.

* Close the current period in the backend
* Login on WebPOS
* Create an order
The order has gone to errors and still the breakpoint has raised -> NOK

* Do a cashup
The cashup has gone to errors and still the breakpoint has raised -> NOK

* Open the periods
* Save Again the orders

Breakpoint raises -> OK


Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041109 new Triage Platform Base Openbravo ERP Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor 
causes defect 0049438 closed ranjith_qualiantech_com Retail Modules PostImportEntry is not being executed in some escenarios with multiple documents 
Attached Filesdiff issue36037mobile.diff (1,688) 2017-05-22 19:33
https://issues.openbravo.com/file_download.php?file_id=10777&type=bug
diff issue36037pi.diff (2,557) 2017-05-22 19:33
https://issues.openbravo.com/file_download.php?file_id=10778&type=bug
diff issue36037-2.diff (802) 2017-05-24 13:12
https://issues.openbravo.com/file_download.php?file_id=10792&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-05-18 11:44guillermogilNew Issue
2017-05-18 11:44guillermogilAssigned To => Retail
2017-05-18 11:44guillermogilResolution time => 1496872800
2017-05-18 11:44guillermogilTriggers an Emergency Pack => No
2017-05-18 11:48jorgewederagoIssue Monitored: jorgewederago
2017-05-22 19:33marvintmFile Added: issue36037mobile.diff
2017-05-22 19:33marvintmFile Added: issue36037pi.diff
2017-05-23 13:03marvintmAssigned ToRetail => marvintm
2017-05-23 13:03marvintmStatusnew => acknowledged
2017-05-23 13:03marvintmStatusacknowledged => scheduled
2017-05-24 13:12marvintmFile Added: issue36037-2.diff
2017-05-25 11:59marvintmAssigned Tomarvintm => migueldejuana
2017-05-31 09:38hgbotCheckin
2017-05-31 09:38hgbotNote Added: 0097042
2017-05-31 09:38hgbotStatusscheduled => resolved
2017-05-31 09:38hgbotResolutionopen => fixed
2017-05-31 09:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/909dd683aea85abf1fb4541c0a3128539d2505b2 [^]
2017-05-31 09:42hgbotCheckin
2017-05-31 09:42hgbotNote Added: 0097044
2017-05-31 09:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/909dd683aea85abf1fb4541c0a3128539d2505b2 [^] => http://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^]
2017-05-31 14:03marvintmNote Added: 0097050
2017-05-31 14:03marvintmStatusresolved => new
2017-05-31 14:03marvintmResolutionfixed => open
2017-05-31 15:23hudsonbotCheckin
2017-05-31 15:23hudsonbotNote Added: 0097057
2017-06-02 09:35hgbotCheckin
2017-06-02 09:35hgbotNote Added: 0097094
2017-06-02 09:35hgbotStatusnew => resolved
2017-06-02 09:35hgbotResolutionopen => fixed
2017-06-02 09:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e27823a9673d182099476617d87dd400100180c7 [^]
2017-06-02 14:08marvintmReview Assigned To => marvintm
2017-06-02 14:08marvintmStatusresolved => closed
2017-06-02 14:08marvintmFixed in Version => RR17Q3
2019-06-17 17:10caristuRelationship addedrelated to 0041109
2022-05-30 15:05gorkaionRelationship addedcauses 0049438

Notes
(0097042)
hgbot   
2017-05-31 09:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 909dd683aea85abf1fb4541c0a3128539d2505b2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue May 30 17:11:57 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/909dd683aea85abf1fb4541c0a3128539d2505b2 [^]

Fixed issue 0036037: PostImportEntry hook is getting executed even if the record goes to Errors While Importing window

- Move hooks to MobileImportEntryProcessorRunnable and execute them just when success

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java
---
(0097044)
hgbot   
2017-05-31 09:42   
Repository: erp/devel/pi
Changeset: 302d949e828a772c0778017126f54b8563a9d6ec
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue May 30 17:12:16 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^]

Fixed issue 0036037: PostImportEntry hook is getting executed even if the record goes to Errors While Importing window

- Move hooks to MobileImportEntryProcessorRunnable and execute them just when success

---
M src/org/openbravo/service/importprocess/ImportEntryPostProcessor.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---
(0097050)
marvintm   
2017-05-31 14:03   
getString should be get, otherwise the hooks are never executed, even if the result is correct.
(0097057)
hudsonbot   
2017-05-31 15:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e39fb42d847c [^]
Maturity status: Test
(0097094)
hgbot   
2017-06-02 09:35   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e27823a9673d182099476617d87dd400100180c7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 01 13:02:00 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e27823a9673d182099476617d87dd400100180c7 [^]

Fixed issue 0036037: PostImportEntry hook is getting executed even if the record goes to Errors While Importing window

- Change getString by get

---
M src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java
---