Openbravo Issue Tracking System - Retail Modules
View Issue Details
0036027Retail ModulesWeb POSpublic2017-05-17 18:272017-05-30 13:38
adrianromero 
ranjith_qualiantech_com 
urgentmajorhave not tried
closedfixed 
5
 
RR17Q3 
marvintm
No
0036027: [SER-QA 2796] Wrong behavior in customer selector depending on previous steps
In the main screen, when clicking on the customer selector it is supposed to display the current selected customer and the filter empty. But depending on the actions done before, it may show a previous filter
1.- Login in Web POS
2.- Click on the customer selector and execute a filter
3.- In one of the results, click on ... to display the contextual menu and select "Manage addresses.
4.- In one of the results click on ... to display the contextual menu and select "Assign to receipt (both)"
5.- Observe the customer and address selected has been properly assigned to the receipt.
6.- Click again on the customer selector and observe that instead of showing just one result with the selected customer and a clean filter, it is displayed all the results of the filter executed in step 2. This is wrong.
This wrong behaviour is because the "initialized" field of the customer selector dialog is not updated after selecting the customer and address in the address selector.

It is attached a proposal to fix that forces to initialize the customer selector dialog when clicking on the "customer" button. Observe that this fix only modifies the behavior of the customer selector dialog and only in the case of clicking in the main receipt window. if this fix is considered the right approach, it has to be spread in all dialogs and actions of the application.

It should be also a good idea to explore a solution that has less impact in code modified that does not require to do modifications in all the application
SER-QA
diff initialized-mobile-core.diff (797) 2017-05-17 18:35
https://issues.openbravo.com/file_download.php?file_id=10768&type=bug
diff initialized-retail-posterminal.diff (3,584) 2017-05-17 18:35
https://issues.openbravo.com/file_download.php?file_id=10769&type=bug
Issue History
2017-05-17 18:27adrianromeroNew Issue
2017-05-17 18:27adrianromeroAssigned To => Retail
2017-05-17 18:27adrianromeroResolution time => 1496181600
2017-05-17 18:27adrianromeroTriggers an Emergency Pack => No
2017-05-17 18:28adrianromeroTag Attached: SER-QA
2017-05-17 18:33adrianromeroProposed Solution updated
2017-05-17 18:33adrianromeroTypedesign defect => defect
2017-05-17 18:35adrianromeroFile Added: initialized-mobile-core.diff
2017-05-17 18:35adrianromeroFile Added: initialized-retail-posterminal.diff
2017-05-23 12:13ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-05-23 12:13ranjith_qualiantech_comStatusnew => scheduled
2017-05-24 14:19hgbotCheckin
2017-05-24 14:19hgbotNote Added: 0096758
2017-05-24 14:20hgbotCheckin
2017-05-24 14:20hgbotNote Added: 0096759
2017-05-24 14:20hgbotStatusscheduled => resolved
2017-05-24 14:20hgbotResolutionopen => fixed
2017-05-24 14:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8faa772de10c47b66620aacb847578ca87cb1f54 [^]
2017-05-24 14:20hgbotCheckin
2017-05-24 14:20hgbotNote Added: 0096760
2017-05-30 13:38marvintmReview Assigned To => marvintm
2017-05-30 13:38marvintmStatusresolved => closed
2017-05-30 13:38marvintmFixed in Version => RR17Q3

Notes
(0096758)
hgbot   
2017-05-24 14:19   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e244a2f53a66e367641f349b95fa4ccba66e5c6d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 24 17:48:14 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e244a2f53a66e367641f349b95fa4ccba66e5c6d [^]

Related to issue 36027 : Re-Initialize ModalSelector while executeOnShow on initial opening

* ModalSelector should be reinitialized based on the args attribute "clean"

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-advancedfilterselector.js
---
(0096759)
hgbot   
2017-05-24 14:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8faa772de10c47b66620aacb847578ca87cb1f54
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 24 17:48:08 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8faa772de10c47b66620aacb847578ca87cb1f54 [^]

Fixed issue 36027 : Re-Initialize Customer ModalSelector while executeOnShow

* Customer ModalSelector should be reinitialized based on the args attribute "clean"

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/bplocationship.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js
---
(0096760)
hgbot   
2017-05-24 14:20   
Repository: tools/automation/pi-mobile
Changeset: 96a8758faee0044a8b55287721900e8d7c0d5b04
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 24 17:48:04 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/96a8758faee0044a8b55287721900e8d7c0d5b04 [^]

Verifies issue 36027 : Added automated test 'I36027_VerifyCustomerPopupInitialized'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I36027_VerifyCustomerPopupInitialized.java
---