Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036021Retail ModulesStoreServerpublic2017-05-17 12:332017-06-12 18:34
ReporterAugustoMauch 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036021: If the mobile.server.key defined in Openbravo.properties is wrong, Tomcat should not start
DescriptionIThe mobile.server.key defined in Openbravo.properties is used to identify the entry from the OBMOBC_SERVER_DEFINITION table that represents the current server.

It can be null in non-multiserver environments, or have a value which is equal to the mobileServerKey column of one of the entries in the OBMOBC_SERVER_DEFINITION table. If it has a wrong value, then an error message should be shown, and Tomcat should not be started.

With this:
- It will be possible to detect as soon as possible if a store server is not properly configured
- Many exceptions that would be thrown because of the wrong mobile.server.key will be prevented.
Steps To ReproduceIn a multiserver environment:
- Change the mobile.server.key in Openbravo.properties to a wrong value.
- Start Tomcat:
* Even though it seems Tomcat is started, Openbravo will not be properly deployed, the login page will not load
* There will be lots of errors in the log, like this one
16914 [localhost-startStop-1] ERROR org.openbravo.base.exception.OBException - Server not defined Central1
org.openbravo.base.exception.OBException: Server not defined Central1
    at org.openbravo.mobile.core.servercontroller.MobileServerController.getMobileServer(MobileServerController.java:445)
    at org.openbravo.mobile.core.servercontroller.MobileServerController.getThisServerDefinitionId(MobileServerController.java:469)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-17 12:33AugustoMauchNew Issue
2017-05-17 12:33AugustoMauchAssigned To => AugustoMauch
2017-05-17 12:33AugustoMauchOBNetwork customer => No
2017-05-17 12:33AugustoMauchTriggers an Emergency Pack => No
2017-05-17 13:09AugustoMauchReview Assigned To => mtaal
2017-05-17 13:10hgbotCheckin
2017-05-17 13:10hgbotNote Added: 0096640
2017-05-17 13:10hgbotStatusnew => resolved
2017-05-17 13:10hgbotResolutionopen => fixed
2017-05-17 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ecd3c8a141ffe51381b08af3f086f0128e3e7a1d [^]
2017-05-21 23:02mtaalAssigned ToAugustoMauch => mtaal
2017-05-21 23:03mtaalNote Added: 0096690
2017-05-21 23:03mtaalStatusresolved => new
2017-05-21 23:03mtaalResolutionfixed => open
2017-05-21 23:03mtaalReview Assigned Tomtaal => AugustoMauch
2017-06-08 09:27hgbotCheckin
2017-06-08 09:27hgbotNote Added: 0097199
2017-06-08 09:27hgbotStatusnew => resolved
2017-06-08 09:27hgbotResolutionopen => fixed
2017-06-08 09:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ecd3c8a141ffe51381b08af3f086f0128e3e7a1d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/489d3bd3bc7f7743fa35c75776016bc2b4e828a4 [^]
2017-06-12 18:34AugustoMauchNote Added: 0097327
2017-06-12 18:34AugustoMauchStatusresolved => closed

Notes
(0096640)
hgbot   
2017-05-17 13:10   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ecd3c8a141ffe51381b08af3f086f0128e3e7a1d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 17 13:04:44 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ecd3c8a141ffe51381b08af3f086f0128e3e7a1d [^]

Fixes issue 36021: Tomcat does not start if mobile.server.key is wrong

An error log message will be written, and Tomcat will not be started. Before this change Tomcat started, but Openbravo was not properly deployed.

---
M src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java
---
(0096690)
mtaal   
2017-05-21 23:03   
re-open to add extra output streams
(0097199)
hgbot   
2017-06-08 09:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 489d3bd3bc7f7743fa35c75776016bc2b4e828a4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 08 09:27:16 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/489d3bd3bc7f7743fa35c75776016bc2b4e828a4 [^]

Fixes issue 36021: If the mobile.server.key defined in Openbravo.properties is wrong, Tomcat should not start
Log the exception to more output streams

---
M src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java
---
(0097327)
AugustoMauch   
2017-06-12 18:34   
Code reviewed and verified