Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035974Retail ModulesWeb POSpublic2017-05-11 13:592017-05-17 13:54
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035974: It's possible to apply a manual promotion to a negative or a return line
DescriptionIt's possible to apply a discretionary promotion to a negative or a return line.

In general, the negative lines are not being considered by automatic promotions. Manual promotions should work the same
Steps To Reproduce1) Log in the WebPOS
2) Add four different products to a ticket
3) Select one line a click on Return Line button.
4) Go to menu and click on receipt discounts.
5) Select promotion variable 5% and click on apply all lines checkbox.. Finally click on apply button
6) Check the negative line has a promotion.(This is wrong)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039495 closed jorge-garcia It is not possible to apply a manual promotion/discount to a negative line 
related to defect 0051659 closed ranjith_qualiantech_com Wrong discounts in deleted Lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-11 13:59jorge-garciaNew Issue
2017-05-11 13:59jorge-garciaAssigned To => jorge-garcia
2017-05-11 13:59jorge-garciaResolution time => 1496268000
2017-05-11 13:59jorge-garciaTriggers an Emergency Pack => No
2017-05-11 16:17jorge-garciaStatusnew => scheduled
2017-05-15 09:03hgbotCheckin
2017-05-15 09:03hgbotNote Added: 0096579
2017-05-15 09:03hgbotStatusscheduled => resolved
2017-05-15 09:03hgbotResolutionopen => fixed
2017-05-15 09:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12a71cc328da555c033b2c944ac68c61990fd4b6 [^]
2017-05-15 09:03hgbotCheckin
2017-05-15 09:03hgbotNote Added: 0096580
2017-05-17 13:46hgbotCheckin
2017-05-17 13:46hgbotNote Added: 0096642
2017-05-17 13:54marvintmReview Assigned To => marvintm
2017-05-17 13:54marvintmStatusresolved => closed
2017-05-17 13:54marvintmFixed in Version => RR17Q3
2018-10-22 12:50anderarangurenRelationship addedrelated to 0039495
2023-02-21 15:01gorkaionRelationship addedrelated to 0051659

Notes
(0096579)
hgbot   
2017-05-15 09:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12a71cc328da555c033b2c944ac68c61990fd4b6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 11 14:01:22 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12a71cc328da555c033b2c944ac68c61990fd4b6 [^]

Fixed issue 35974: It's possible to apply a manual promotion to a negative
or a return line

The solution is to avoid to apply lines to negative lines even if it has been
selected by the user.

A warning message is shown to indicate the promotions has not been applied
for negative lines.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---
(0096580)
hgbot   
2017-05-15 09:03   
Repository: tools/automation/pi-mobile
Changeset: 40acd0c10f87691495f0908b00630151c5917b6f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri May 12 12:08:48 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/40acd0c10f87691495f0908b00630151c5917b6f [^]

Verifies issue 35974: It's possible to apply a manual promotion to a negative or
a return line

Remove four test from pi-mobile because essentially was doing the same checks.

Added two test, executed in highvol and normal flow, to test the new way manual
promotions works with return or negative lines.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLines.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresent.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesI.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
---
(0096642)
hgbot   
2017-05-17 13:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3289e74e7cf9d43fbe0d52eeffcffcbf7c2deb1f
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed May 17 13:45:42 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3289e74e7cf9d43fbe0d52eeffcffcbf7c2deb1f [^]

Related to issue 35974. Improved message.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---