0035971: It is possible to synchronize a POS Order with a Return document number

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0035971

Retail Modules

Web POS

public

2017-05-10 18:17

2017-05-29 13:01

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0035971: It is possible to synchronize a POS Order with a Return document number

Description

When the document number for returns is configured in a terminal, it is possible to end up synchronizing a normal receipt with a return document number.

Steps To Reproduce

Login in backend.
Go to the preference window and create the preference 'Web POS Service Return Approval' with value 'N' for everyone.
Go to the POS Terminal window, open the VBS-1 record and define the 'Return No Prefix': VBS1RET.

Login in web pos.
Create a ticket with a product and a related service (i.e. Avalanche transceiver classic + Phone consulting MK2).
Create a new ticket and add an Avalanche Transceiver. Write down the document number of the ticket.
Go to the Menu > Verified Returns and open the ticket with the product and the service.
Select both lines and click on Apply.
Since the 'Web POS Service Return Approval' preference is defined with a value of 'N', the 'Approval Required' popup is shown and the return flow is stopped.
Click on Ok and realize that the document number of the open ticket is now VBS1RET/... even if it contains a positive line.
Now it would be possible to click on the total amount button and complete the ticket with a wrong document number.

Proposed Solution

The logic to switch from a normal document number to a return document number is done in several places: when lines are added/modified, when the Return this Receipt menu action is used, and when lines are added using the Verified Returns option.
Since the Verified Returns action is going to trigger the line changes anyway, the documentNo change could be removed from the Verified Returns flow, avoiding the reported problem, where the flow is stopped before adding the lines.

Additional Information