Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035931Retail ModulesWeb POSpublic2017-05-04 16:332017-05-18 12:28
Reporterprakashmurugesan88 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035931: [SER-QA 2815] Business Partner's Invoice Address[CityName, CountryName and PostCode] is updated with Shipping Address Value
DescriptionIn WEBPOS,

If a particular Business partner has different Invoice Address and Shipping Address.
And if the preference "Enable Remote for Customer" is "Y".

While assigning the corresponding business partner to the receipt.
Invoice Address's CityName, CountryName and PostCode is updated with Shipping Address's CityName, CountryName and PostCode.
Steps To ReproduceSetup:
Configure Business Partner with different Invoicing and Shipping Address.
Set preference "Enable Remote for Customer" to "Y".

In WebPos:
Create a receipt by selecting the corresponding business partner.

Issue:
Once the business partner is added.
In WEB SQL of Browser,
Check value for Invoice Address's CityName, CountryName and PostCode.

eg to check city name:
select name, cityname, shipcityname from c_bpartner
Please refer image in attachment

These values are not same as the one that is configured.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Filespng InvoiceAddrIssue.png (87,810) 2017-05-04 16:33
https://issues.openbravo.com/file_download.php?file_id=10724&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-05-04 16:33prakashmurugesan88New Issue
2017-05-04 16:33prakashmurugesan88Assigned To => Retail
2017-05-04 16:33prakashmurugesan88File Added: InvoiceAddrIssue.png
2017-05-04 16:33prakashmurugesan88Resolution time => 1495058400
2017-05-04 16:33prakashmurugesan88Triggers an Emergency Pack => No
2017-05-04 16:34prakashmurugesan88Tag Attached: SER-QA
2017-05-04 17:14adrianromeroNote Added: 0096399
2017-05-04 17:14adrianromeroSummarySER-QA <2815> Business Partner's Invoice Address[CityName, CountryName and PostCode] is updated with Shipping Address Value => [SER-QA 2815] Business Partner's Invoice Address[CityName, CountryName and PostCode] is updated with Shipping Address Value
2017-05-08 11:55jorge-garciaStatusnew => scheduled
2017-05-08 11:55jorge-garciaAssigned ToRetail => jorge-garcia
2017-05-09 10:08hgbotCheckin
2017-05-09 10:08hgbotNote Added: 0096474
2017-05-09 10:08hgbotStatusscheduled => resolved
2017-05-09 10:08hgbotResolutionopen => fixed
2017-05-09 10:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1f6301ff380aaee5fc83a368c32b2b28ed88ac74 [^]
2017-05-09 10:11hgbotCheckin
2017-05-09 10:11hgbotNote Added: 0096476
2017-05-09 16:32hgbotCheckin
2017-05-09 16:32hgbotNote Added: 0096493
2017-05-18 12:26marvintmReview Assigned To => marvintm
2017-05-18 12:26marvintmStatusresolved => closed
2017-05-18 12:26marvintmFixed in Version => RR17Q3
2017-05-18 12:26marvintmStatusclosed => new
2017-05-18 12:26marvintmResolutionfixed => open
2017-05-18 12:26marvintmFixed in VersionRR17Q3 =>
2017-05-18 12:27marvintmStatusnew => scheduled
2017-05-18 12:28marvintmStatusscheduled => resolved
2017-05-18 12:28marvintmFixed in Version => RR17Q3
2017-05-18 12:28marvintmResolutionopen => fixed
2017-05-18 12:28marvintmStatusresolved => closed

Notes
(0096399)
adrianromero   
2017-05-04 17:14   
The problem is in the function setBPLocations: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/de1e76f7e93f/web/org.openbravo.retail.posterminal/js/model/businesspartner.js#l238 [^]

It seems that when remote customers is activated the fields cityName, postalName and postalCode are filled in with the shipment address details and not invoice address details
(0096474)
hgbot   
2017-05-09 10:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1f6301ff380aaee5fc83a368c32b2b28ed88ac74
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 08 11:57:17 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1f6301ff380aaee5fc83a368c32b2b28ed88ac74 [^]

Fixed issue 35931: [SER-QA 2815] Business Partner's Invoice Address is
updated with Shipping Address Value

The solution is to use the billing address info if it exists. There is
necessary to update those fields if the billing address doesn’t exists
with the info of the shipping.

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---
(0096476)
hgbot   
2017-05-09 10:11   
Repository: tools/automation/pi-mobile
Changeset: 8dd7eb4ccab1953a6f6a6c1f38730faacb6d4b63
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 08 13:12:39 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8dd7eb4ccab1953a6f6a6c1f38730faacb6d4b63 [^]

Verifies issue 35931: [SER-QA 2815] Business Partner's Invoice Address is
updated with Shipping Address Value

Added test I35931_SaveCorrectlyCustomerShipmentAndBillingInfo.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35931_SaveCorrectlyCustomerShipmentAndBillingInfo.java
---
(0096493)
hgbot   
2017-05-09 16:32   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 3b2900c6333da9d60a195249e91f9e5ee4b8089b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 08 13:23:44 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/3b2900c6333da9d60a195249e91f9e5ee4b8089b [^]

Related to issue 35931: [SER-QA 2815] Business Partner's Invoice Address is
updated with Shipping Address Value

Change locations from Stephane Cluster customer to set two different location
from shipping and invoicing.

---
M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER_LOCATION.xml
M referencedata/sampledata/The_White_Valley_Group/C_LOCATION.xml
---