Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035925Openbravo ERPB. User interfacepublic2017-05-04 10:562017-05-29 17:43
Reporteralostale 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2017-04-06
Regression introduced in releasepi
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
Triggers an Emergency PackNo
Summary0035925: hide forge image doesn't work in login page
DescriptionWhen system is configured not to show forge image logo in login page:
1. The image is still shown
2. The layout is broken
Steps To ReproduceIn a professional instance:
1. Login as System Admin
2. Open System Info window
3. Unset "Show Forge Image Logo"
4. Log out
   -> Check Login page:
      * Logo image is shown
      * Layout is slightly broken
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0035386 closed caristu Login page needs some clean up 
Attached Filespng Selection_179.png (71,297) 2017-05-04 10:56
https://issues.openbravo.com/file_download.php?file_id=10721&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-05-04 10:56alostaleNew Issue
2017-05-04 10:56alostaleAssigned To => platform
2017-05-04 10:56alostaleModules => Core
2017-05-04 10:56alostaleRegression level => Pre packaging ( pi )
2017-05-04 10:56alostaleRegression date => 2017-04-06
2017-05-04 10:56alostaleRegression introduced in release => pi
2017-05-04 10:56alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/68a8d2bbfff523ea5d907e4e963ae4ff296403d7 [^]
2017-05-04 10:56alostaleTriggers an Emergency Pack => No
2017-05-04 10:56alostaleFile Added: Selection_179.png
2017-05-04 10:56alostaleRelationship addedcaused by 0035386
2017-05-04 13:28caristuAssigned Toplatform => caristu
2017-05-04 16:20hgbotCheckin
2017-05-04 16:20hgbotNote Added: 0096393
2017-05-04 16:20hgbotStatusnew => resolved
2017-05-04 16:20hgbotResolutionopen => fixed
2017-05-04 16:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a9c576191789f579c2a355ae8f20748f4496166a [^]
2017-05-04 16:21caristuReview Assigned To => alostale
2017-05-05 14:05alostaleNote Added: 0096419
2017-05-05 14:05alostaleStatusresolved => closed
2017-05-05 14:05alostaleFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096943

Notes
(0096393)
hgbot   
2017-05-04 16:20   
Repository: erp/devel/pi
Changeset: a9c576191789f579c2a355ae8f20748f4496166a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu May 04 16:15:04 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a9c576191789f579c2a355ae8f20748f4496166a [^]

fixes issue 35925: hide forge image doesn't work in login page

Some styles were missing in the loginStyles file, which after issue[1] is the new css file that keeps all the styles used within the login page. The missing styles were wrongly detected as not used, because they are not directly referenced in the html code but applied dynamically through javascript depending on the system information configuration.

[1] https://issues.openbravo.com/view.php?id=35386 [^]

---
M modules/org.openbravo.userinterface.skin.250to300Comp/web/org.openbravo.userinterface.skin.250to300Comp/skins/250to300Comp/loginStyles.css
---
(0096419)
alostale   
2017-05-05 14:05   
code reviewed + tested
(0096943)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test