Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035867Retail ModulesWeb POSpublic2017-04-27 15:402017-06-20 15:47
Reporterlorenzofidalgo 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035867: [RR17Q2] Already paid receipts can be completed again through "Receipts" option
DescriptionAlready paid and completed receipts are possible to be completed again using "Receipts" option in certain circumstances. One of the flows is using gift card payment to pay the receipt.
Steps To Reproduce0-Login POS as vallblanca with a Gift Card properly configured.
1-Add 1x Alpine poles and complete that receipt using Gift Card to pay it.
2-Once the receipt has been completed, go to dropdown menu and click Receipts option.
3-Select the just created receipt and click Total Amount button (0.00 will be shown).
4-DEFECT: "Total is zero. No payment needed" will be shown at the right of the screen, next to the clickable "Done" button.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036045RR17Q2.1 closed ranjith_qualiantech_com [RR17Q2] Already paid receipts can be completed again through "Receipts" option 
Attached Filespng PossibleToCompleteAPaidReceipt.png (181,357) 2017-04-27 15:40
https://issues.openbravo.com/file_download.php?file_id=10696&type=bug
png

png PossibleToPayACompletedReceipt(Discount).png (186,535) 2017-04-27 15:41
https://issues.openbravo.com/file_download.php?file_id=10697&type=bug
png

patch issue0035867.patch (1,182) 2017-05-06 00:53
https://issues.openbravo.com/file_download.php?file_id=10726&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-04-27 15:40lorenzofidalgoNew Issue
2017-04-27 15:40lorenzofidalgoAssigned To => Retail
2017-04-27 15:40lorenzofidalgoFile Added: PossibleToCompleteAPaidReceipt.png
2017-04-27 15:40lorenzofidalgoOBNetwork customer => No
2017-04-27 15:40lorenzofidalgoTriggers an Emergency Pack => No
2017-04-27 15:41lorenzofidalgoFile Added: PossibleToPayACompletedReceipt(Discount).png
2017-04-27 15:42lorenzofidalgoSeverityminor => major
2017-04-27 15:42lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=15070#r15070
2017-04-27 18:15mario_castelloAssigned ToRetail => mario_castello
2017-05-02 22:42mario_castelloStatusnew => acknowledged
2017-05-02 22:42mario_castelloStatusacknowledged => scheduled
2017-05-06 00:53mario_castelloFile Added: issue0035867.patch
2017-05-16 16:38mario_castelloAssigned Tomario_castello => Retail
2017-05-16 16:39mario_castelloStatusscheduled => acknowledged
2017-05-19 09:26marvintmStatusacknowledged => scheduled
2017-05-19 09:26marvintmAssigned ToRetail => ranjith_qualiantech_com
2017-05-22 15:32hgbotCheckin
2017-05-22 15:32hgbotNote Added: 0096711
2017-05-22 15:32hgbotStatusscheduled => resolved
2017-05-22 15:32hgbotResolutionopen => fixed
2017-05-22 15:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abd7558b80ae28794fb708181b7756015399ed89 [^]
2017-05-22 15:32hgbotCheckin
2017-05-22 15:32hgbotNote Added: 0096712
2017-05-22 19:08hgbotCheckin
2017-05-22 19:08hgbotNote Added: 0096722
2017-05-22 19:09marvintmStatusresolved => new
2017-05-22 19:09marvintmResolutionfixed => open
2017-05-22 19:11marvintmNote Deleted: 0096722
2017-05-22 19:17marvintmNote Added: 0096725
2017-05-23 09:53ranjith_qualiantech_comStatusnew => scheduled
2017-05-24 10:03hgbotCheckin
2017-05-24 10:03hgbotNote Added: 0096742
2017-05-24 10:04hgbotCheckin
2017-05-24 10:04hgbotNote Added: 0096743
2017-05-24 10:04hgbotStatusscheduled => resolved
2017-05-24 10:04hgbotResolutionopen => fixed
2017-05-24 10:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abd7558b80ae28794fb708181b7756015399ed89 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/516f91cf47140b2a92e9598e2b3a958ceef8ef7a [^]
2017-05-24 10:30lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=15211#r15211
2017-06-20 15:47marvintmReview Assigned To => marvintm
2017-06-20 15:47marvintmStatusresolved => closed
2017-06-20 15:47marvintmFixed in Version => RR17Q3

Notes
(0096711)
hgbot   
2017-05-22 15:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: abd7558b80ae28794fb708181b7756015399ed89
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 22 19:01:25 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abd7558b80ae28794fb708181b7756015399ed89 [^]

Fixes issue 35867 : Payment should not be added for paid receipt if gross amount is zero

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0096712)
hgbot   
2017-05-22 15:32   
Repository: tools/automation/pi-mobile
Changeset: 8bc49bb4a348b1850e119cac2b2465e60bb9afe1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 22 19:01:44 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8bc49bb4a348b1850e119cac2b2465e60bb9afe1 [^]

Verifies issue 35867 : Added automated test 'I35867_VerifyPaidReceiptPaymentLabels'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35867_VerifyPaidReceiptPaymentLabels.java
---
(0096725)
marvintm   
2017-05-22 19:17   
The fix would be better in the place described in the patch attached to the issue.
(0096742)
hgbot   
2017-05-24 10:03   
Repository: tools/automation/pi-mobile
Changeset: 7e7fb20c1b788d21a9b769de581d06ce73860ce9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 24 13:33:04 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7e7fb20c1b788d21a9b769de581d06ce73860ce9 [^]

Verifies issue 35867 : Modified automated test 'I35867_VerifyPaidReceiptPaymentLabels'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35867_VerifyPaidReceiptPaymentLabels.java
---
(0096743)
hgbot   
2017-05-24 10:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 516f91cf47140b2a92e9598e2b3a958ceef8ef7a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 24 13:32:51 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/516f91cf47140b2a92e9598e2b3a958ceef8ef7a [^]

Fixes issue 35867 : Payment DONE Button should be disabled if receipt is paid and its gross is zero

Backed out changeset: abd7558b80ae

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---